You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Current implementation of chip-tool allows a user to generate a QR code with the required fields (./out/chip-tool/chip-tool payload generate-qrcode [--payload] [--discriminator] [--setup-pin-code] [--version] [--vendor-id] [--product-id] [--commissioning-mode] [--allow-invalid-payload] [--rendezvous]) but does not allow for the optional TLV data to be included.
This is needed to properly test that a DUT=commissioner can parse a QR code (with TLV data) and sort out the needed required fields ( [--payload] [--discriminator] [--setup-pin-code] [--version] [--vendor-id] [--product-id] [--commissioning-mode] [--rendezvous])
Spec Reference
5.1.3. QR Code - Table 35. Packed Binary Data Structure for Onboarding Payload
Appendix A: Tag-length-value (TLV) Encoding Format
Proposed Solution
Add a way to add TLV data to a QR code through an optional field in the ./chip-tool payload generate-qrcode command
The text was updated successfully, but these errors were encountered:
Specific changes:
1) Clarify the naming of some of the chip-tool payload arguments and add
documentation.
2) Fix chip-tool handling of the existing-payload argument so that we error out
on invalid existing payloads instead of silently pressing on.
3) Add a way to pass in the TLV-encoded extra bytes to be added to a payload.
Unfortunately, only tags that our SetupPayload knows about right now are
supported.
4) Add a function on QRCodeSetupPayloadGenerator that allows generating a code
without having to guess at how much space the TLV will take up.
5) Add tests for that new function.
Fixesproject-chip#20226
Specific changes:
1) Clarify the naming of some of the chip-tool payload arguments and add
documentation.
2) Fix chip-tool handling of the existing-payload argument so that we error out
on invalid existing payloads instead of silently pressing on.
3) Add a way to pass in the TLV-encoded extra bytes to be added to a payload.
Unfortunately, only tags that our SetupPayload knows about right now are
supported.
4) Add a function on QRCodeSetupPayloadGenerator that allows generating a code
without having to guess at how much space the TLV will take up.
5) Add tests for that new function.
Fixes#20226
Problem
Current implementation of chip-tool allows a user to generate a QR code with the required fields (
./out/chip-tool/chip-tool payload generate-qrcode [--payload] [--discriminator] [--setup-pin-code] [--version] [--vendor-id] [--product-id] [--commissioning-mode] [--allow-invalid-payload] [--rendezvous]
) but does not allow for the optional TLV data to be included.This is needed to properly test that a DUT=commissioner can parse a QR code (with TLV data) and sort out the needed required fields ( [--payload] [--discriminator] [--setup-pin-code] [--version] [--vendor-id] [--product-id] [--commissioning-mode] [--rendezvous])
Spec Reference
5.1.3. QR Code - Table 35. Packed Binary Data Structure for Onboarding Payload
Appendix A: Tag-length-value (TLV) Encoding Format
Proposed Solution
Add a way to add TLV data to a QR code through an optional field in the
./chip-tool payload generate-qrcode
commandThe text was updated successfully, but these errors were encountered: