FIX TSTST-2.2 script #20166
Merged
FIX TSTST-2.2 script #20166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aligned the thermostat PICS in ci-pics-values with the feature map in all-clusters-app.zap HEAT | COOL | AUTO Updated the Test-TC-TSTAT_2_2.yaml to properly deal with AUTO MODE Validated all steps pass with HEAT, COOL, HEAT&COOL and those permutations along with OCC and AUTO. Addresses Test Plan issues 1379 and 1456
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple and
kpschoedel
|
PR #20166: Size comparison from 31ddf98 to d5c1e29 Increases (4 builds for cc13x2_26x2, nrfconnect, telink)
Decreases (3 builds for cc13x2_26x2, esp32)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Jun 30, 2022
examples/all-clusters-app/all-clusters-common/all-clusters-app.zap
Outdated
Show resolved
Hide resolved
examples/all-clusters-app/all-clusters-common/all-clusters-app.zap
Outdated
Show resolved
Hide resolved
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
chrisbeach59
force-pushed
the
TSTST-1379&1456
branch
from
48d9d19 to
18aa979
Compare
|
PR #20166: Size comparison from 37bb2df to 64d87a0 Increases (6 builds for cc13x2_26x2, cyw30739, nrfconnect, telink)
Decreases (2 builds for cc13x2_26x2)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Added Feature flags 3 and 4
|
PR #20166: Size comparison from 37bb2df to 7670a3e Increases (3 builds for cc13x2_26x2, cyw30739, telink)
Decreases (3 builds for bl602, cc13x2_26x2)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
approved these changes
Jul 14, 2022
|
PR #20166: Size comparison from 415ee2f to 50521c4 Increases above 0.2%:
Increases (4 builds for esp32, linux, nrfconnect)
Decreases (3 builds for bl602, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
github-actions bot
pushed a commit
that referenced
this pull request
Jul 14, 2022
* FIX TSTST-2.2 script Aligned the thermostat PICS in ci-pics-values with the feature map in all-clusters-app.zap HEAT | COOL | AUTO Updated the Test-TC-TSTAT_2_2.yaml to properly deal with AUTO MODE Validated all steps pass with HEAT, COOL, HEAT&COOL and those permutations along with OCC and AUTO. Addresses Test Plan issues 1379 and 1456 * Restyled by whitespace * Restyled by prettier-yaml * Update src/app/tests/suites/certification/ci-pics-values Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Removing unintended change to ZAP file * Address CI issues * Restyled by whitespace * Restyled by prettier-yaml * remove ci pics values added incorrectly * align ci-pics and pics.yaml * Add TSTAT.S Features Added Feature flags 3 and 4 * REGEN Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligned the thermostat PICS in ci-pics-values with the feature map in all-clusters-app.zap
HEAT | COOL | AUTO
Updated the Test-TC-TSTAT_2_2.yaml to properly deal with AUTO MODE
Validated all steps pass with HEAT, COOL, HEAT&COOL and those permutations along with OCC and AUTO.
resolves CHIP-Specifications/chip-test-plans/issues/1379
resolves CHIP-Specifications/chip-test-plans/issues/1456