Skip to content

Commit

Permalink
FIX TSTST-2.2 script (#20166)
Browse files Browse the repository at this point in the history
* FIX TSTST-2.2 script

Aligned the thermostat PICS in ci-pics-values with the feature map in all-clusters-app.zap
HEAT | COOL | AUTO
Updated the Test-TC-TSTAT_2_2.yaml to properly deal with AUTO MODE
Validated all steps pass with HEAT, COOL, HEAT&COOL and those permutations along with OCC and AUTO.

Addresses Test Plan issues 1379 and 1456

* Restyled by whitespace

* Restyled by prettier-yaml

* Update src/app/tests/suites/certification/ci-pics-values

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

* Removing unintended change to ZAP file

* Address CI issues

* Restyled by whitespace

* Restyled by prettier-yaml

* remove ci pics values added incorrectly

* align ci-pics and pics.yaml

* Add TSTAT.S Features

Added Feature flags 3 and 4

* REGEN

Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
  • Loading branch information
3 people authored and web-flow committed Jul 14, 2022
1 parent 89d2a6a commit 3202fef
Show file tree
Hide file tree
Showing 7 changed files with 2,176 additions and 1,584 deletions.
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -63,4 +63,5 @@ compile_commands.json
*~

# log files
*.log
*.log
examples/thermostat/ameba/build
34 changes: 12 additions & 22 deletions src/app/tests/suites/certification/PICS.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -602,11 +602,17 @@ PICS:
id: DGSW.S.C00

# Thermostat cluster
- label: "Does the device implement the OccupiedCoolingSetpoint attribute"
id: A_OCCUPIEDCOOLINGSETPOINT
- label: "Does the device implement the Heating feature"
id: TSTAT.S.F00

- label: "Does the device implement the OccupiedHeatingSetpoint attribute"
id: A_OCCUPIEDHEATINGSETPOINT
- label: "Does the device implement the Cooling feature"
id: TSTAT.S.F01

- label: "Does the device implement the Occupancy feature"
id: TSTAT.S.F02

- label: "Does the device implement the Auto feature"
id: TSTAT.S.F05

- label: "Does the device implement the MinHeatSetpointLimit attribute"
id: A_MINHEATSETPOINTLIMIT
Expand All @@ -620,24 +626,8 @@ PICS:
- label: "Does the device implement the MaxCoolSetpointLimit attribute"
id: A_MAXCOOLSETPOINTLIMIT

- label:
"Does the device implement the ControlSequenceOfOperation attribute"
id: A_CONTROLSEQUENCEOFOPERATION

- label:
"Does the device implement receiving the SetpointRaiseLower command?"
id: CR_SetpointRaiseLower

- label:
"Does the device implement the UnoccupiedCoolingSetpoint attribute?"
id: A_UNOCCUPIEDCOOLINGSETPOINT

- label:
"Does the device implement the UnoccupiedHeatingSetpoint attribute?"
id: A_UNOCCUPIEDHEATINGSETPOINT

- label: "Does the device implement the MinSetpointDeadBand attribute?"
id: A_MINSETPOINTDEADBAND
- label: "Does the device implement the Tolerance attribute?"
id: A_TEMPERATURE_TOLERANCE

- label: "Does the device implement the Tolerance attribute?"
id: A_TEMPERATURE_TOLERANCE
Expand Down
3 changes: 0 additions & 3 deletions src/app/tests/suites/certification/Test_TC_TSTAT_1_1.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,6 @@ tests:
type: uint16

- label: "Read the optional global attribute constraints: FeatureMap"
PICS:
( TSTAT_HEAT || TSTAT_COOL || TSTAT_OCC || TSTAT_SCH || TSTAT_SB ||
TSTAT_AUTO )
command: "readAttribute"
attribute: "FeatureMap"
response:
Expand Down
Loading

0 comments on commit 3202fef

Please sign in to comment.