-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move DeviceInfoProvider to common code and use it in linux and NRF. #18687
Move DeviceInfoProvider to common code and use it in linux and NRF. #18687
Conversation
…ll examples can use. Expect other applications to replace these and override
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @andy31415 for contribution.
I agree with Boris, that this should not be implemented in the platform layer.
Providing example implementation of DeviceInfoProvider for all platforms seems to be better solution (similarly what we do in attestation credentials SetDeviceAttestationCredentialsProvider(Examples::GetExampleDACProvider());
)
@LuDuda I just updated the PR and moved things to a common layer. NRF uses a custom cmake build which required a bit of updating. Please take a look. |
Updated code to centralize the provider implementation
PR #18687: Size comparison from 352333a to 09540af Increases (1 build for linux)
Decreases (2 builds for linux)
Full report (19 builds for cc13x2_26x2, cyw30739, k32w, linux, mbed, p6, telink)
|
PR #18687: Size comparison from 352333a to 9d880d3 Increases above 0.2%:
Increases (5 builds for linux, nrfconnect)
Decreases (2 builds for linux)
Full report (35 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Problem
#17596 reports that DeviceInfoProvider is not supported in nrfconnect (specifically supported locales list is empty).
This fixes #17596.
Change overview
Move DeviceInfoProvider implementation as an example provider and make use of it in linux and nrf.
Tried to preserve existing behavior and have linux (and darwin app main as a sideffect) support deviceinfo provider. Ameba uses a custom build script that is out of the tree, so I could not update that one).
Testing
Ran
and saw output that was non-empty: