-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TE9][TC-LC-2.3] UserLabel cannot write a list into the attribute label-list #18317
Comments
@jmeg-sfy What platform is the server in this case? user-label is implemented on some platforms but not others. |
Assigning to myself. I believe as part of changes to #18687 we are pulling in device labelling support as well. I will have to test this and eventually this has to be added to multiple platforms. |
Validated that his currently works in nrf-light using this script: #!/usr/bin/env bash
set -ex
function finish {
echo "STATUS: $?"
}
trap finish EXIT
export NODEID=$RANDOM
export THREAD_CRED=hex:0e..... # added my thread credentials here
export CHIP_TOOL="./out/linux-x64-chip-tool-ipv6only/chip-tool"
log_file="run_log_$(date +'%Y-%m-%d_%H-%M-%S').txt"
rm /tmp/chip_*
echo "NODE ID USED: $NODEID" | tee $log_file
echo "=============================================================" >>$log_file
echo $CHIP_TOOL pairing ble-thread $NODEID $THREAD_CRED 20202021 3840 | tee -a $log_file
$CHIP_TOOL pairing ble-thread $NODEID $THREAD_CRED 20202021 3840 >>$log_file 2>&1
echo "=============================================================" >>$log_file
echo $CHIP_TOOL userlabel write label-list '[{"label":"bedroom","value":"bedroom2"},{"label":"orientation","value":"east"},{"label":"floor","value":"3"},{"label":"direction","value":"down"}]' $NODEID 0 | tee -a $log_file
$CHIP_TOOL userlabel write label-list '[{"label":"bedroom","value":"bedroom2"},{"label":"orientation","value":"east"},{"label":"floor","value":"3"},{"label":"direction","value":"down"}]' $NODEID 0 2>&1 | tee -a $log_file | grep -i status
echo "=============================================================" >>$log_file
echo $CHIP_TOOL userlabel read label-list $NODEID 0 | tee -a $log_file
$CHIP_TOOL userlabel read label-list $NODEID 0 2>&1 | tee -a $log_file | grep -A 18 'label list' |
I can also confirm this fails for efr32-brd4161a-light which seems in line with my expectations: using the DeviceInfoProvider enables this, not having it makes it not pass. I will add this for EFR however for future items I will need platform owners to update their examples. |
Great i do have this implemented on my device right now i basically took the DeviceInfoProviderImpl.cpp from Linux and applied it to EFR |
It was on EFR32 in my case |
Did a copy of those from src/platform/Linux
|
I updated EFR32 light to use the newly moved examples/provides/DeviceInfoProviderImpl.h/cpp however this crashes for me :( Need to debug why. |
Found that storage has to be initialized (makse sense ... we store the labels). What is unclear is why this was working for me on nrf and linux which do not initialize storage. So I added the storage init to all examples now. |
Likely this is very similar/same as #17604 |
Problem
<what's wrong or missing, please include any applicable:
Proposed Solution
fix the XML and cluster UserLabel
The text was updated successfully, but these errors were encountered: