-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OTA] Set default configuration values for OTA Provider to prevent crash #15052
Merged
carol-apple
merged 1 commit into
project-chip:master
from
carol-apple:ota_provider_crash_readme_update
Feb 11, 2022
Merged
[OTA] Set default configuration values for OTA Provider to prevent crash #15052
carol-apple
merged 1 commit into
project-chip:master
from
carol-apple:ota_provider_crash_readme_update
Feb 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
lazarkov,
LuDuda,
mlepage-google,
msandstedt and
mspang
February 10, 2022 20:54
pullapprove
bot
requested review from
sagar-apple,
saurabhst,
selissia,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
February 10, 2022 20:54
carol-apple
force-pushed
the
ota_provider_crash_readme_update
branch
from
February 10, 2022 20:56
e8a3641
to
0f5bbb8
Compare
selissia
approved these changes
Feb 10, 2022
PR #15052: Size comparison from 31b5331 to 0f5bbb8 Full report (17 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
|
carol-apple
force-pushed
the
ota_provider_crash_readme_update
branch
from
February 10, 2022 21:53
0f5bbb8
to
cd135f2
Compare
carol-apple
force-pushed
the
ota_provider_crash_readme_update
branch
from
February 10, 2022 21:54
cd135f2
to
c157447
Compare
harsha-rajendran
approved these changes
Feb 10, 2022
PR #15052: Size comparison from 31b5331 to c157447 Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
carol-apple
force-pushed
the
ota_provider_crash_readme_update
branch
from
February 10, 2022 23:16
c157447
to
abd4d45
Compare
- Update README on application usage
carol-apple
force-pushed
the
ota_provider_crash_readme_update
branch
from
February 10, 2022 23:18
abd4d45
to
5ea49bc
Compare
PR #15052: Size comparison from 4126b1c to 5ea49bc Increases above 0.2%:
Increases (1 build for linux)
Decreases (1 build for linux)
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
jamesluo11
pushed a commit
to jamesluo11/connectedhomeip
that referenced
this pull request
Apr 26, 2022
…ash (project-chip#15052) - Update README on application usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The OTAProviderExample class defaults some values to
nullptr
. Some paths (depending on various command line options used) do not update these values, resulting in application crash.Also, with #14931, the application now initializes application-specific items in
ApplicationInit
(which used to reside inmain
). Any local variables defined/used inApplicationInit
now needs to be global so the value remains valid after the function returnsFixes: #15048
Change overview
DefaultUserConsentProvider
a global variableTesting