Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OTA] Initalize OTA apps using Linux platform functions #14931

Merged
merged 2 commits into from
Feb 9, 2022
Merged

[OTA] Initalize OTA apps using Linux platform functions #14931

merged 2 commits into from
Feb 9, 2022

Conversation

carol-apple
Copy link
Contributor

Problem

OTA apps can no longer be commissioned after #14832 merged. The PR removed KVS init code from Server which OTA apps relied on.

Change overview

  • Use the init functions for Linux from AppMain
  • Add in an optional param to allow for app-specific custom command line options

Testing

Tested that OTA apps can be commissioned again. Also tested that the usual AnnounceOTAProvider command triggers the entire OTA process.

@github-actions
Copy link

github-actions bot commented Feb 9, 2022 •
edited
Loading

PR #14931: Size comparison from 5158095 to 8f19b27

Increases (1 build for linux)
platform target config section 5158095 8f19b27 change % change
linux thermostat-no-ble arm64 (read only) 2130892 2130956 64 0.0
.text 1780720 1780800 80 0.0
Decreases (1 build for linux)
platform target config section 5158095 8f19b27 change % change
linux thermostat-no-ble arm64 .rodata 132108 132092 -16 -0.0
Full report (24 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section 5158095 8f19b27 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 595374 595374 0 0.0
.app_xip_area 500908 500908 0 0.0
.bss 77188 77188 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 556326 556326 0 0.0
.app_xip_area 463396 463396 0 0.0
.bss 75684 75684 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 577314 577314 0 0.0
.app_xip_area 475088 475088 0 0.0
.bss 84652 84652 0 0.0
.data 532 532 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 866532 866532 0 0.0
(read/write) 126684 126684 0 0.0
.bss 124760 124760 0 0.0
.data 1924 1924 0 0.0
.text 866524 866524 0 0.0
BRD4161A+rpc (read only) 853996 853996 0 0.0
(read/write) 143344 143344 0 0.0
.bss 141320 141320 0 0.0
.data 2024 2024 0 0.0
.text 853988 853988 0 0.0
window-app BRD4161A (read only) 838752 838752 0 0.0
(read/write) 125328 125328 0 0.0
.bss 123448 123448 0 0.0
.data 1880 1880 0 0.0
.text 838744 838744 0 0.0
esp32 all-clusters-app c3devkit (read only) 938890 938890 0 0.0
(read/write) 1400826 1400826 0 0.0
.dram0.bss 69496 69496 0 0.0
.dram0.data 14260 14260 0 0.0
.flash.rodata 198160 198160 0 0.0
.flash.text 938890 938890 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 987147 987147 0 0.0
(read/write) 465848 465848 0 0.0
.dram0.bss 74640 74640 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 225056 225056 0 0.0
.flash.text 981763 981763 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 679196 679196 0 0.0
.bss 76632 76632 0 0.0
.data 1884 1884 0 0.0
.text 594880 594880 0 0.0
lock k32w061+release (read/write) 683996 683996 0 0.0
.bss 76984 76984 0 0.0
.data 1928 1928 0 0.0
.text 599284 599284 0 0.0
linux chip-tool-ipv6only arm64 (read only) 7390172 7390172 0 0.0
(read/write) 301313 301313 0 0.0
.bss 50641 50641 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 199304 199304 0 0.0
.dynamic 560 560 0 0.0
.got 46400 46400 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 397252 397252 0 0.0
.text 6355636 6355636 0 0.0
thermostat-no-ble arm64 (read only) 2130892 2130956 64 0.0
(read/write) 140673 140673 0 0.0
.bss 57665 57665 0 0.0
.data 984 984 0 0.0
.data.rel.ro 74904 74904 0 0.0
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 132108 132092 -16 -0.0
.text 1780720 1780800 80 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2389944 2389944 0 0.0
.bss 188404 188404 0 0.0
.data 5280 5280 0 0.0
.text 1352544 1352544 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2349448 2349448 0 0.0
.bss 181000 181000 0 0.0
.data 5600 5600 0 0.0
.text 1312048 1312048 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2317408 2317408 0 0.0
.bss 180912 180912 0 0.0
.data 5584 5584 0 0.0
.text 1280008 1280008 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139648 1139648 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103032 103032 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303404 2303404 0 0.0
.bss 178164 178164 0 0.0
.data 5400 5400 0 0.0
.text 1265976 1265976 0 0.0
p6 all-clusters-app default (read/write) 2464320 2464320 0 0.0
.bss 118024 118024 0 0.0
.data 2568 2568 0 0.0
.text 1422584 1422584 0 0.0
light-app default (read/write) 2367968 2367968 0 0.0
.bss 107664 107664 0 0.0
.data 2432 2432 0 0.0
.text 1326232 1326232 0 0.0
lock-app default (read/write) 2336776 2336776 0 0.0
.bss 107400 107400 0 0.0
.data 2400 2400 0 0.0
.text 1295040 1295040 0 0.0
qpg lighting-app qpg6105+debug (read only) 586352 586352 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88920 88920 0 0.0
.data 1084 1084 0 0.0
.text 581032 581032 0 0.0
lock-app qpg6105+debug (read only) 535316 535316 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88392 88392 0 0.0
.data 1028 1028 0 0.0
.text 529996 529996 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 866702 866702 0 0.0
bss 88664 88664 0 0.0
noinit 37160 37160 0 0.0
text 608294 608294 0 0.0

@carol-apple carol-apple force-pushed the ota_apps_use_appmain branch 2 times, most recently from 9e1ff4e to ba8d893 Compare February 9, 2022 06:32
@github-actions
Copy link

github-actions bot commented Feb 9, 2022 •
edited
Loading

PR #14931: Size comparison from 5158095 to ba8d893

Increases above 0.2%:

platform target config section 5158095 ba8d893 change % change
linux ota-provider-app debug (read only) 1714425 1850145 135720 7.9
(read/write) 81368 106456 25088 30.8
.bss 41120 42112 992 2.4
.data.rel.ro 33560 57544 23984 71.5
.got 4240 4368 128 3.0
.rodata 151910 157342 5432 3.6
.text 1443810 1542210 98400 6.8
ota-requestor-app debug (read only) 1703081 1838889 135808 8.0
(read/write) 83320 107608 24288 29.2
.bss 42272 42432 160 0.4
.data.rel.ro 34616 58600 23984 69.3
.got 4040 4176 136 3.4
.rodata 145047 150287 5240 3.6
.text 1441138 1539730 98592 6.8
Increases (7 builds for linux)
platform target config section 5158095 ba8d893 change % change
linux all-clusters-app debug (read only) 2329193 2329289 96 0.0
.text 1962514 1962610 96 0.0
door-lock-app debug (read only) 1910457 1910553 96 0.0
.text 1590082 1590178 96 0.0
lighting-app debug+rpc (read only) 2005001 2005113 112 0.0
.text 1687298 1687410 112 0.0
ota-provider-app debug (read only) 1714425 1850145 135720 7.9
(read/write) 81368 106456 25088 30.8
.bss 41120 42112 992 2.4
.data.rel.ro 33560 57544 23984 71.5
.got 4240 4368 128 3.0
.rodata 151910 157342 5432 3.6
.text 1443810 1542210 98400 6.8
ota-requestor-app debug (read only) 1703081 1838889 135808 8.0
(read/write) 83320 107608 24288 29.2
.bss 42272 42432 160 0.4
.data.rel.ro 34616 58600 23984 69.3
.got 4040 4176 136 3.4
.rodata 145047 150287 5240 3.6
.text 1441138 1539730 98592 6.8
thermostat-no-ble arm64 (read only) 2130892 2130956 64 0.0
.text 1780720 1780800 80 0.0
tv-app debug (read only) 2503017 2503129 112 0.0
.text 2133938 2134050 112 0.0
Decreases (1 build for linux)
platform target config section 5158095 ba8d893 change % change
linux thermostat-no-ble arm64 .rodata 132108 132092 -16 -0.0
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 5158095 ba8d893 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 595374 595374 0 0.0
.app_xip_area 500908 500908 0 0.0
.bss 77188 77188 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 556326 556326 0 0.0
.app_xip_area 463396 463396 0 0.0
.bss 75684 75684 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 577314 577314 0 0.0
.app_xip_area 475088 475088 0 0.0
.bss 84652 84652 0 0.0
.data 532 532 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 866532 866532 0 0.0
(read/write) 126684 126684 0 0.0
.bss 124760 124760 0 0.0
.data 1924 1924 0 0.0
.text 866524 866524 0 0.0
BRD4161A+rpc (read only) 853996 853996 0 0.0
(read/write) 143344 143344 0 0.0
.bss 141320 141320 0 0.0
.data 2024 2024 0 0.0
.text 853988 853988 0 0.0
window-app BRD4161A (read only) 838752 838752 0 0.0
(read/write) 125328 125328 0 0.0
.bss 123448 123448 0 0.0
.data 1880 1880 0 0.0
.text 838744 838744 0 0.0
esp32 all-clusters-app c3devkit (read only) 938890 938890 0 0.0
(read/write) 1400826 1400826 0 0.0
.dram0.bss 69496 69496 0 0.0
.dram0.data 14260 14260 0 0.0
.flash.rodata 198160 198160 0 0.0
.flash.text 938890 938890 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 987147 987147 0 0.0
(read/write) 465848 465848 0 0.0
.dram0.bss 74640 74640 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 225056 225056 0 0.0
.flash.text 981763 981763 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 679196 679196 0 0.0
.bss 76632 76632 0 0.0
.data 1884 1884 0 0.0
.text 594880 594880 0 0.0
lock k32w061+release (read/write) 683996 683996 0 0.0
.bss 76984 76984 0 0.0
.data 1928 1928 0 0.0
.text 599284 599284 0 0.0
linux all-clusters-app debug (read only) 2329193 2329289 96 0.0
(read/write) 140032 140032 0 0.0
.bss 54656 54656 0 0.0
.data 1168 1168 0 0.0
.data.rel.ro 78536 78536 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 204453 204453 0 0.0
.text 1962514 1962610 96 0.0
bridge-app debug+rpc (read only) 1705749 1705749 0 0.0
(read/write) 84328 84328 0 0.0
.bss 39088 39088 0 0.0
.data 1970 1970 0 0.0
.data.rel.ro 38120 38120 0 0.0
.dynamic 592 592 0 0.0
.got 3976 3976 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 140332 140332 0 0.0
.text 1448869 1448869 0 0.0
chip-tool debug (read only) 7466189 7466189 0 0.0
(read/write) 197176 197176 0 0.0
.bss 32360 32360 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 157624 157624 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 414773 414773 0 0.0
.text 6650981 6650981 0 0.0
chip-tool-ipv6only arm64 (read only) 7390172 7390172 0 0.0
(read/write) 301313 301313 0 0.0
.bss 50641 50641 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 199304 199304 0 0.0
.dynamic 560 560 0 0.0
.got 46400 46400 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 397252 397252 0 0.0
.text 6355636 6355636 0 0.0
door-lock-app debug (read only) 1910457 1910553 96 0.0
(read/write) 110680 110680 0 0.0
.bss 42160 42160 0 0.0
.data 946 946 0 0.0
.data.rel.ro 62160 62160 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 171858 171858 0 0.0
.text 1590082 1590178 96 0.0
lighting-app debug+rpc (read only) 2005001 2005113 112 0.0
(read/write) 115632 115632 0 0.0
.bss 43104 43104 0 0.0
.data 1368 1368 0 0.0
.data.rel.ro 65672 65672 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 163057 163057 0 0.0
.text 1687298 1687410 112 0.0
ota-provider-app debug (read only) 1714425 1850145 135720 7.9
(read/write) 81368 106456 25088 30.8
.bss 41120 42112 992 2.4
.data 1160 1160 0 0.0
.data.rel.ro 33560 57544 23984 71.5
.dynamic 608 608 0 0.0
.got 4240 4368 128 3.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 151910 157342 5432 3.6
.text 1443810 1542210 98400 6.8
ota-requestor-app debug (read only) 1703081 1838889 135808 8.0
(read/write) 83320 107608 24288 29.2
.bss 42272 42432 160 0.4
.data 1128 1128 0 0.0
.data.rel.ro 34616 58600 23984 69.3
.dynamic 592 592 0 0.0
.got 4040 4176 136 3.4
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 145047 150287 5240 3.6
.text 1441138 1539730 98592 6.8
shell debug (read only) 2302633 2302633 0 0.0
(read/write) 141584 141584 0 0.0
.bss 62048 62048 0 0.0
.data 768 768 0 0.0
.data.rel.ro 73072 73072 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 205170 205170 0 0.0
.text 1941042 1941042 0 0.0
thermostat-no-ble arm64 (read only) 2130892 2130956 64 0.0
(read/write) 140673 140673 0 0.0
.bss 57665 57665 0 0.0
.data 984 984 0 0.0
.data.rel.ro 74904 74904 0 0.0
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 132108 132092 -16 -0.0
.text 1780720 1780800 80 0.0
tv-app debug (read only) 2503017 2503129 112 0.0
(read/write) 139512 139512 0 0.0
.bss 57280 57280 0 0.0
.data 3168 3168 0 0.0
.data.rel.ro 73048 73048 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 196140 196140 0 0.0
.text 2133938 2134050 112 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2389944 2389944 0 0.0
.bss 188404 188404 0 0.0
.data 5280 5280 0 0.0
.text 1352544 1352544 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2349448 2349448 0 0.0
.bss 181000 181000 0 0.0
.data 5600 5600 0 0.0
.text 1312048 1312048 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2317408 2317408 0 0.0
.bss 180912 180912 0 0.0
.data 5584 5584 0 0.0
.text 1280008 1280008 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139648 1139648 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103032 103032 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303404 2303404 0 0.0
.bss 178164 178164 0 0.0
.data 5400 5400 0 0.0
.text 1265976 1265976 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1005691 1005691 0 0.0
bss 121352 121352 0 0.0
rodata 118312 118312 0 0.0
text 687036 687036 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 974535 974535 0 0.0
bss 118540 118540 0 0.0
rodata 109700 109700 0 0.0
text 666652 666652 0 0.0
nrf52840dongle_nrf52840 (read/write) 1022383 1022383 0 0.0
bss 122716 122716 0 0.0
rodata 117200 117200 0 0.0
text 692608 692608 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 912306 912306 0 0.0
bss 117912 117912 0 0.0
rodata 111572 111572 0 0.0
text 602064 602064 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 940775 940775 0 0.0
bss 119720 119720 0 0.0
rodata 107540 107540 0 0.0
text 634944 634944 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 848234 848234 0 0.0
bss 116312 116312 0 0.0
rodata 100708 100708 0 0.0
text 550744 550744 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 940195 940195 0 0.0
bss 119440 119440 0 0.0
rodata 106896 106896 0 0.0
text 635200 635200 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 935535 935535 0 0.0
bss 119444 119444 0 0.0
rodata 106188 106188 0 0.0
text 631236 631236 0 0.0
shell nrf52840dk_nrf52840 (read/write) 803911 803911 0 0.0
bss 111304 111304 0 0.0
rodata 78716 78716 0 0.0
text 536272 536272 0 0.0
p6 all-clusters-app default (read/write) 2464320 2464320 0 0.0
.bss 118024 118024 0 0.0
.data 2568 2568 0 0.0
.text 1422584 1422584 0 0.0
light-app default (read/write) 2367968 2367968 0 0.0
.bss 107664 107664 0 0.0
.data 2432 2432 0 0.0
.text 1326232 1326232 0 0.0
lock-app default (read/write) 2336776 2336776 0 0.0
.bss 107400 107400 0 0.0
.data 2400 2400 0 0.0
.text 1295040 1295040 0 0.0
qpg lighting-app qpg6105+debug (read only) 586352 586352 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88920 88920 0 0.0
.data 1084 1084 0 0.0
.text 581032 581032 0 0.0
lock-app qpg6105+debug (read only) 535316 535316 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88392 88392 0 0.0
.data 1028 1028 0 0.0
.text 529996 529996 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 866702 866702 0 0.0
bss 88664 88664 0 0.0
noinit 37160 37160 0 0.0
text 608294 608294 0 0.0

@carol-apple
[OTA] Initalize OTA apps using Linux platform functions
3a91424 
- Add in an optional param to allow for app-specific custom command line options
@github-actions
Copy link

github-actions bot commented Feb 9, 2022 •
edited
Loading

PR #14931: Size comparison from f4901af to 0eb649d

Increases (1 build for linux)
platform target config section f4901af 0eb649d change % change
linux thermostat-no-ble arm64 (read only) 2131068 2131116 48 0.0
.text 1780896 1780960 64 0.0
Decreases (1 build for linux)
platform target config section f4901af 0eb649d change % change
linux thermostat-no-ble arm64 .rodata 132108 132092 -16 -0.0
Full report (19 builds for cyw30739, efr32, esp32, k32w, linux, p6, qpg, telink)
platform target config section f4901af 0eb649d change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599634 599634 0 0.0
.app_xip_area 505144 505144 0 0.0
.bss 77212 77212 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 556334 556334 0 0.0
.app_xip_area 463404 463404 0 0.0
.bss 75684 75684 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 577234 577234 0 0.0
.app_xip_area 475056 475056 0 0.0
.bss 84604 84604 0 0.0
.data 532 532 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 903664 903664 0 0.0
(read/write) 127296 127296 0 0.0
.bss 125280 125280 0 0.0
.data 2012 2012 0 0.0
.text 903656 903656 0 0.0
BRD4161A+rpc (read only) 891108 891108 0 0.0
(read/write) 143952 143952 0 0.0
.bss 141840 141840 0 0.0
.data 2112 2112 0 0.0
.text 891100 891100 0 0.0
window-app BRD4161A (read only) 839048 839048 0 0.0
(read/write) 125360 125360 0 0.0
.bss 123480 123480 0 0.0
.data 1880 1880 0 0.0
.text 839040 839040 0 0.0
esp32 all-clusters-app c3devkit (read only) 940834 940834 0 0.0
(read/write) 1397866 1397866 0 0.0
.dram0.bss 66344 66344 0 0.0
.dram0.data 14260 14260 0 0.0
.flash.rodata 198352 198352 0 0.0
.flash.text 940834 940834 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 988767 988767 0 0.0
(read/write) 462880 462880 0 0.0
.dram0.bss 71488 71488 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 225240 225240 0 0.0
.flash.text 983383 983383 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 679132 679132 0 0.0
.bss 76584 76584 0 0.0
.data 1884 1884 0 0.0
.text 594864 594864 0 0.0
lock k32w061+release (read/write) 684012 684012 0 0.0
.bss 76984 76984 0 0.0
.data 1928 1928 0 0.0
.text 599300 599300 0 0.0
linux chip-tool-ipv6only arm64 (read only) 7433596 7433596 0 0.0
(read/write) 301953 301953 0 0.0
.bss 50641 50641 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 199304 199304 0 0.0
.dynamic 560 560 0 0.0
.got 47040 47040 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 401300 401300 0 0.0
.text 6393092 6393092 0 0.0
thermostat-no-ble arm64 (read only) 2131068 2131116 48 0.0
(read/write) 140673 140673 0 0.0
.bss 57665 57665 0 0.0
.data 984 984 0 0.0
.data.rel.ro 74904 74904 0 0.0
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 132108 132092 -16 -0.0
.text 1780896 1780960 64 0.0
p6 all-clusters-app default (read/write) 2478576 2478576 0 0.0
.bss 117672 117672 0 0.0
.data 2632 2632 0 0.0
.text 1436840 1436840 0 0.0
light-app default (read/write) 2385536 2385536 0 0.0
.bss 107320 107320 0 0.0
.data 2504 2504 0 0.0
.text 1343800 1343800 0 0.0
lock-app default (read/write) 2349136 2349136 0 0.0
.bss 107040 107040 0 0.0
.data 2464 2464 0 0.0
.text 1307400 1307400 0 0.0
qpg lighting-app qpg6105+debug (read only) 590172 590172 0 0.0
(read/write) 146940 146940 0 0.0
.bss 88896 88896 0 0.0
.data 1088 1088 0 0.0
.text 584852 584852 0 0.0
lock-app qpg6105+debug (read only) 556064 556064 0 0.0
(read/write) 146940 146940 0 0.0
.bss 88880 88880 0 0.0
.data 1040 1040 0 0.0
.text 550744 550744 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 869602 869602 0 0.0
bss 88672 88672 0 0.0
noinit 37160 37160 0 0.0
text 610720 610720 0 0.0

@carol-apple
Move KVS init to before InitChipStack
de26bab 
- Do not go past the sLinuxDeviceOptionSets array
- Make sure no use of the configuration manager happens before the ConfigurationManager has been configured
@github-actions
Copy link

github-actions bot commented Feb 9, 2022 •
edited
Loading

PR #14931: Size comparison from 1744422 to de26bab

Increases above 0.2%:

platform target config section 1744422f de26bab change % change
linux all-clusters-app debug .data 1168 1200 32 2.7
lighting-app debug+rpc .data 1368 1400 32 2.3
ota-provider-app debug (read only) 1714249 1850017 135768 7.9
(read/write) 81240 106328 25088 30.9
.bss 40992 41984 992 2.4
.data.rel.ro 33560 57544 23984 71.5
.got 4240 4368 128 3.0
.rodata 151910 157342 5432 3.6
.text 1443634 1542082 98448 6.8
ota-requestor-app debug (read only) 1708873 1844745 135872 8.0
(read/write) 83160 107448 24288 29.2
.bss 42112 42272 160 0.4
.data.rel.ro 34616 58600 23984 69.3
.got 4040 4176 136 3.4
.rodata 145495 150735 5240 3.6
.text 1446482 1545138 98656 6.8
thermostat-no-ble arm64 .data 984 992 8 0.8
Increases (7 builds for linux)
platform target config section 1744422f de26bab change % change
linux all-clusters-app debug (read only) 2334665 2334825 160 0.0
(read/write) 139968 140000 32 0.0
.data 1168 1200 32 2.7
.text 1967778 1967938 160 0.0
door-lock-app debug (read only) 1910265 1910425 160 0.0
.text 1589890 1590050 160 0.0
lighting-app debug+rpc (read only) 2032537 2032665 128 0.0
(read/write) 115800 115832 32 0.0
.data 1368 1400 32 2.3
.text 1713490 1713650 160 0.0
ota-provider-app debug (read only) 1714249 1850017 135768 7.9
(read/write) 81240 106328 25088 30.9
.bss 40992 41984 992 2.4
.data.rel.ro 33560 57544 23984 71.5
.got 4240 4368 128 3.0
.rodata 151910 157342 5432 3.6
.text 1443634 1542082 98448 6.8
ota-requestor-app debug (read only) 1708873 1844745 135872 8.0
(read/write) 83160 107448 24288 29.2
.bss 42112 42272 160 0.4
.data.rel.ro 34616 58600 23984 69.3
.got 4040 4176 136 3.4
.rodata 145495 150735 5240 3.6
.text 1446482 1545138 98656 6.8
thermostat-no-ble arm64 (read only) 2130812 2130972 160 0.0
.data 984 992 8 0.8
.text 1780640 1780816 176 0.0
tv-app debug (read only) 2502905 2503065 160 0.0
.text 2133826 2133986 160 0.0
Decreases (2 builds for linux)
platform target config section 1744422f de26bab change % change
linux lighting-app debug+rpc .rodata 164209 164177 -32 -0.0
thermostat-no-ble arm64 .rodata 132108 132092 -16 -0.0
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 1744422f de26bab change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599434 599434 0 0.0
.app_xip_area 505040 505040 0 0.0
.bss 77116 77116 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 556126 556126 0 0.0
.app_xip_area 463292 463292 0 0.0
.bss 75588 75588 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 577026 577026 0 0.0
.app_xip_area 474944 474944 0 0.0
.bss 84508 84508 0 0.0
.data 532 532 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 903440 903440 0 0.0
(read/write) 127200 127200 0 0.0
.bss 125184 125184 0 0.0
.data 2012 2012 0 0.0
.text 903432 903432 0 0.0
BRD4161A+rpc (read only) 890900 890900 0 0.0
(read/write) 143856 143856 0 0.0
.bss 141744 141744 0 0.0
.data 2112 2112 0 0.0
.text 890892 890892 0 0.0
window-app BRD4161A (read only) 838840 838840 0 0.0
(read/write) 125264 125264 0 0.0
.bss 123384 123384 0 0.0
.data 1880 1880 0 0.0
.text 838832 838832 0 0.0
esp32 all-clusters-app c3devkit (read only) 940682 940682 0 0.0
(read/write) 1397770 1397770 0 0.0
.dram0.bss 66248 66248 0 0.0
.dram0.data 14260 14260 0 0.0
.flash.rodata 198352 198352 0 0.0
.flash.text 940682 940682 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 988695 988695 0 0.0
(read/write) 462784 462784 0 0.0
.dram0.bss 71392 71392 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 225240 225240 0 0.0
.flash.text 983311 983311 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 678908 678908 0 0.0
.bss 76488 76488 0 0.0
.data 1884 1884 0 0.0
.text 594736 594736 0 0.0
lock k32w061+release (read/write) 683788 683788 0 0.0
.bss 76888 76888 0 0.0
.data 1928 1928 0 0.0
.text 599172 599172 0 0.0
linux all-clusters-app debug (read only) 2334665 2334825 160 0.0
(read/write) 139968 140000 32 0.0
.bss 54560 54560 0 0.0
.data 1168 1200 32 2.7
.data.rel.ro 78552 78552 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 204613 204613 0 0.0
.text 1967778 1967938 160 0.0
bridge-app debug+rpc (read only) 1705557 1705557 0 0.0
(read/write) 84200 84200 0 0.0
.bss 38960 38960 0 0.0
.data 1970 1970 0 0.0
.data.rel.ro 38120 38120 0 0.0
.dynamic 592 592 0 0.0
.got 3976 3976 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 140332 140332 0 0.0
.text 1448677 1448677 0 0.0
chip-tool debug (read only) 7514509 7514509 0 0.0
(read/write) 197048 197048 0 0.0
.bss 32232 32232 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 157624 157624 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 418901 418901 0 0.0
.text 6695173 6695173 0 0.0
chip-tool-ipv6only arm64 (read only) 7433340 7433340 0 0.0
(read/write) 301825 301825 0 0.0
.bss 50513 50513 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 199304 199304 0 0.0
.dynamic 560 560 0 0.0
.got 47040 47040 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 401300 401300 0 0.0
.text 6392836 6392836 0 0.0
door-lock-app debug (read only) 1910265 1910425 160 0.0
(read/write) 110552 110552 0 0.0
.bss 42032 42032 0 0.0
.data 946 946 0 0.0
.data.rel.ro 62160 62160 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 171858 171858 0 0.0
.text 1589890 1590050 160 0.0
lighting-app debug+rpc (read only) 2032537 2032665 128 0.0
(read/write) 115800 115832 32 0.0
.bss 43008 43008 0 0.0
.data 1368 1400 32 2.3
.data.rel.ro 65928 65928 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 164209 164177 -32 -0.0
.text 1713490 1713650 160 0.0
ota-provider-app debug (read only) 1714249 1850017 135768 7.9
(read/write) 81240 106328 25088 30.9
.bss 40992 41984 992 2.4
.data 1160 1160 0 0.0
.data.rel.ro 33560 57544 23984 71.5
.dynamic 608 608 0 0.0
.got 4240 4368 128 3.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 151910 157342 5432 3.6
.text 1443634 1542082 98448 6.8
ota-requestor-app debug (read only) 1708873 1844745 135872 8.0
(read/write) 83160 107448 24288 29.2
.bss 42112 42272 160 0.4
.data 1128 1128 0 0.0
.data.rel.ro 34616 58600 23984 69.3
.dynamic 592 592 0 0.0
.got 4040 4176 136 3.4
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 145495 150735 5240 3.6
.text 1446482 1545138 98656 6.8
shell debug (read only) 2308121 2308121 0 0.0
(read/write) 141392 141392 0 0.0
.bss 61824 61824 0 0.0
.data 768 768 0 0.0
.data.rel.ro 73104 73104 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 205330 205330 0 0.0
.text 1946322 1946322 0 0.0
thermostat-no-ble arm64 (read only) 2130812 2130972 160 0.0
(read/write) 140545 140545 0 0.0
.bss 57537 57537 0 0.0
.data 984 992 8 0.8
.data.rel.ro 74904 74904 0 0.0
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 132108 132092 -16 -0.0
.text 1780640 1780816 176 0.0
tv-app debug (read only) 2502905 2503065 160 0.0
(read/write) 139384 139384 0 0.0
.bss 57152 57152 0 0.0
.data 3168 3168 0 0.0
.data.rel.ro 73048 73048 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 196140 196140 0 0.0
.text 2133826 2133986 160 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2391408 2391408 0 0.0
.bss 188316 188316 0 0.0
.data 5280 5280 0 0.0
.text 1354008 1354008 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2353560 2353560 0 0.0
.bss 180928 180928 0 0.0
.data 5608 5608 0 0.0
.text 1316160 1316160 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2317280 2317280 0 0.0
.bss 180816 180816 0 0.0
.data 5584 5584 0 0.0
.text 1279880 1279880 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139648 1139648 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103032 103032 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303212 2303212 0 0.0
.bss 178068 178068 0 0.0
.data 5400 5400 0 0.0
.text 1265784 1265784 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1010599 1010599 0 0.0
bss 121244 121244 0 0.0
rodata 118772 118772 0 0.0
text 691600 691600 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 979443 979443 0 0.0
bss 118432 118432 0 0.0
rodata 110160 110160 0 0.0
text 671212 671212 0 0.0
nrf52840dongle_nrf52840 (read/write) 1026507 1026507 0 0.0
bss 122640 122640 0 0.0
rodata 117660 117660 0 0.0
text 696268 696268 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 917226 917226 0 0.0
bss 117808 117808 0 0.0
rodata 112028 112028 0 0.0
text 606624 606624 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 940535 940535 0 0.0
bss 119624 119624 0 0.0
rodata 107540 107540 0 0.0
text 634832 634832 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 848026 848026 0 0.0
bss 116216 116216 0 0.0
rodata 100708 100708 0 0.0
text 550632 550632 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 939955 939955 0 0.0
bss 119344 119344 0 0.0
rodata 106896 106896 0 0.0
text 635092 635092 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 935295 935295 0 0.0
bss 119348 119348 0 0.0
rodata 106188 106188 0 0.0
text 631124 631124 0 0.0
shell nrf52840dk_nrf52840 (read/write) 803783 803783 0 0.0
bss 111208 111208 0 0.0
rodata 78716 78716 0 0.0
text 536264 536264 0 0.0
p6 all-clusters-app default (read/write) 2478352 2478352 0 0.0
.bss 117576 117576 0 0.0
.data 2632 2632 0 0.0
.text 1436616 1436616 0 0.0
light-app default (read/write) 2385312 2385312 0 0.0
.bss 107224 107224 0 0.0
.data 2504 2504 0 0.0
.text 1343576 1343576 0 0.0
lock-app default (read/write) 2348912 2348912 0 0.0
.bss 106944 106944 0 0.0
.data 2464 2464 0 0.0
.text 1307176 1307176 0 0.0
qpg lighting-app qpg6105+debug (read only) 590052 590052 0 0.0
(read/write) 146940 146940 0 0.0
.bss 88800 88800 0 0.0
.data 1088 1088 0 0.0
.text 584732 584732 0 0.0
lock-app qpg6105+debug (read only) 555944 555944 0 0.0
(read/write) 146940 146940 0 0.0
.bss 88784 88784 0 0.0
.data 1040 1040 0 0.0
.text 550624 550624 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 869354 869354 0 0.0
bss 88576 88576 0 0.0
noinit 37160 37160 0 0.0
text 610562 610562 0 0.0

@carol-apple carol-apple merged commit d42c084 into project-chip:master Feb 9, 2022
This was referenced Feb 10, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@harsha-rajendran harsha-rajendran harsha-rajendran approved these changes

@woody-apple woody-apple woody-apple approved these changes

@selissia selissia selissia approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@carol-apple @tcarmelveilleux @harsha-rajendran @woody-apple @selissia @bzbarsky-apple @vivien-apple