Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make "reportable" setting consistent in zap file to avoid zap instability. #13632

Merged
merged 4 commits into from
Jan 17, 2022
Merged

Make "reportable" setting consistent in zap file to avoid zap instability. #13632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bdfa1e3
Make tv casting labelList and clusterRevision consistently non-report…
andy31415 Jan 17, 2022
a66de6c
More changes regarding reportable consistency on all clusters app.zap
andy31415 Jan 17, 2022
479ff80
Two more stability updates for reportability
andy31415 Jan 17, 2022
6cbc889
After update, feature map is NOT reportable (which seems correct: it …
andy31415 Jan 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/all-clusters-app/all-clusters-common/all-clusters-app.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1808,7 +1808,7 @@ server cluster NetworkCommissioning = 49 {
attribute(readonly) NetworkCommissioningStatus lastNetworkingStatus = 5;
attribute(readonly) octet_string lastNetworkID = 6;
attribute(readonly) int32u lastConnectErrorValue = 7;
attribute(readonly, reportable) bitmap32 featureMap = 65532;
attribute(readonly) bitmap32 featureMap = 65532;
attribute(readonly, reportable) int16u clusterRevision = 65533;

request struct AddOrUpdateThreadNetworkRequest {
Expand Down
14 changes: 7 additions & 7 deletions examples/all-clusters-app/all-clusters-common/all-clusters-app.zap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1973,7 +1973,7 @@
"singleton": 0,
"bounded": 0,
"defaultValue": "0x0001",
"reportable": 1,
"reportable": 0,
"minInterval": 0,
"maxInterval": 65344,
"reportableChange": 0
Expand Down Expand Up @@ -2159,7 +2159,7 @@
"singleton": 0,
"bounded": 0,
"defaultValue": "1",
"reportable": 1,
"reportable": 0,
"minInterval": 0,
"maxInterval": 65344,
"reportableChange": 0
Expand Down Expand Up @@ -9948,7 +9948,7 @@
"singleton": 0,
"bounded": 0,
"defaultValue": "0x0001",
"reportable": 1,
"reportable": 0,
"minInterval": 0,
"maxInterval": 65344,
"reportableChange": 0
Expand All @@ -9974,7 +9974,7 @@
"singleton": 0,
"bounded": 0,
"defaultValue": "",
"reportable": 1,
"reportable": 0,
"minInterval": 0,
"maxInterval": 65344,
"reportableChange": 0
Expand All @@ -9989,7 +9989,7 @@
"singleton": 0,
"bounded": 0,
"defaultValue": "0x0001",
"reportable": 1,
"reportable": 0,
"minInterval": 0,
"maxInterval": 65344,
"reportableChange": 0
Expand Down Expand Up @@ -13654,7 +13654,7 @@
"singleton": 0,
"bounded": 0,
"defaultValue": "0x0001",
"reportable": 1,
"reportable": 0,
"minInterval": 0,
"maxInterval": 65344,
"reportableChange": 0
Expand Down Expand Up @@ -20139,4 +20139,4 @@
"deviceIdentifier": 22
}
]
}
}
6 changes: 3 additions & 3 deletions examples/tv-casting-app/tv-casting-common/tv-casting-app.zap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3448,7 +3448,7 @@
"singleton": 0,
"bounded": 0,
"defaultValue": "0x0001",
"reportable": 1,
"reportable": 0,
"minInterval": 0,
"maxInterval": 65344,
"reportableChange": 0
Expand Down Expand Up @@ -8886,7 +8886,7 @@
"singleton": 0,
"bounded": 0,
"defaultValue": "0x0001",
"reportable": 1,
"reportable": 0,
"minInterval": 0,
"maxInterval": 65344,
"reportableChange": 0
Expand All @@ -8912,7 +8912,7 @@
"singleton": 0,
"bounded": 0,
"defaultValue": "",
"reportable": 1,
"reportable": 0,
"minInterval": 0,
"maxInterval": 65344,
"reportableChange": 0
Expand Down