-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make "reportable" setting consistent in zap file to avoid zap instability. #13632
Conversation
…able (difference between client and server configs)
NOTE: I plan to add more to this by checking ToT a bit to see what other things are unstable. I expect 2-3 zap files to need fixing in general. |
…should not change at runtime)
PR #13632: Size comparison from 8bdff01 to 6cbc889 Full report (30 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
I will merge this as a hotfix: zap is massively non-deterministic without this change and the change looks safe enough: I do not believe our regular codegen actually cares about reportable state (otherwise we would have seen non-determinism before). |
…lity. (project-chip#13632) * Make tv casting labelList and clusterRevision consistently non-reportable (difference between client and server configs) * More changes regarding reportable consistency on all clusters app.zap * Two more stability updates for reportability * After update, feature map is NOT reportable (which seems correct: it should not change at runtime)
…lity. (project-chip#13632) * Make tv casting labelList and clusterRevision consistently non-reportable (difference between client and server configs) * More changes regarding reportable consistency on all clusters app.zap * Two more stability updates for reportability * After update, feature map is NOT reportable (which seems correct: it should not change at runtime)
Problem
ZAP generation is unstable regarding "reportable" output, seen in matter IDL files like https://github.com/project-chip/connectedhomeip/runs/4843394902?check_suite_focus=true
and
https://github.com/project-chip/connectedhomeip/runs/4838407145?check_suite_focus=true
Change overview
Change the struct to be consistent between client & server. Note that this was manually edited (not sure what zap UI changes would be required to make this consistent).
Testing
CI will validate this.