Make "reportable" setting consistent in zap file to avoid zap instability. #13632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able (difference between client and server configs)
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
pan-apple,
sagar-apple and
saurabhst
pullapprove
bot
requested review from
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
|
NOTE: I plan to add more to this by checking ToT a bit to see what other things are unstable. I expect 2-3 zap files to need fixing in general. |
andy31415
changed the title
…should not change at runtime)
|
PR #13632: Size comparison from 8bdff01 to 6cbc889 Full report (30 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
|
I will merge this as a hotfix: zap is massively non-deterministic without this change and the change looks safe enough: I do not believe our regular codegen actually cares about reportable state (otherwise we would have seen non-determinism before). |
selissia
pushed a commit
to selissia/connectedhomeip
that referenced
this pull request
Jan 28, 2022
…lity. (project-chip#13632) * Make tv casting labelList and clusterRevision consistently non-reportable (difference between client and server configs) * More changes regarding reportable consistency on all clusters app.zap * Two more stability updates for reportability * After update, feature map is NOT reportable (which seems correct: it should not change at runtime)
step0035
pushed a commit
to hank820/connectedhomeip
that referenced
this pull request
Feb 8, 2022
…lity. (project-chip#13632) * Make tv casting labelList and clusterRevision consistently non-reportable (difference between client and server configs) * More changes regarding reportable consistency on all clusters app.zap * Two more stability updates for reportability * After update, feature map is NOT reportable (which seems correct: it should not change at runtime)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ZAP generation is unstable regarding "reportable" output, seen in matter IDL files like https://github.com/project-chip/connectedhomeip/runs/4843394902?check_suite_focus=true
and
https://github.com/project-chip/connectedhomeip/runs/4838407145?check_suite_focus=true
Change overview
Change the struct to be consistent between client & server. Note that this was manually edited (not sure what zap UI changes would be required to make this consistent).
Testing
CI will validate this.