-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[app] make CASESessionManager fabric independent #12766
Merged
woody-apple
merged 1 commit into
project-chip:master
from
gjc13:fabric-independent-case-manager
Dec 9, 2021
Merged
[app] make CASESessionManager fabric independent #12766
woody-apple
merged 1 commit into
project-chip:master
from
gjc13:fabric-independent-case-manager
Dec 9, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
sagar-apple,
saurabhst,
selissia and
tecimovic
December 9, 2021 03:34
pullapprove
bot
requested review from
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple and
yunhanw-google
December 9, 2021 03:34
PR #12766: Size comparison from bba082b to f4a5203 Increases (1 build for linux)
Full report (12 builds for efr32, k32w, linux, qpg, telink)
|
gjc13
force-pushed
the
fabric-independent-case-manager
branch
from
December 9, 2021 04:18
f4a5203
to
65ca2b0
Compare
PR #12766: Size comparison from bba082b to 65ca2b0 Increases (2 builds for esp32, linux)
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
gjc13
force-pushed
the
fabric-independent-case-manager
branch
from
December 9, 2021 06:12
65ca2b0
to
d02561f
Compare
PR #12766: Size comparison from a583812 to d02561f Increases (1 build for linux)
Full report (9 builds for k32w, linux, qpg, telink)
|
gjc13
force-pushed
the
fabric-independent-case-manager
branch
from
December 9, 2021 06:45
d02561f
to
a1679dc
Compare
PR #12766: Size comparison from 6ea2c90 to a1679dc Increases (2 builds for esp32, linux)
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
gjc13
force-pushed
the
fabric-independent-case-manager
branch
from
December 9, 2021 11:52
a1679dc
to
62b6a24
Compare
gjc13
force-pushed
the
fabric-independent-case-manager
branch
from
December 9, 2021 11:54
62b6a24
to
bc7cb05
Compare
PR #12766: Size comparison from 8adecf7 to bc7cb05 Increases (2 builds for esp32, linux)
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
msandstedt
approved these changes
Dec 9, 2021
woody-apple
approved these changes
Dec 9, 2021
pullapprove
bot
requested review from
Byungjoo-Lee,
chshu,
dhrishi and
xylophone21
December 9, 2021 21:30
Merging based on 2 approvals. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
CASESessionManager
class is currently bound to a fabric. This enforces theCASESessionManager
to be re-allocated for each fabric as in #12636.Change overview
Make
CASESessionManager
fabric independent.Testing