-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for matter cli in EFR32 example apps #12749
Merged
jmartinez-silabs
merged 4 commits into
project-chip:master
from
jmartinez-silabs:shellInApp
Dec 9, 2021
Merged
Add support for matter cli in EFR32 example apps #12749
jmartinez-silabs
merged 4 commits into
project-chip:master
from
jmartinez-silabs:shellInApp
Dec 9, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move at least OTCLI to default commands in lib/shell/commandsconnectedhomeip/examples/platform/efr32/matter_shell.cpp Lines 78 to 88 in 7b7dc3e
This comment was generated by todo based on a
|
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
LuDuda,
lzgrablic02,
msandstedt,
mspang,
pan-apple,
robszewczyk and
sagar-apple
December 8, 2021 19:58
pullapprove
bot
requested review from
saurabhst,
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
yufengwangca and
yunhanw-google
December 8, 2021 19:58
PR #12749: Size comparison from e4f3246 to 7b7dc3e Increases (3 builds for efr32)
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
yunhanw-google
approved these changes
Dec 8, 2021
woody-apple
approved these changes
Dec 9, 2021
Fast tracking platform changes pushed by a platform maintainer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Matter cli only runs on the shell example app for EFR32 platform
Change overview
Create a platform source_set for shell support on efr32.
Pull the shell task to platform wide file.
Shell main loob is notified on uart rx activity instead of the busy wait to read a line used in the shell example app.
Testing
build examples with
chip_build_libshell
argument to truee.g:
gn gen out/debug --args='efr32_board="BRD4186A" chip_build_libshell=true'
Test that matter cli is available on the serial port