Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use null-terminated SerialNumber #11462

Merged
merged 1 commit into from
Nov 8, 2021
Merged

Use null-terminated SerialNumber #11462

merged 1 commit into from
Nov 8, 2021

Conversation

markus-becker-tridonic-com
Copy link
Contributor

Problem

Other strings (FirmwareRevisionString, ProductionRevisionString, ProductName, VendorName) are null-terminated. SerialNumber is not.

Change overview

  • Aligned with FirmwareRevisionString, ProductionRevisionString, ProductName, VendorName
    which are also null-terminated
  • Adapt SerialNumber test accordingly

Testing

Serial Number has a unit test.

Tested on nrf52840-dk lighting-app with

@markus-becker-tridonic-com markus-becker-tridonic-com mentioned this pull request Nov 5, 2021
Merged
@github-actions
Copy link

github-actions bot commented Nov 5, 2021 •
edited
Loading

PR #11462: Size comparison from 7b71fb2 to 9c9d9db

Increases (11 builds for esp32, k32w, p6, qpg, telink)
platform target config section 7b71fb2 9c9d9db change % change
esp32 all-clusters-app c3devkit (read only) 882498 882518 20 0.0
.flash.text 882498 882518 20 0.0
m5stack (read only) 913359 913395 36 0.0
.flash.text 913359 913395 36 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699136 699172 36 0.0
.text 613648 613684 36 0.0
lock-app k32w061+debug (read/write) 591956 591992 36 0.0
.text 515968 516004 36 0.0
shell k32w061+debug (read/write) 657448 657468 20 0.0
.text 570856 570876 20 0.0
p6 all-clusters-app default (read/write) 2300072 2300112 40 0.0
.text 1258336 1258376 40 0.0
lock-app default (read/write) 2212784 2212824 40 0.0
.text 1171048 1171088 40 0.0
qpg lighting-app qpg6100+debug (read only) 490532 490560 28 0.0
.text 485212 485240 28 0.0
lock-app qpg6100+debug (read only) 466872 466900 28 0.0
.text 461552 461580 28 0.0
persistent-storage-app qpg6100+debug (read only) 153212 153240 28 0.0
.text 147892 147920 28 0.0
telink lighting-app tlsr9518adk80d (read/write) 662870 662898 28 0.0
text 457962 457982 20 0.0
Full report (11 builds for esp32, k32w, p6, qpg, telink)
platform target config section 7b71fb2 9c9d9db change % change
esp32 all-clusters-app c3devkit (read only) 882498 882518 20 0.0
(read/write) 1305960 1305960 0 0.0
.dram0.bss 57576 57576 0 0.0
.dram0.data 16472 16472 0 0.0
.flash.rodata 198664 198664 0 0.0
.flash.text 882498 882518 20 0.0
.iram0.text 57624 57624 0 0.0
m5stack (read only) 913359 913395 36 0.0
(read/write) 423268 423268 0 0.0
.dram0.bss 60088 60088 0 0.0
.dram0.data 32108 32108 0 0.0
.flash.rodata 204908 204908 0 0.0
.flash.text 913359 913395 36 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699136 699172 36 0.0
.bss 77784 77784 0 0.0
.data 1904 1904 0 0.0
.text 613648 613684 36 0.0
lock-app k32w061+debug (read/write) 591956 591992 36 0.0
.bss 68316 68316 0 0.0
.data 1872 1872 0 0.0
.text 515968 516004 36 0.0
shell k32w061+debug (read/write) 657448 657468 20 0.0
.bss 78952 78952 0 0.0
.data 1840 1840 0 0.0
.text 570856 570876 20 0.0
p6 all-clusters-app default (read/write) 2300072 2300112 40 0.0
.bss 106840 106840 0 0.0
.data 2520 2520 0 0.0
.heap 923984 923984 0 0.0
.text 1258336 1258376 40 0.0
lock-app default (read/write) 2212784 2212824 40 0.0
.bss 95648 95648 0 0.0
.data 2392 2392 0 0.0
.heap 935304 935304 0 0.0
.text 1171048 1171088 40 0.0
qpg lighting-app qpg6100+debug (read only) 490532 490560 28 0.0
(read/write) 114140 114140 0 0.0
.bss 50944 50944 0 0.0
.data 1004 1004 0 0.0
.text 485212 485240 28 0.0
lock-app qpg6100+debug (read only) 466872 466900 28 0.0
(read/write) 114144 114144 0 0.0
.bss 49888 49888 0 0.0
.data 960 960 0 0.0
.text 461552 461580 28 0.0
persistent-storage-app qpg6100+debug (read only) 153212 153240 28 0.0
(read/write) 114140 114140 0 0.0
.bss 18912 18912 0 0.0
.data 356 356 0 0.0
.text 147892 147920 28 0.0
telink lighting-app tlsr9518adk80d (read/write) 662870 662898 28 0.0
bss 69072 69072 0 0.0
noinit 33216 33216 0 0.0
text 457962 457982 20 0.0

@markus-becker-tridonic-com
Copy link
Contributor Author

@bzbarsky-apple please wait with review, I am still fixing up things.

@markus-becker-tridonic-com markus-becker-tridonic-com force-pushed the null-terminated-serialnumber branch 2 times, most recently from 3e2b0d9 to 45db284 Compare November 5, 2021 10:54
@github-actions
Copy link

github-actions bot commented Nov 5, 2021 •
edited
Loading

PR #11462: Size comparison from 3f67119 to 45db284

Increases (9 builds for k32w, p6, qpg, telink)
platform target config section 3f67119 45db284 change % change
k32w lighting-app k32w061+se05x+release (read/write) 699168 699184 16 0.0
.text 613680 613696 16 0.0
lock-app k32w061+debug (read/write) 591988 592004 16 0.0
.text 516000 516016 16 0.0
shell k32w061+debug (read/write) 657480 657496 16 0.0
.text 570888 570904 16 0.0
p6 all-clusters-app default (read/write) 2300152 2300184 32 0.0
.text 1258416 1258448 32 0.0
lock-app default (read/write) 2212864 2212896 32 0.0
.text 1171128 1171160 32 0.0
qpg lighting-app qpg6100+debug (read only) 490556 490580 24 0.0
.text 485236 485260 24 0.0
lock-app qpg6100+debug (read only) 466896 466920 24 0.0
.text 461576 461600 24 0.0
persistent-storage-app qpg6100+debug (read only) 153212 153228 16 0.0
.text 147892 147908 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 662910 662934 24 0.0
text 458002 458022 20 0.0
Full report (9 builds for k32w, p6, qpg, telink)
platform target config section 3f67119 45db284 change % change
k32w lighting-app k32w061+se05x+release (read/write) 699168 699184 16 0.0
.bss 77784 77784 0 0.0
.data 1904 1904 0 0.0
.text 613680 613696 16 0.0
lock-app k32w061+debug (read/write) 591988 592004 16 0.0
.bss 68316 68316 0 0.0
.data 1872 1872 0 0.0
.text 516000 516016 16 0.0
shell k32w061+debug (read/write) 657480 657496 16 0.0
.bss 78952 78952 0 0.0
.data 1840 1840 0 0.0
.text 570888 570904 16 0.0
p6 all-clusters-app default (read/write) 2300152 2300184 32 0.0
.bss 106840 106840 0 0.0
.data 2520 2520 0 0.0
.heap 923984 923984 0 0.0
.text 1258416 1258448 32 0.0
lock-app default (read/write) 2212864 2212896 32 0.0
.bss 95648 95648 0 0.0
.data 2392 2392 0 0.0
.heap 935304 935304 0 0.0
.text 1171128 1171160 32 0.0
qpg lighting-app qpg6100+debug (read only) 490556 490580 24 0.0
(read/write) 114140 114140 0 0.0
.bss 50944 50944 0 0.0
.data 1004 1004 0 0.0
.text 485236 485260 24 0.0
lock-app qpg6100+debug (read only) 466896 466920 24 0.0
(read/write) 114144 114144 0 0.0
.bss 49888 49888 0 0.0
.data 960 960 0 0.0
.text 461576 461600 24 0.0
persistent-storage-app qpg6100+debug (read only) 153212 153228 16 0.0
(read/write) 114140 114140 0 0.0
.bss 18912 18912 0 0.0
.data 356 356 0 0.0
.text 147892 147908 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 662910 662934 24 0.0
bss 69072 69072 0 0.0
noinit 33216 33216 0 0.0
text 458002 458022 20 0.0

@github-actions
Copy link

github-actions bot commented Nov 5, 2021 •
edited
Loading

PR #11462: Size comparison from 3f67119 to 60d5dc8

Increases (31 builds for efr32, esp32, k32w, linux, nrfconnect, p6, qpg, telink)
platform target config section 3f67119 60d5dc8 change % change
efr32 lighting-app BRD4161A (read only) 744852 744868 16 0.0
.text 744844 744860 16 0.0
BRD4161A+rpc (read only) 732384 732416 32 0.0
.text 732376 732408 32 0.0
lock-app BRD4161A (read only) 724136 724168 32 0.0
.text 724128 724160 32 0.0
window-app BRD4161A (read only) 725048 725064 16 0.0
.text 725040 725056 16 0.0
esp32 all-clusters-app c3devkit (read only) 882538 882558 20 0.0
.flash.text 882538 882558 20 0.0
m5stack (read only) 913387 913415 28 0.0
.flash.text 913387 913415 28 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699168 699184 16 0.0
.text 613680 613696 16 0.0
lock-app k32w061+debug (read/write) 591988 592004 16 0.0
.text 516000 516016 16 0.0
shell k32w061+debug (read/write) 657480 657496 16 0.0
.text 570888 570904 16 0.0
linux all-clusters-app debug (read only) 1703297 1703313 16 0.0
.text 1430674 1430690 16 0.0
bridge-app debug+rpc (read only) 1291317 1291333 16 0.0
.text 1084453 1084469 16 0.0
chip-tool debug (read only) 4508853 4508885 32 0.0
.text 4008565 4008597 32 0.0
ota-provider-app debug (read only) 1250553 1250569 16 0.0
.text 1042258 1042274 16 0.0
ota-requestor-app debug (read only) 1328881 1328897 16 0.0
.text 1106626 1106642 16 0.0
shell debug (read only) 787481 787513 32 0.0
.text 608066 608098 32 0.0
tv-app debug (read only) 1815953 1815969 16 0.0
.text 1518434 1518450 16 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861255 861271 16 0.0
text 577508 577532 24 0.0
nrf52840dk_nrf52840+rpc (read/write) 823583 823615 32 0.0
text 551656 551680 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786278 786310 32 0.0
text 506964 506988 24 0.0
lock-app nrf52840dk_nrf52840 (read/write) 837959 837975 16 0.0
text 558988 559012 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763258 763274 16 0.0
text 488536 488560 24 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844055 844071 16 0.0
text 563152 563176 24 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837815 837847 32 0.0
text 558724 558748 24 0.0
shell nrf52840dk_nrf52840 (read/write) 775931 775947 16 0.0
text 519764 519784 20 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 690954 690986 32 0.0
text 440356 440376 20 0.0
p6 all-clusters-app default (read/write) 2300152 2300184 32 0.0
.text 1258416 1258448 32 0.0
lock-app default (read/write) 2212864 2212896 32 0.0
.text 1171128 1171160 32 0.0
qpg lighting-app qpg6100+debug (read only) 490556 490580 24 0.0
.text 485236 485260 24 0.0
lock-app qpg6100+debug (read only) 466896 466920 24 0.0
.text 461576 461600 24 0.0
persistent-storage-app qpg6100+debug (read only) 153212 153228 16 0.0
.text 147892 147908 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 662910 662934 24 0.0
text 458002 458022 20 0.0
Decreases (4 builds for mbed)
platform target config section 3f67119 60d5dc8 change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2291408 2291248 -160 -0.0
.text 1254008 1253848 -160 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2271504 2271408 -96 -0.0
.text 1234104 1234008 -96 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2249224 2249064 -160 -0.0
.text 1211824 1211664 -160 -0.0
shell CY8CPROTO_062_4343W+release (read/write) 2048464 2048304 -160 -0.0
.text 1011064 1010904 -160 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 3f67119 60d5dc8 change % change
efr32 lighting-app BRD4161A (read only) 744852 744868 16 0.0
(read/write) 115704 115704 0 0.0
.bss 113932 113932 0 0.0
.data 1772 1772 0 0.0
.text 744844 744860 16 0.0
BRD4161A+rpc (read only) 732384 732416 32 0.0
(read/write) 132324 132324 0 0.0
.bss 130436 130436 0 0.0
.data 1888 1888 0 0.0
.text 732376 732408 32 0.0
lock-app BRD4161A (read only) 724136 724168 32 0.0
(read/write) 113524 113524 0 0.0
.bss 111788 111788 0 0.0
.data 1732 1732 0 0.0
.text 724128 724160 32 0.0
window-app BRD4161A (read only) 725048 725064 16 0.0
(read/write) 113844 113844 0 0.0
.bss 112108 112108 0 0.0
.data 1736 1736 0 0.0
.text 725040 725056 16 0.0
esp32 all-clusters-app c3devkit (read only) 882538 882558 20 0.0
(read/write) 1305960 1305960 0 0.0
.dram0.bss 57576 57576 0 0.0
.dram0.data 16472 16472 0 0.0
.flash.rodata 198664 198664 0 0.0
.flash.text 882538 882558 20 0.0
.iram0.text 57624 57624 0 0.0
m5stack (read only) 913387 913415 28 0.0
(read/write) 423268 423268 0 0.0
.dram0.bss 60088 60088 0 0.0
.dram0.data 32108 32108 0 0.0
.flash.rodata 204908 204908 0 0.0
.flash.text 913387 913415 28 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699168 699184 16 0.0
.bss 77784 77784 0 0.0
.data 1904 1904 0 0.0
.text 613680 613696 16 0.0
lock-app k32w061+debug (read/write) 591988 592004 16 0.0
.bss 68316 68316 0 0.0
.data 1872 1872 0 0.0
.text 516000 516016 16 0.0
shell k32w061+debug (read/write) 657480 657496 16 0.0
.bss 78952 78952 0 0.0
.data 1840 1840 0 0.0
.text 570888 570904 16 0.0
linux all-clusters-app debug (read only) 1703297 1703313 16 0.0
(read/write) 118656 118656 0 0.0
.bss 50000 50000 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62336 62336 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 139157 139157 0 0.0
.text 1430674 1430690 16 0.0
bridge-app debug+rpc (read only) 1291317 1291333 16 0.0
(read/write) 69232 69232 0 0.0
.bss 34928 34928 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27768 27768 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110948 110948 0 0.0
.text 1084453 1084469 16 0.0
chip-tool debug (read only) 4508853 4508885 32 0.0
(read/write) 125864 125864 0 0.0
.bss 18128 18128 0 0.0
.data 2224 2224 0 0.0
.data.rel.ro 100096 100096 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 432 432 0 0.0
.rodata 231824 231824 0 0.0
.text 4008565 4008597 32 0.0
lighting-app debug+rpc (read only) 1552313 1552313 0 0.0
(read/write) 102200 102200 0 0.0
.bss 40568 40568 0 0.0
.data 1170 1170 0 0.0
.data.rel.ro 55168 55168 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 129585 129585 0 0.0
.text 1289122 1289122 0 0.0
ota-provider-app debug (read only) 1250553 1250569 16 0.0
(read/write) 67400 67400 0 0.0
.bss 36992 36992 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24568 24568 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112168 112168 0 0.0
.text 1042258 1042274 16 0.0
ota-requestor-app debug (read only) 1328881 1328897 16 0.0
(read/write) 76656 76656 0 0.0
.bss 45120 45120 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25576 25576 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 124176 124176 0 0.0
.text 1106626 1106642 16 0.0
shell debug (read only) 787481 787513 32 0.0
(read/write) 57608 57608 0 0.0
.bss 16040 16040 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36816 36816 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 77903 77903 0 0.0
.text 608066 608098 32 0.0
tv-app debug (read only) 1815953 1815969 16 0.0
(read/write) 289824 289824 0 0.0
.bss 222640 222640 0 0.0
.data 2704 2704 0 0.0
.data.rel.ro 58824 58824 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155208 155208 0 0.0
.text 1518434 1518450 16 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2291408 2291248 -160 -0.0
.bss 178892 178892 0 0.0
.data 5224 5224 0 0.0
.heap 852328 852328 0 0.0
.text 1254008 1253848 -160 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2271504 2271408 -96 -0.0
.bss 171948 171948 0 0.0
.data 5568 5568 0 0.0
.heap 858928 858928 0 0.0
.text 1234104 1234008 -96 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2249224 2249064 -160 -0.0
.bss 170844 170844 0 0.0
.data 5560 5560 0 0.0
.heap 860040 860040 0 0.0
.text 1211824 1211664 -160 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048464 2048304 -160 -0.0
.bss 156224 156224 0 0.0
.data 4960 4960 0 0.0
.heap 875264 875264 0 0.0
.text 1011064 1010904 -160 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861255 861271 16 0.0
bss 111256 111256 0 0.0
rodata 96872 96872 0 0.0
text 577508 577532 24 0.0
nrf52840dk_nrf52840+rpc (read/write) 823583 823615 32 0.0
bss 107608 107608 0 0.0
rodata 88048 88048 0 0.0
text 551656 551680 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786278 786310 32 0.0
bss 112632 112632 0 0.0
rodata 92128 92128 0 0.0
text 506964 506988 24 0.0
lock-app nrf52840dk_nrf52840 (read/write) 837959 837975 16 0.0
bss 110292 110292 0 0.0
rodata 93240 93240 0 0.0
text 558988 559012 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763258 763274 16 0.0
bss 111700 111700 0 0.0
rodata 88548 88548 0 0.0
text 488536 488560 24 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844055 844071 16 0.0
bss 110428 110428 0 0.0
rodata 94952 94952 0 0.0
text 563152 563176 24 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837815 837847 32 0.0
bss 110328 110328 0 0.0
rodata 93240 93240 0 0.0
text 558724 558748 24 0.0
shell nrf52840dk_nrf52840 (read/write) 775931 775947 16 0.0
bss 109080 109080 0 0.0
rodata 72496 72496 0 0.0
text 519764 519784 20 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 690954 690986 32 0.0
bss 110060 110060 0 0.0
rodata 67140 67140 0 0.0
text 440356 440376 20 0.0
p6 all-clusters-app default (read/write) 2300152 2300184 32 0.0
.bss 106840 106840 0 0.0
.data 2520 2520 0 0.0
.heap 923984 923984 0 0.0
.text 1258416 1258448 32 0.0
lock-app default (read/write) 2212864 2212896 32 0.0
.bss 95648 95648 0 0.0
.data 2392 2392 0 0.0
.heap 935304 935304 0 0.0
.text 1171128 1171160 32 0.0
qpg lighting-app qpg6100+debug (read only) 490556 490580 24 0.0
(read/write) 114140 114140 0 0.0
.bss 50944 50944 0 0.0
.data 1004 1004 0 0.0
.text 485236 485260 24 0.0
lock-app qpg6100+debug (read only) 466896 466920 24 0.0
(read/write) 114144 114144 0 0.0
.bss 49888 49888 0 0.0
.data 960 960 0 0.0
.text 461576 461600 24 0.0
persistent-storage-app qpg6100+debug (read only) 153212 153228 16 0.0
(read/write) 114140 114140 0 0.0
.bss 18912 18912 0 0.0
.data 356 356 0 0.0
.text 147892 147908 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 662910 662934 24 0.0
bss 69072 69072 0 0.0
noinit 33216 33216 0 0.0
text 458002 458022 20 0.0

@github-actions
Copy link

github-actions bot commented Nov 5, 2021 •
edited
Loading

PR #11462: Size comparison from 3f67119 to 651b75b

Increases (31 builds for efr32, esp32, k32w, linux, nrfconnect, p6, qpg, telink)
platform target config section 3f67119 651b75b change % change
efr32 lighting-app BRD4161A (read only) 744852 744868 16 0.0
.text 744844 744860 16 0.0
BRD4161A+rpc (read only) 732384 732416 32 0.0
.text 732376 732408 32 0.0
lock-app BRD4161A (read only) 724136 724168 32 0.0
.text 724128 724160 32 0.0
window-app BRD4161A (read only) 725048 725064 16 0.0
.text 725040 725056 16 0.0
esp32 all-clusters-app c3devkit (read only) 882538 882558 20 0.0
.flash.text 882538 882558 20 0.0
m5stack (read only) 913387 913415 28 0.0
.flash.text 913387 913415 28 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699168 699184 16 0.0
.text 613680 613696 16 0.0
lock-app k32w061+debug (read/write) 591988 592004 16 0.0
.text 516000 516016 16 0.0
shell k32w061+debug (read/write) 657480 657496 16 0.0
.text 570888 570904 16 0.0
linux all-clusters-app debug (read only) 1703297 1703313 16 0.0
.text 1430674 1430690 16 0.0
bridge-app debug+rpc (read only) 1291317 1291333 16 0.0
.text 1084453 1084469 16 0.0
chip-tool debug (read only) 4508853 4508885 32 0.0
.text 4008565 4008597 32 0.0
ota-provider-app debug (read only) 1250553 1250569 16 0.0
.text 1042258 1042274 16 0.0
ota-requestor-app debug (read only) 1328881 1328897 16 0.0
.text 1106626 1106642 16 0.0
shell debug (read only) 787481 787513 32 0.0
.text 608066 608098 32 0.0
tv-app debug (read only) 1815953 1815969 16 0.0
.text 1518434 1518450 16 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861255 861271 16 0.0
text 577508 577532 24 0.0
nrf52840dk_nrf52840+rpc (read/write) 823583 823615 32 0.0
text 551656 551680 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786278 786310 32 0.0
text 506964 506988 24 0.0
lock-app nrf52840dk_nrf52840 (read/write) 837959 837975 16 0.0
text 558988 559012 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763258 763274 16 0.0
text 488536 488560 24 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844055 844071 16 0.0
text 563152 563176 24 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837815 837847 32 0.0
text 558724 558748 24 0.0
shell nrf52840dk_nrf52840 (read/write) 775931 775947 16 0.0
text 519764 519784 20 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 690954 690986 32 0.0
text 440356 440376 20 0.0
p6 all-clusters-app default (read/write) 2300152 2300184 32 0.0
.text 1258416 1258448 32 0.0
lock-app default (read/write) 2212864 2212896 32 0.0
.text 1171128 1171160 32 0.0
qpg lighting-app qpg6100+debug (read only) 490556 490580 24 0.0
.text 485236 485260 24 0.0
lock-app qpg6100+debug (read only) 466896 466920 24 0.0
.text 461576 461600 24 0.0
persistent-storage-app qpg6100+debug (read only) 153212 153228 16 0.0
.text 147892 147908 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 662910 662934 24 0.0
text 458002 458022 20 0.0
Decreases (4 builds for mbed)
platform target config section 3f67119 651b75b change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2291408 2291248 -160 -0.0
.text 1254008 1253848 -160 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2271504 2271408 -96 -0.0
.text 1234104 1234008 -96 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2249224 2249064 -160 -0.0
.text 1211824 1211664 -160 -0.0
shell CY8CPROTO_062_4343W+release (read/write) 2048464 2048304 -160 -0.0
.text 1011064 1010904 -160 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 3f67119 651b75b change % change
efr32 lighting-app BRD4161A (read only) 744852 744868 16 0.0
(read/write) 115704 115704 0 0.0
.bss 113932 113932 0 0.0
.data 1772 1772 0 0.0
.text 744844 744860 16 0.0
BRD4161A+rpc (read only) 732384 732416 32 0.0
(read/write) 132324 132324 0 0.0
.bss 130436 130436 0 0.0
.data 1888 1888 0 0.0
.text 732376 732408 32 0.0
lock-app BRD4161A (read only) 724136 724168 32 0.0
(read/write) 113524 113524 0 0.0
.bss 111788 111788 0 0.0
.data 1732 1732 0 0.0
.text 724128 724160 32 0.0
window-app BRD4161A (read only) 725048 725064 16 0.0
(read/write) 113844 113844 0 0.0
.bss 112108 112108 0 0.0
.data 1736 1736 0 0.0
.text 725040 725056 16 0.0
esp32 all-clusters-app c3devkit (read only) 882538 882558 20 0.0
(read/write) 1305960 1305960 0 0.0
.dram0.bss 57576 57576 0 0.0
.dram0.data 16472 16472 0 0.0
.flash.rodata 198664 198664 0 0.0
.flash.text 882538 882558 20 0.0
.iram0.text 57624 57624 0 0.0
m5stack (read only) 913387 913415 28 0.0
(read/write) 423268 423268 0 0.0
.dram0.bss 60088 60088 0 0.0
.dram0.data 32108 32108 0 0.0
.flash.rodata 204908 204908 0 0.0
.flash.text 913387 913415 28 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699168 699184 16 0.0
.bss 77784 77784 0 0.0
.data 1904 1904 0 0.0
.text 613680 613696 16 0.0
lock-app k32w061+debug (read/write) 591988 592004 16 0.0
.bss 68316 68316 0 0.0
.data 1872 1872 0 0.0
.text 516000 516016 16 0.0
shell k32w061+debug (read/write) 657480 657496 16 0.0
.bss 78952 78952 0 0.0
.data 1840 1840 0 0.0
.text 570888 570904 16 0.0
linux all-clusters-app debug (read only) 1703297 1703313 16 0.0
(read/write) 118656 118656 0 0.0
.bss 50000 50000 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62336 62336 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 139157 139157 0 0.0
.text 1430674 1430690 16 0.0
bridge-app debug+rpc (read only) 1291317 1291333 16 0.0
(read/write) 69232 69232 0 0.0
.bss 34928 34928 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27768 27768 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110948 110948 0 0.0
.text 1084453 1084469 16 0.0
chip-tool debug (read only) 4508853 4508885 32 0.0
(read/write) 125864 125864 0 0.0
.bss 18128 18128 0 0.0
.data 2224 2224 0 0.0
.data.rel.ro 100096 100096 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 432 432 0 0.0
.rodata 231824 231824 0 0.0
.text 4008565 4008597 32 0.0
lighting-app debug+rpc (read only) 1552313 1552313 0 0.0
(read/write) 102200 102200 0 0.0
.bss 40568 40568 0 0.0
.data 1170 1170 0 0.0
.data.rel.ro 55168 55168 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 129585 129585 0 0.0
.text 1289122 1289122 0 0.0
ota-provider-app debug (read only) 1250553 1250569 16 0.0
(read/write) 67400 67400 0 0.0
.bss 36992 36992 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24568 24568 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112168 112168 0 0.0
.text 1042258 1042274 16 0.0
ota-requestor-app debug (read only) 1328881 1328897 16 0.0
(read/write) 76656 76656 0 0.0
.bss 45120 45120 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25576 25576 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 124176 124176 0 0.0
.text 1106626 1106642 16 0.0
shell debug (read only) 787481 787513 32 0.0
(read/write) 57608 57608 0 0.0
.bss 16040 16040 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36816 36816 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 77903 77903 0 0.0
.text 608066 608098 32 0.0
tv-app debug (read only) 1815953 1815969 16 0.0
(read/write) 289824 289824 0 0.0
.bss 222640 222640 0 0.0
.data 2704 2704 0 0.0
.data.rel.ro 58824 58824 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155208 155208 0 0.0
.text 1518434 1518450 16 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2291408 2291248 -160 -0.0
.bss 178892 178892 0 0.0
.data 5224 5224 0 0.0
.heap 852328 852328 0 0.0
.text 1254008 1253848 -160 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2271504 2271408 -96 -0.0
.bss 171948 171948 0 0.0
.data 5568 5568 0 0.0
.heap 858928 858928 0 0.0
.text 1234104 1234008 -96 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2249224 2249064 -160 -0.0
.bss 170844 170844 0 0.0
.data 5560 5560 0 0.0
.heap 860040 860040 0 0.0
.text 1211824 1211664 -160 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048464 2048304 -160 -0.0
.bss 156224 156224 0 0.0
.data 4960 4960 0 0.0
.heap 875264 875264 0 0.0
.text 1011064 1010904 -160 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861255 861271 16 0.0
bss 111256 111256 0 0.0
rodata 96872 96872 0 0.0
text 577508 577532 24 0.0
nrf52840dk_nrf52840+rpc (read/write) 823583 823615 32 0.0
bss 107608 107608 0 0.0
rodata 88048 88048 0 0.0
text 551656 551680 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786278 786310 32 0.0
bss 112632 112632 0 0.0
rodata 92128 92128 0 0.0
text 506964 506988 24 0.0
lock-app nrf52840dk_nrf52840 (read/write) 837959 837975 16 0.0
bss 110292 110292 0 0.0
rodata 93240 93240 0 0.0
text 558988 559012 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763258 763274 16 0.0
bss 111700 111700 0 0.0
rodata 88548 88548 0 0.0
text 488536 488560 24 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844055 844071 16 0.0
bss 110428 110428 0 0.0
rodata 94952 94952 0 0.0
text 563152 563176 24 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837815 837847 32 0.0
bss 110328 110328 0 0.0
rodata 93240 93240 0 0.0
text 558724 558748 24 0.0
shell nrf52840dk_nrf52840 (read/write) 775931 775947 16 0.0
bss 109080 109080 0 0.0
rodata 72496 72496 0 0.0
text 519764 519784 20 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 690954 690986 32 0.0
bss 110060 110060 0 0.0
rodata 67140 67140 0 0.0
text 440356 440376 20 0.0
p6 all-clusters-app default (read/write) 2300152 2300184 32 0.0
.bss 106840 106840 0 0.0
.data 2520 2520 0 0.0
.heap 923984 923984 0 0.0
.text 1258416 1258448 32 0.0
lock-app default (read/write) 2212864 2212896 32 0.0
.bss 95648 95648 0 0.0
.data 2392 2392 0 0.0
.heap 935304 935304 0 0.0
.text 1171128 1171160 32 0.0
qpg lighting-app qpg6100+debug (read only) 490556 490580 24 0.0
(read/write) 114140 114140 0 0.0
.bss 50944 50944 0 0.0
.data 1004 1004 0 0.0
.text 485236 485260 24 0.0
lock-app qpg6100+debug (read only) 466896 466920 24 0.0
(read/write) 114144 114144 0 0.0
.bss 49888 49888 0 0.0
.data 960 960 0 0.0
.text 461576 461600 24 0.0
persistent-storage-app qpg6100+debug (read only) 153212 153228 16 0.0
(read/write) 114140 114140 0 0.0
.bss 18912 18912 0 0.0
.data 356 356 0 0.0
.text 147892 147908 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 662910 662934 24 0.0
bss 69072 69072 0 0.0
noinit 33216 33216 0 0.0
text 458002 458022 20 0.0

@markus-becker-tridonic-com
Use null-terminated SerialNumber
03c577a 
* Aligned with FirmwareRevisionString, ProductionRevisionString, ProductName, VendorName
 which are also null-terminated
* Adapt SerialNumber test accordingly
@github-actions
Copy link

github-actions bot commented Nov 8, 2021 •
edited
Loading

PR #11462: Size comparison from 3f82de1 to 03c577a

Increases (32 builds for efr32, esp32, k32w, linux, nrfconnect, p6, qpg, telink)
platform target config section 3f82de1 03c577a change % change
efr32 lighting-app BRD4161A (read only) 745848 745880 32 0.0
.text 745840 745872 32 0.0
BRD4161A+rpc (read only) 733384 733416 32 0.0
.text 733376 733408 32 0.0
lock-app BRD4161A (read only) 725136 725168 32 0.0
.text 725128 725160 32 0.0
window-app BRD4161A (read only) 726032 726064 32 0.0
.text 726024 726056 32 0.0
esp32 all-clusters-app c3devkit (read only) 882786 882810 24 0.0
.flash.text 882786 882810 24 0.0
m5stack (read only) 913623 913659 36 0.0
.flash.text 913623 913659 36 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699560 699576 16 0.0
.text 614044 614060 16 0.0
lock-app k32w061+debug (read/write) 592364 592396 32 0.0
.text 516348 516380 32 0.0
shell k32w061+debug (read/write) 657860 657892 32 0.0
.text 571236 571268 32 0.0
linux all-clusters-app debug (read only) 1704225 1704321 96 0.0
.text 1431586 1431682 96 0.0
bridge-app debug+rpc (read only) 1292261 1292357 96 0.0
.text 1085365 1085461 96 0.0
chip-tool debug (read only) 4931485 4931597 112 0.0
.text 4429077 4429189 112 0.0
lighting-app debug+rpc (read only) 1553257 1553353 96 0.0
.text 1290050 1290146 96 0.0
ota-provider-app debug (read only) 1251465 1251561 96 0.0
.text 1043154 1043250 96 0.0
ota-requestor-app debug (read only) 1329761 1329857 96 0.0
.text 1107522 1107618 96 0.0
shell debug (read only) 788041 788153 112 0.0
.text 608642 608754 112 0.0
tv-app debug (read only) 1817233 1817329 96 0.0
.text 1519666 1519762 96 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861635 861667 32 0.0
text 577804 577836 32 0.0
nrf52840dk_nrf52840+rpc (read/write) 823983 824015 32 0.0
text 551952 551984 32 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786678 786710 32 0.0
text 507264 507296 32 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838359 838391 32 0.0
text 559284 559316 32 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763654 763686 32 0.0
text 488836 488868 32 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844451 844483 32 0.0
text 563448 563480 32 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838215 838247 32 0.0
text 559020 559052 32 0.0
shell nrf52840dk_nrf52840 (read/write) 776231 776263 32 0.0
text 519988 520016 28 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691270 691302 32 0.0
text 440584 440612 28 0.0
p6 all-clusters-app default (read/write) 2301136 2301168 32 0.0
.text 1259400 1259432 32 0.0
lock-app default (read/write) 2213848 2213880 32 0.0
.text 1172112 1172144 32 0.0
qpg lighting-app qpg6100+debug (read only) 490896 490920 24 0.0
.text 485576 485600 24 0.0
lock-app qpg6100+debug (read only) 467236 467268 32 0.0
.text 461916 461948 32 0.0
persistent-storage-app qpg6100+debug (read only) 153316 153340 24 0.0
.text 147996 148020 24 0.0
telink lighting-app tlsr9518adk80d (read/write) 663242 663266 24 0.0
text 458250 458274 24 0.0
Decreases (4 builds for mbed)
platform target config section 3f82de1 03c577a change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2291640 2291544 -96 -0.0
.text 1254240 1254144 -96 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2271800 2271640 -160 -0.0
.text 1234400 1234240 -160 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2249456 2249360 -96 -0.0
.text 1212056 1211960 -96 -0.0
shell CY8CPROTO_062_4343W+release (read/write) 2048912 2048760 -152 -0.0
.text 1011512 1011360 -152 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 3f82de1 03c577a change % change
efr32 lighting-app BRD4161A (read only) 745848 745880 32 0.0
(read/write) 115740 115740 0 0.0
.bss 113964 113964 0 0.0
.data 1776 1776 0 0.0
.text 745840 745872 32 0.0
BRD4161A+rpc (read only) 733384 733416 32 0.0
(read/write) 132364 132364 0 0.0
.bss 130468 130468 0 0.0
.data 1892 1892 0 0.0
.text 733376 733408 32 0.0
lock-app BRD4161A (read only) 725136 725168 32 0.0
(read/write) 113556 113556 0 0.0
.bss 111820 111820 0 0.0
.data 1736 1736 0 0.0
.text 725128 725160 32 0.0
window-app BRD4161A (read only) 726032 726064 32 0.0
(read/write) 113884 113884 0 0.0
.bss 112140 112140 0 0.0
.data 1740 1740 0 0.0
.text 726024 726056 32 0.0
esp32 all-clusters-app c3devkit (read only) 882786 882810 24 0.0
(read/write) 1306040 1306040 0 0.0
.dram0.bss 57608 57608 0 0.0
.dram0.data 16472 16472 0 0.0
.flash.rodata 198712 198712 0 0.0
.flash.text 882786 882810 24 0.0
.iram0.text 57624 57624 0 0.0
m5stack (read only) 913623 913659 36 0.0
(read/write) 423336 423336 0 0.0
.dram0.bss 60112 60112 0 0.0
.dram0.data 32108 32108 0 0.0
.flash.rodata 204952 204952 0 0.0
.flash.text 913623 913659 36 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699560 699576 16 0.0
.bss 77808 77808 0 0.0
.data 1908 1908 0 0.0
.text 614044 614060 16 0.0
lock-app k32w061+debug (read/write) 592364 592396 32 0.0
.bss 68340 68340 0 0.0
.data 1876 1876 0 0.0
.text 516348 516380 32 0.0
shell k32w061+debug (read/write) 657860 657892 32 0.0
.bss 78980 78980 0 0.0
.data 1844 1844 0 0.0
.text 571236 571268 32 0.0
linux all-clusters-app debug (read only) 1704225 1704321 96 0.0
(read/write) 119232 119232 0 0.0
.bss 50608 50608 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62304 62304 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 139221 139221 0 0.0
.text 1431586 1431682 96 0.0
bridge-app debug+rpc (read only) 1292261 1292357 96 0.0
(read/write) 69808 69808 0 0.0
.bss 35536 35536 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27736 27736 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 111028 111028 0 0.0
.text 1085365 1085461 96 0.0
chip-tool debug (read only) 4931485 4931597 112 0.0
(read/write) 126664 126664 0 0.0
.bss 18736 18736 0 0.0
.data 2224 2224 0 0.0
.data.rel.ro 100288 100288 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 432 432 0 0.0
.rodata 233488 233488 0 0.0
.text 4429077 4429189 112 0.0
lighting-app debug+rpc (read only) 1553257 1553353 96 0.0
(read/write) 102776 102776 0 0.0
.bss 41176 41176 0 0.0
.data 1170 1170 0 0.0
.data.rel.ro 55136 55136 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 129649 129649 0 0.0
.text 1290050 1290146 96 0.0
ota-provider-app debug (read only) 1251465 1251561 96 0.0
(read/write) 67976 67976 0 0.0
.bss 37600 37600 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24536 24536 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112232 112232 0 0.0
.text 1043154 1043250 96 0.0
ota-requestor-app debug (read only) 1329761 1329857 96 0.0
(read/write) 77232 77232 0 0.0
.bss 45728 45728 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25544 25544 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 124208 124208 0 0.0
.text 1107522 1107618 96 0.0
shell debug (read only) 788041 788153 112 0.0
(read/write) 58184 58184 0 0.0
.bss 16648 16648 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36784 36784 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 77935 77935 0 0.0
.text 608642 608754 112 0.0
tv-app debug (read only) 1817233 1817329 96 0.0
(read/write) 290400 290400 0 0.0
.bss 223248 223248 0 0.0
.data 2704 2704 0 0.0
.data.rel.ro 58792 58792 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155304 155304 0 0.0
.text 1519666 1519762 96 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2291640 2291544 -96 -0.0
.bss 178924 178924 0 0.0
.data 5224 5224 0 0.0
.heap 852296 852296 0 0.0
.text 1254240 1254144 -96 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2271800 2271640 -160 -0.0
.bss 171980 171980 0 0.0
.data 5576 5576 0 0.0
.heap 858888 858888 0 0.0
.text 1234400 1234240 -160 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2249456 2249360 -96 -0.0
.bss 170876 170876 0 0.0
.data 5560 5560 0 0.0
.heap 860008 860008 0 0.0
.text 1212056 1211960 -96 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048912 2048760 -152 -0.0
.bss 156256 156256 0 0.0
.data 4968 4968 0 0.0
.heap 875224 875224 0 0.0
.text 1011512 1011360 -152 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861635 861667 32 0.0
bss 111280 111280 0 0.0
rodata 96932 96932 0 0.0
text 577804 577836 32 0.0
nrf52840dk_nrf52840+rpc (read/write) 823983 824015 32 0.0
bss 107632 107632 0 0.0
rodata 88112 88112 0 0.0
text 551952 551984 32 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786678 786710 32 0.0
bss 112652 112652 0 0.0
rodata 92192 92192 0 0.0
text 507264 507296 32 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838359 838391 32 0.0
bss 110312 110312 0 0.0
rodata 93304 93304 0 0.0
text 559284 559316 32 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763654 763686 32 0.0
bss 111724 111724 0 0.0
rodata 88608 88608 0 0.0
text 488836 488868 32 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844451 844483 32 0.0
bss 110452 110452 0 0.0
rodata 95012 95012 0 0.0
text 563448 563480 32 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838215 838247 32 0.0
bss 110348 110348 0 0.0
rodata 93304 93304 0 0.0
text 559020 559052 32 0.0
shell nrf52840dk_nrf52840 (read/write) 776231 776263 32 0.0
bss 109100 109100 0 0.0
rodata 72540 72540 0 0.0
text 519988 520016 28 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691270 691302 32 0.0
bss 110084 110084 0 0.0
rodata 67184 67184 0 0.0
text 440584 440612 28 0.0
p6 all-clusters-app default (read/write) 2301136 2301168 32 0.0
.bss 106872 106872 0 0.0
.data 2528 2528 0 0.0
.heap 923944 923944 0 0.0
.text 1259400 1259432 32 0.0
lock-app default (read/write) 2213848 2213880 32 0.0
.bss 95680 95680 0 0.0
.data 2400 2400 0 0.0
.heap 935264 935264 0 0.0
.text 1172112 1172144 32 0.0
qpg lighting-app qpg6100+debug (read only) 490896 490920 24 0.0
(read/write) 114144 114144 0 0.0
.bss 50968 50968 0 0.0
.data 1008 1008 0 0.0
.text 485576 485600 24 0.0
lock-app qpg6100+debug (read only) 467236 467268 32 0.0
(read/write) 114140 114140 0 0.0
.bss 49912 49912 0 0.0
.data 964 964 0 0.0
.text 461916 461948 32 0.0
persistent-storage-app qpg6100+debug (read only) 153316 153340 24 0.0
(read/write) 114144 114144 0 0.0
.bss 19448 19448 0 0.0
.data 360 360 0 0.0
.text 147996 148020 24 0.0
telink lighting-app tlsr9518adk80d (read/write) 663242 663266 24 0.0
bss 69092 69092 0 0.0
noinit 33216 33216 0 0.0
text 458250 458274 24 0.0

@andy31415 andy31415 merged commit 384f370 into project-chip:master Nov 8, 2021
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@markus-becker-tridonic-com
Use null-terminated SerialNumber (project-chip#11462)
8e03698 
* Aligned with FirmwareRevisionString, ProductionRevisionString, ProductName, VendorName
 which are also null-terminated
* Adapt SerialNumber test accordingly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jelderton jelderton jelderton approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@emargolis emargolis Awaiting requested review from emargolis

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

Assignees
No one assigned
Labels
app examples linux platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@markus-becker-tridonic-com @emargolis @jelderton @bzbarsky-apple @andy31415