-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use serial number and manufacturing date in Basic Cluster #10706
Use serial number and manufacturing date in Basic Cluster #10706
Conversation
PR #10706: Size comparison from 1c0ded5 to 36b02a4 20 builds (for efr32, k32w, linux, p6, qpg, telink)
2 builds (for mbed)
12 builds (for esp32, nrfconnect)
|
at least partially fixes #10698 |
Fast tracking pending CI, given enough time for review has passed |
36b02a4
to
f3e6b4a
Compare
rebased. conflicts resolved. tested on nrf52840dk:
using NV information written into internal flash, which gets picked up by ConfigurationMgr. |
PR #10706: Size comparison from 3249310 to d398014 Increases (26 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (36 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Size increase report for "gn_qpg-example-build" from 3249310
Full report output
|
Size increase report for "esp32-example-build" from 3249310
Full report output
|
/rebase |
d398014
to
9ee9dd6
Compare
9ee9dd6
to
f8133a4
Compare
PR #10706: Size comparison from 837bd28 to f8133a4 Increases (26 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (36 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs clarity on the null-termination bits.
PR #10706: Size comparison from 30e1b97 to d43cec4 Increases (7 builds for esp32, p6, qpg, telink)
Full report (8 builds for esp32, p6, qpg, telink)
|
d43cec4
to
7589aa9
Compare
7589aa9
to
3dfb5e9
Compare
PR #10706: Size comparison from 125ad20 to 3dfb5e9 Increases (7 builds for esp32, p6, qpg, telink)
Full report (8 builds for esp32, p6, qpg, telink)
|
63bc0b0
to
b41c597
Compare
PR #10706: Size comparison from d45cfaa to b41c597 Increases (25 builds for efr32, esp32, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (35 builds for efr32, esp32, linux, mbed, nrfconnect, p6, qpg, telink)
|
b41c597
to
e2c1ed2
Compare
PR #10706: Size comparison from d45cfaa to e2c1ed2 Increases (28 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
c18d04c
to
91292bb
Compare
c66d361
to
e735532
Compare
Basic Cluster is usually using the values from the zap file. This means that all devices will have the same Serial Number and ManufacturingDate. At least Serial Number and Manufacturing Date should be taken from ConfigurationMgr. Also: * Use descriptive values for char arrays in basic cluster. * Fix-up software and hardware version to match names in specification. Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
e735532
to
1b1d6f2
Compare
PR #10706: Size comparison from 4bb1e67 to 1b1d6f2 Increases (28 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (3 builds for mbed, nrfconnect)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
PR #10706: Size comparison from beb6096 to 2895b29 Increases (25 builds for efr32, esp32, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (3 builds for mbed, nrfconnect)
Full report (35 builds for efr32, esp32, linux, mbed, nrfconnect, p6, qpg, telink)
|
Rebased once more. The failed build on K32W seems to be an intermittent git problem. |
Problem
Basic Cluster is using the values from the zap file.
At least Serial Number and Manufacturing Date should be taken from
ConfigurationMgr.
Change overview
Serial Number and Manufacturing Date should be taken from
ConfigurationMgr.
Testing
Using TE6 TC_DM_1_1 on Nordic.
INFO | 2021-10-20 12:57:49.004 | Executing Test Step: Query SerialNumber
CHIPTOOL | 2021-10-20 12:57:49.005 | [1634734661.102947][20:30] CHIP:TOO: ***** Test Step 15 : Query SerialNumber
CHIPTOOL | 2021-10-20 12:57:49.006 |
CHIPTOOL | 2021-10-20 12:57:49.007 | [1634734661.103017][20:30] CHIP:DMG: SendReadRequest: Client[1] [ INIT]
CHIPTOOL | 2021-10-20 12:57:49.010 | [1634734661.103147][20:30] CHIP:IN: Secure message was encrypted: Msg ID 29
CHIPTOOL | 2021-10-20 12:57:49.012 | [1634734661.103173][20:30] CHIP:IN: Build encrypted message 0xaaab0981d9d8 to 0x2D26F007A42D7373 of type 2 and protocolId 1 on exchange 51640r with MessageCounter 29.
CHIPTOOL | 2021-10-20 12:57:49.013 | [1634734661.103196][20:30] CHIP:IN: Sending encrypted msg 0xaaab0981d9d8 to 0x2D26F007A42D7373 at utc time: 7943668 msec
CHIPTOOL | 2021-10-20 12:57:49.014 | [1634734661.103210][20:30] CHIP:IN: Sending msg on generic transport
CHIPTOOL | 2021-10-20 12:57:49.016 | [1634734661.103383][20:30] CHIP:DMG: Client[1] moving to [AwaitingInitialReport]
CHIPTOOL | 2021-10-20 12:57:49.017 | [1634734661.103451][20:30] CHIP:EM: Piggybacking Ack for MessageCounter:00000021 on exchange: 51639i
CHIPTOOL | 2021-10-20 12:57:49.018 | [1634734661.103500][20:30] CHIP:IN: Secure message was encrypted: Msg ID 30
CHIPTOOL | 2021-10-20 12:57:49.020 | [1634734661.103515][20:30] CHIP:IN: Build encrypted message 0xaaab0981d9f0 to 0x2D26F007A42D7373 of type 1 and protocolId 1 on exchange 51639r with MessageCounter 30.
CHIPTOOL | 2021-10-20 12:57:49.022 | [1634734661.103533][20:30] CHIP:IN: Sending encrypted msg 0xaaab0981d9f0 to 0x2D26F007A42D7373 at utc time: 7943668 msec
CHIPTOOL | 2021-10-20 12:57:49.023 | [1634734661.103546][20:30] CHIP:IN: Sending msg on generic transport
CHIPTOOL | 2021-10-20 12:57:49.024 | [1634734661.103644][20:30] CHIP:DMG: Client[0] moving to [UNINIT]
CHIPTOOL | 2021-10-20 12:57:49.025 | [1634734661.103816][20:30] CHIP:EM: Received message of type 0x10 with vendorId 0x0000 and protocolId 0x0000 on exchange 51638i
CHIPTOOL | 2021-10-20 12:57:49.027 | [1634734661.103852][20:30] CHIP:EM: Rxd Ack; Removing MessageCounter:0000001C from Retrans Table
CHIPTOOL | 2021-10-20 12:57:49.028 | [1634734661.103865][20:30] CHIP:EM: Removed CHIP MessageCounter:0000001C from RetransTable
CHIPTOOL | 2021-10-20 12:57:49.029 | [1634734661.184110][20:30] CHIP:EM: Received message of type 0x10 with vendorId 0x0000 and protocolId 0x0000 on exchange 51640i
CHIPTOOL | 2021-10-20 12:57:49.031 | [1634734661.184259][20:30] CHIP:EM: Rxd Ack; Removing MessageCounter:0000001D from Retrans Table
CHIPTOOL | 2021-10-20 12:57:49.032 | [1634734661.184295][20:30] CHIP:EM: Removed CHIP MessageCounter:0000001D from RetransTable
CHIPTOOL | 2021-10-20 12:57:49.034 | [1634734661.245554][20:30] CHIP:EM: Received message of type 0x05 with vendorId 0x0000 and protocolId 0x0001 on exchange 51640i
CHIPTOOL | 2021-10-20 12:57:49.035 | [1634734661.245685][20:30] CHIP:DMG: ReportData =
CHIPTOOL | 2021-10-20 12:57:49.036 | [1634734661.245734][20:30] CHIP:DMG: {
CHIPTOOL | 2021-10-20 12:57:49.038 | [1634734661.245765][20:30] CHIP:DMG: AttributeDataList =
CHIPTOOL | 2021-10-20 12:57:49.039 | [1634734661.245799][20:30] CHIP:DMG: [
CHIPTOOL | 2021-10-20 12:57:49.041 | [1634734661.245830][20:30] CHIP:DMG: AttributeDataElement =
CHIPTOOL | 2021-10-20 12:57:49.042 | [1634734661.245864][20:30] CHIP:DMG: {
CHIPTOOL | 2021-10-20 12:57:49.044 | [1634734661.245896][20:30] CHIP:DMG: AttributePath =
CHIPTOOL | 2021-10-20 12:57:49.045 | [1634734661.245931][20:30] CHIP:DMG: {
CHIPTOOL | 2021-10-20 12:57:49.049 | [1634734661.245966][20:30] CHIP:DMG: NodeId = 0x2d26f007a42d7373,
CHIPTOOL | 2021-10-20 12:57:49.050 | [1634734661.246001][20:30] CHIP:DMG: EndpointId = 0x0,
CHIPTOOL | 2021-10-20 12:57:49.052 | [1634734661.246034][20:30] CHIP:DMG: ClusterId = 0x28,
CHIPTOOL | 2021-10-20 12:57:49.054 | [1634734661.246068][20:30] CHIP:DMG: FieldTag = 0xf,
CHIPTOOL | 2021-10-20 12:57:49.055 | [1634734661.246098][20:30] CHIP:DMG: }
CHIPTOOL | 2021-10-20 12:57:49.056 | [1634734661.246141][20:30] CHIP:DMG:
CHIPTOOL | 2021-10-20 12:57:49.058 | [1634734661.246182][20:30] CHIP:DMG: Data = "12342222",
CHIPTOOL | 2021-10-20 12:57:49.059 | [1634734661.246217][20:30] CHIP:DMG: DataElementVersion = 0x0,
CHIPTOOL | 2021-10-20 12:57:49.060 | [1634734661.246246][20:30] CHIP:DMG: },
CHIPTOOL | 2021-10-20 12:57:49.061 | [1634734661.246286][20:30] CHIP:DMG:
CHIPTOOL | 2021-10-20 12:57:49.062 | [1634734661.246315][20:30] CHIP:DMG: ],
CHIPTOOL | 2021-10-20 12:57:49.064 | [1634734661.246357][20:30] CHIP:DMG:
CHIPTOOL | 2021-10-20 12:57:49.066 | [1634734661.246386][20:30] CHIP:DMG: }
CHIPTOOL | 2021-10-20 12:57:49.067 | [1634734661.246524][20:30] CHIP:ZCL: ReadAttributesResponse:
CHIPTOOL | 2021-10-20 12:57:49.068 | [1634734661.246571][20:30] CHIP:ZCL: ClusterId: 0x0000_0028
CHIPTOOL | 2021-10-20 12:57:49.070 | [1634734661.246608][20:30] CHIP:ZCL: attributeId: 0x0000_000F
CHIPTOOL | 2021-10-20 12:57:49.071 | [1634734661.246639][20:30] CHIP:ZCL: status: Success (0x0000)
CHIPTOOL | 2021-10-20 12:57:49.073 | [1634734661.246667][20:30] CHIP:ZCL: attribute TLV Type: 0x0c
CHIPTOOL | 2021-10-20 12:57:49.074 | [1634734661.246700][20:30] CHIP:TOO: Warning: serialNumber type checking is not implemented yet. Expected type: 'string'
CHIPTOOL | 2021-10-20 12:57:49.076 | [1634734661.246733][20:30] CHIP:TOO: ***** Testing paused for: 500ms
INFO | 2021-10-20 12:57:48.683 | Executing Test Step: Query ManufacturingDate
CHIPTOOL | 2021-10-20 12:57:48.685 | [1634734658.602732][20:30] CHIP:TOO: ***** Test Step 11 : Query ManufacturingDate
CHIPTOOL | 2021-10-20 12:57:48.686 |
CHIPTOOL | 2021-10-20 12:57:48.687 | [1634734658.602835][20:30] CHIP:DMG: SendReadRequest: Client[1] [ INIT]
CHIPTOOL | 2021-10-20 12:57:48.688 | [1634734658.603029][20:30] CHIP:IN: Secure message was encrypted: Msg ID 21
CHIPTOOL | 2021-10-20 12:57:48.690 | [1634734658.603089][20:30] CHIP:IN: Build encrypted message 0xaaab0981d9d8 to 0x2D26F007A42D7373 of type 2 and protocolId 1 on exchange 51636r with MessageCounter 21.
CHIPTOOL | 2021-10-20 12:57:48.691 | [1634734658.603139][20:30] CHIP:IN: Sending encrypted msg 0xaaab0981d9d8 to 0x2D26F007A42D7373 at utc time: 79434186 msec
CHIPTOOL | 2021-10-20 12:57:48.693 | [1634734658.603178][20:30] CHIP:IN: Sending msg on generic transport
CHIPTOOL | 2021-10-20 12:57:48.694 | [1634734658.603438][20:30] CHIP:DMG: Client[1] moving to [AwaitingInitialReport]
CHIPTOOL | 2021-10-20 12:57:48.695 | [1634734658.603556][20:30] CHIP:EM: Piggybacking Ack for MessageCounter:00000017 on exchange: 51635i
CHIPTOOL | 2021-10-20 12:57:48.697 | [1634734658.603647][20:30] CHIP:IN: Secure message was encrypted: Msg ID 22
CHIPTOOL | 2021-10-20 12:57:48.698 | [1634734658.603683][20:30] CHIP:IN: Build encrypted message 0xaaab0981d9f0 to 0x2D26F007A42D7373 of type 1 and protocolId 1 on exchange 51635r with MessageCounter 22.
CHIPTOOL | 2021-10-20 12:57:48.699 | [1634734658.603725][20:30] CHIP:IN: Sending encrypted msg 0xaaab0981d9f0 to 0x2D26F007A42D7373 at utc time: 79434187 msec
CHIPTOOL | 2021-10-20 12:57:48.700 | [1634734658.603758][20:30] CHIP:IN: Sending msg on generic transport
CHIPTOOL | 2021-10-20 12:57:48.702 | [1634734658.603952][20:30] CHIP:DMG: Client[0] moving to [UNINIT]
CHIPTOOL | 2021-10-20 12:57:48.704 | [1634734658.604452][20:30] CHIP:EM: Received message of type 0x10 with vendorId 0x0000 and protocolId 0x0000 on exchange 51634i
CHIPTOOL | 2021-10-20 12:57:48.705 | [1634734658.604547][20:30] CHIP:EM: Rxd Ack; Removing MessageCounter:00000014 from Retrans Table
CHIPTOOL | 2021-10-20 12:57:48.706 | [1634734658.604584][20:30] CHIP:EM: Removed CHIP MessageCounter:00000014 from RetransTable
CHIPTOOL | 2021-10-20 12:57:48.708 | [1634734658.686290][20:30] CHIP:EM: Received message of type 0x10 with vendorId 0x0000 and protocolId 0x0000 on exchange 51636i
CHIPTOOL | 2021-10-20 12:57:48.709 | [1634734658.686353][20:30] CHIP:EM: Rxd Ack; Removing MessageCounter:00000015 from Retrans Table
CHIPTOOL | 2021-10-20 12:57:48.710 | [1634734658.686368][20:30] CHIP:EM: Removed CHIP MessageCounter:00000015 from RetransTable
CHIPTOOL | 2021-10-20 12:57:48.711 | [1634734658.748211][20:30] CHIP:EM: Received message of type 0x05 with vendorId 0x0000 and protocolId 0x0001 on exchange 51636i
CHIPTOOL | 2021-10-20 12:57:48.716 | [1634734658.748347][20:30] CHIP:DMG: ReportData =
CHIPTOOL | 2021-10-20 12:57:48.718 | [1634734658.748391][20:30] CHIP:DMG: {
CHIPTOOL | 2021-10-20 12:57:48.719 | [1634734658.748421][20:30] CHIP:DMG: AttributeDataList =
CHIPTOOL | 2021-10-20 12:57:48.720 | [1634734658.748456][20:30] CHIP:DMG: [
CHIPTOOL | 2021-10-20 12:57:48.721 | [1634734658.748488][20:30] CHIP:DMG: AttributeDataElement =
CHIPTOOL | 2021-10-20 12:57:48.722 | [1634734658.748523][20:30] CHIP:DMG: {
CHIPTOOL | 2021-10-20 12:57:48.724 | [1634734658.748555][20:30] CHIP:DMG: AttributePath =
CHIPTOOL | 2021-10-20 12:57:48.726 | [1634734658.748590][20:30] CHIP:DMG: {
CHIPTOOL | 2021-10-20 12:57:48.728 | [1634734658.748626][20:30] CHIP:DMG: NodeId = 0x2d26f007a42d7373,
CHIPTOOL | 2021-10-20 12:57:48.729 | [1634734658.748662][20:30] CHIP:DMG: EndpointId = 0x0,
CHIPTOOL | 2021-10-20 12:57:48.731 | [1634734658.748695][20:30] CHIP:DMG: ClusterId = 0x28,
CHIPTOOL | 2021-10-20 12:57:48.732 | [1634734658.748728][20:30] CHIP:DMG: FieldTag = 0xb,
CHIPTOOL | 2021-10-20 12:57:48.733 | [1634734658.748758][20:30] CHIP:DMG: }
CHIPTOOL | 2021-10-20 12:57:48.734 | [1634734658.748800][20:30] CHIP:DMG:
CHIPTOOL | 2021-10-20 12:57:48.737 | [1634734658.748841][20:30] CHIP:DMG: Data = "2020-10-19",
CHIPTOOL | 2021-10-20 12:57:48.739 | [1634734658.748874][20:30] CHIP:DMG: DataElementVersion = 0x0,
CHIPTOOL | 2021-10-20 12:57:48.740 | [1634734658.748905][20:30] CHIP:DMG: },
CHIPTOOL | 2021-10-20 12:57:48.741 | [1634734658.748947][20:30] CHIP:DMG:
CHIPTOOL | 2021-10-20 12:57:48.742 | [1634734658.748977][20:30] CHIP:DMG: ],
CHIPTOOL | 2021-10-20 12:57:48.744 | [1634734658.749021][20:30] CHIP:DMG:
CHIPTOOL | 2021-10-20 12:57:48.745 | [1634734658.749050][20:30] CHIP:DMG: }
CHIPTOOL | 2021-10-20 12:57:48.746 | [1634734658.749188][20:30] CHIP:ZCL: ReadAttributesResponse:
CHIPTOOL | 2021-10-20 12:57:48.750 | [1634734658.749221][20:30] CHIP:ZCL: ClusterId: 0x0000_0028
CHIPTOOL | 2021-10-20 12:57:48.751 | [1634734658.749256][20:30] CHIP:ZCL: attributeId: 0x0000_000B
CHIPTOOL | 2021-10-20 12:57:48.752 | [1634734658.749285][20:30] CHIP:ZCL: status: Success (0x0000)
CHIPTOOL | 2021-10-20 12:57:48.754 | [1634734658.749313][20:30] CHIP:ZCL: attribute TLV Type: 0x0c
CHIPTOOL | 2021-10-20 12:57:48.755 | [1634734658.749344][20:30] CHIP:TOO: Warning: manufacturingDate type checking is not implemented yet. Expected type: 'string'
CHIPTOOL | 2021-10-20 12:57:48.756 | [1634734658.749372][20:30] CHIP:TOO: Warning: manufacturingDate format checking is not implemented yet. Expected format: 'ISO 8601'
CHIPTOOL | 2021-10-20 12:57:48.757 | [1634734658.749402][20:30] CHIP:TOO: ***** Testing paused for: 500ms
CHIPTOOL | 2021-10-20 12:57:48.759 |
INFO | 2021-10-20 12:57:48.761 | Test Step Completed [PASSED]: Query ManufacturingDate