-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix chip-tool logging to work for various interesting data types. #11404
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:chip-tool-logging
Nov 4, 2021
Merged
Fix chip-tool logging to work for various interesting data types. #11404
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:chip-tool-logging
Nov 4, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux and
tecimovic
November 4, 2021 01:14
PR #11404: Size comparison from ee7682d to adf39a0 Increases above 0.2%:
Increases (1 build for linux)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
chip-tool-logging
branch
from
November 4, 2021 03:22
adf39a0
to
6370198
Compare
PR #11404: Size comparison from ee7682d to 6370198 Increases above 0.2%:
Increases (1 build for linux)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
woody-apple
approved these changes
Nov 4, 2021
Fast tracking, given this is adding logging for testing. |
/rebase |
bzbarsky-apple
force-pushed
the
chip-tool-logging
branch
from
November 4, 2021 14:25
6370198
to
eeb94af
Compare
PR #11404: Size comparison from 1538bbb to eeb94af Increases above 0.2%:
Increases (1 build for linux)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
/rebase |
Optional values, nullable types, etc, etc. Fixes project-chip#11214 Fixes project-chip#11215
woody-apple
force-pushed
the
chip-tool-logging
branch
from
November 4, 2021 19:06
eeb94af
to
685df67
Compare
PR #11404: Size comparison from 29747a2 to 685df67 Increases above 0.2%:
Increases (1 build for linux)
Decreases (1 build for esp32)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
…oject-chip#11404) Optional values, nullable types, etc, etc. Fixes project-chip#11214 Fixes project-chip#11215
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optional values, nullable types, etc, etc.
Fixes #11214
Fixes #11215
Problem
Command-line chip-tool received value logging can't handle all values: has trouble with structs and lists when they're nested deeply..
Change overview
Use helper functions to implement logging of arbitrary-nesting data structures.
Testing
Manually ran some chip-tool commands and observed the output.