Auto-Deduce Invoke Response Type #10933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This modifies the existing ChipDeviceController.SendCommand() Python API to automatically deduce the cluster object type associated with the response and automatically return that to the caller after successfully deserializing the TLV into that object. This avoids callers having to explicitly pass in an object, making it that much easier to use. Tests: Tested using cluster_objects.py, as well as manually sending/receiving commands at the Python shell.
mrjerryjohns
force-pushed
the
python/auto-invoke-resp
branch
from
b11b11e
to
5f70318
Compare
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
emargolis,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
mlepage-google,
msandstedt,
mspang,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst and
tcarmelveilleux
pullapprove
bot
requested review from
tecimovic,
vivien-apple,
wbschiller,
woody-apple and
yufengwangca
|
PR #10933: Size comparison from 93fef33 to 2eb199b 8 builds (for k32w, p6, qpg, telink)
12 builds (for efr32, linux)
4 builds (for mbed)
12 builds (for esp32, nrfconnect)
|
msandstedt
approved these changes
Oct 26, 2021
yunhanw-google
approved these changes
Oct 26, 2021
andy31415
approved these changes
Oct 26, 2021
|
PR #10933: Size comparison from aea917b to 65719dc Full report (36 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
woody-apple
approved these changes
Oct 27, 2021
|
PR #10933: Size comparison from 30fd6f9 to 5a07ecd Full report (36 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
JasonLiuZhuoCheng
pushed a commit
to JasonLiuZhuoCheng/connectedhomeip
that referenced
this pull request
Oct 28, 2021
* Auto-Deduce Invoke Response Type This modifies the existing ChipDeviceController.SendCommand() Python API to automatically deduce the cluster object type associated with the response and automatically return that to the caller after successfully deserializing the TLV into that object. This avoids callers having to explicitly pass in an object, making it that much easier to use. Tests: Tested using cluster_objects.py, as well as manually sending/receiving commands at the Python shell. * Fix test case * Restyle Co-authored-by: Song Guo <songguo@google.com>
carol-apple
pushed a commit
to carol-apple/connectedhomeip
that referenced
this pull request
Oct 28, 2021
* Auto-Deduce Invoke Response Type This modifies the existing ChipDeviceController.SendCommand() Python API to automatically deduce the cluster object type associated with the response and automatically return that to the caller after successfully deserializing the TLV into that object. This avoids callers having to explicitly pass in an object, making it that much easier to use. Tests: Tested using cluster_objects.py, as well as manually sending/receiving commands at the Python shell. * Fix test case * Restyle Co-authored-by: Song Guo <songguo@google.com>
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
* Auto-Deduce Invoke Response Type This modifies the existing ChipDeviceController.SendCommand() Python API to automatically deduce the cluster object type associated with the response and automatically return that to the caller after successfully deserializing the TLV into that object. This avoids callers having to explicitly pass in an object, making it that much easier to use. Tests: Tested using cluster_objects.py, as well as manually sending/receiving commands at the Python shell. * Fix test case * Restyle Co-authored-by: Song Guo <songguo@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the existing
ChipDeviceController.SendCommand()Python APIto automatically deduce the cluster object type associated with the response and return that to the caller after successfully deserializing the TLV into that object.
This avoids callers having to explicitly pass in an object, making it that much easier to use.
Other changes:
Tests: Tested using cluster_objects.py, as well as manually
sending/receiving commands at the Python shell.