Skip to content

Commit

Permalink
* Fix 64-bit prints mDNS code for nano libprintf (#6420)
Browse files Browse the repository at this point in the history
  • Loading branch information
tima-q authored and pull[bot] committed Jun 13, 2021
1 parent 0043236 commit 1306568
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 6 deletions.
12 changes: 8 additions & 4 deletions src/app/server/Mdns.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,9 @@ NodeId GetCurrentNodeId()
auto pairing = GetGlobalAdminPairingTable().cbegin();
if (pairing != GetGlobalAdminPairingTable().cend())
{
ChipLogProgress(Discovery, "Found admin paring for admin %" PRIX16 ", node %" PRIX64, pairing->GetAdminId(),
pairing->GetNodeId());
ChipLogProgress(Discovery, "Found admin paring for admin %" PRIX16 ", node 0x%08" PRIx32 "%08" PRIx32,
pairing->GetAdminId(), static_cast<uint32_t>(pairing->GetNodeId() >> 32),
static_cast<uint32_t>(pairing->GetNodeId()));
return pairing->GetNodeId();
}

Expand Down Expand Up @@ -105,8 +106,11 @@ CHIP_ERROR AdvertiseOperational()

auto & mdnsAdvertiser = chip::Mdns::ServiceAdvertiser::Instance();

ChipLogProgress(Discovery, "Advertise operational node %" PRIX64 "-%" PRIX64, advertiseParameters.GetPeerId().GetFabricId(),
advertiseParameters.GetPeerId().GetNodeId());
ChipLogProgress(Discovery, "Advertise operational node 0x%08" PRIx32 "%08" PRIx32 "-0x%08" PRIx32 "%08" PRIx32,
static_cast<uint32_t>(advertiseParameters.GetPeerId().GetFabricId() >> 32),
static_cast<uint32_t>(advertiseParameters.GetPeerId().GetFabricId()),
static_cast<uint32_t>(advertiseParameters.GetPeerId().GetNodeId() >> 32),
static_cast<uint32_t>(advertiseParameters.GetPeerId().GetNodeId()));
return mdnsAdvertiser.Advertise(advertiseParameters);
}

Expand Down
6 changes: 4 additions & 2 deletions src/lib/mdns/Discovery_ImplPlatform.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,8 @@ CHIP_ERROR DiscoveryImplPlatform::Advertise(const CommissionAdvertisingParameter

ReturnErrorOnFailure(SetupHostname(params.GetMac()));

snprintf(service.mName, sizeof(service.mName), "%016" PRIX64, mCommissionInstanceName);
snprintf(service.mName, sizeof(service.mName), "%08" PRIX32 "%08" PRIX32, static_cast<uint32_t>(mCommissionInstanceName >> 32),
static_cast<uint32_t>(mCommissionInstanceName));
if (params.GetCommissionAdvertiseMode() == CommssionAdvertiseMode::kCommissioning)
{
strncpy(service.mType, "_chipc", sizeof(service.mType));
Expand Down Expand Up @@ -374,7 +375,8 @@ void DiscoveryImplPlatform::HandleNodeIdResolve(void * context, MdnsService * re
nodeData.mAddress = result->mAddress.ValueOr({});
nodeData.mPort = result->mPort;

ChipLogProgress(Discovery, "Node ID resolved for %" PRIX64, nodeData.mPeerId.GetNodeId());
ChipLogProgress(Discovery, "Node ID resolved for 0x08%" PRIX32 "08%" PRIX32,
static_cast<uint32_t>(nodeData.mPeerId.GetNodeId() >> 32), static_cast<uint32_t>(nodeData.mPeerId.GetNodeId()));
mgr->mResolverDelegate->OnNodeIdResolved(nodeData);
}

Expand Down

0 comments on commit 1306568

Please sign in to comment.