[IM] Use DataModel::Encode in EncodeScalarAttributeWritePayload for complex types #10386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
Damian-Nordic,
emargolis,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
mlepage-google,
msandstedt,
pan-apple,
sagar-apple,
saurabhst,
shana-apple,
tcarmelveilleux,
vivien-apple,
woody-apple,
yufengwangca and
yunhanw-google
Damian-Nordic
approved these changes
Oct 11, 2021
yunhanw-google
approved these changes
Oct 11, 2021
saurabhst
approved these changes
Oct 11, 2021
erjiaqing
force-pushed
the
im/WriteClient-ClusterObject
branch
from
c989231
to
6ace986
Compare
bzbarsky-apple
approved these changes
Oct 12, 2021
There was a problem hiding this comment.
This is at least not wrong now, though I still think the compare should be against the actual data we meant to send (i.e. the string) not an intermediate representation (the CharSpan), if it's possible....
By the way it might be worth using CharSpan instead of Span in general....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Need to support writing complex types.
Change overview
Testing