Update test

project-chip · Oct 12, 2021 · c989231 · c989231
1 parent 45e6bae
commit c989231
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/src/app/tests/TestWriteInteraction.cpp b/src/app/tests/TestWriteInteraction.cpp
@@ -317,14 +317,15 @@ void TestWriteInteraction::TestWriteRoundtripWithClusterObjects(nlTestSuite * ap
     attributePathParams.mFieldId    = 4;
     attributePathParams.mFlags.Set(AttributePathParams::Flags::kFieldIdValid);
 
-    uint8_t byteSpanData[] = { 0xde, 0xad, 0xbe, 0xef };
-    char charSpanData[]    = "a simple test string";
+    const uint8_t byteSpanData[] = { 0xde, 0xad, 0xbe, 0xef };
+    const char charSpanData[]    = "a simple test string";
 
     app::Clusters::TestCluster::SimpleStruct::Type dataTx;
     dataTx.a = 12;
     dataTx.b = true;
-    dataTx.d = chip::ByteSpan(byteSpanData, sizeof(byteSpanData));
-    dataTx.e = chip::Span<const char>(charSpanData, sizeof(charSpanData));
+    dataTx.d = chip::ByteSpan(byteSpanData);
+    // Spec A.11.2 strings SHALL NOT include a terminating null character to mark the end of a string.
+    dataTx.e = chip::Span<const char>(charSpanData, strlen(charSpanData));
 
     writeClient.EncodeAttributeWritePayload(attributePathParams, dataTx);
     NL_TEST_ASSERT(apSuite, err == CHIP_NO_ERROR);
@@ -347,6 +348,7 @@ void TestWriteInteraction::TestWriteRoundtripWithClusterObjects(nlTestSuite * ap
         NL_TEST_ASSERT(apSuite, dataRx.a == dataTx.a);
         NL_TEST_ASSERT(apSuite, dataRx.b == dataTx.b);
         NL_TEST_ASSERT(apSuite, dataRx.d.data_equal(dataTx.d));
+        // Equals to dataRx.e.size() == dataTx.e.size() && memncmp(dataRx.e.data(), dataTx.e.data(), dataTx.e.size()) == 0
         NL_TEST_ASSERT(apSuite, dataRx.e.data_equal(dataTx.e));
     }