Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#7112) support location param and verify length once CHAR_STRING is supported #9798

Closed
todo bot opened this issue Sep 17, 2021 · 0 comments · Fixed by #10745
Closed

(#7112) support location param and verify length once CHAR_STRING is supported #9798

todo bot opened this issue Sep 17, 2021 · 0 comments · Fixed by #10745
Assignees
Labels

Comments

@todo
Copy link

todo bot commented Sep 17, 2021

// TODO: (#7112) support location param and verify length once CHAR_STRING is supported
// Using location parameter is blocked by #5542 (use Span for string arguments). For now, there is no way to safely get the
// length of the location string because it is not guaranteed to be null-terminated.
Span<const char> locationSpan;
if (metadataForProvider.size() > kMaxMetadataLen)
{
ChipLogError(Zcl, "metadata size %zu exceeds max %zu", metadataForProvider.size(), kMaxMetadataLen);
emberAfSendImmediateDefaultResponse(EMBER_ZCL_STATUS_INVALID_ARGUMENT);
}


This issue was generated by todo based on a TODO comment in 3212882. It's been assigned to @holbrookt because they committed the code.
@todo todo bot added the todo label Sep 17, 2021
@todo todo bot assigned holbrookt Sep 17, 2021
woody-apple pushed a commit that referenced this issue Oct 21, 2021
…ING (#10745)

* Fix various OCTET_STRING bits that should be CHAR_STRING.

Fixes #5542
Fixes #6112
Fixes #7112
Fixes #7322
Fixes #7654
Fixes #7655
Fixes #8704
Fixes #8705
Fixes #8706
Fixes #8707
Fixes #9797
Fixes #9798
Fixes #10508
Fixes #10509

* Regenerate generated files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant