Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Label once CHAR_STRING or OCTET_STRING works #7322

Closed
todo bot opened this issue Jun 2, 2021 · 0 comments · Fixed by #10745
Closed

Add Label once CHAR_STRING or OCTET_STRING works #7322

todo bot opened this issue Jun 2, 2021 · 0 comments · Fixed by #10745
Assignees
@shana-apple
Labels
todo

Comments

@todo
Copy link

todo bot commented Jun 2, 2021

connectedhomeip/src/app/zap-templates/zcl/custom-types.xml

Lines 61 to 64 in 18e34fa

<item name="Label" type="OCTET_STRING" length="32"/>// TODO: Add Label once CHAR_STRING or OCTET_STRING works
</struct>
<struct name="TestListStructOctet">
<item name="fabricIndex" type="INT64U"/>

This issue was generated by todo based on a TODO comment in 18e34fa when #6670 was merged. cc @shana-apple.
@todo todo bot added the todo label Jun 2, 2021
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Oct 21, 2021
@bzbarsky-apple
Fix various OCTET_STRING bits that should be CHAR_STRING.
c1e81de 
Fixes project-chip#5542
Fixes project-chip#6112
Fixes project-chip#7112
Fixes project-chip#7322
Fixes project-chip#7654
Fixes project-chip#7655
Fixes project-chip#8704
Fixes project-chip#8705
Fixes project-chip#8706
Fixes project-chip#8707
Fixes project-chip#9797
Fixes project-chip#9798
Fixes project-chip#10508
Fixes project-chip#10509
@bzbarsky-apple bzbarsky-apple mentioned this issue Oct 21, 2021
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Oct 21, 2021
@bzbarsky-apple
Fix various OCTET_STRING bits that should be CHAR_STRING.
e5276ea 
Fixes project-chip#5542
Fixes project-chip#6112
Fixes project-chip#7112
Fixes project-chip#7322
Fixes project-chip#7654
Fixes project-chip#7655
Fixes project-chip#8704
Fixes project-chip#8705
Fixes project-chip#8706
Fixes project-chip#8707
Fixes project-chip#9797
Fixes project-chip#9798
Fixes project-chip#10508
Fixes project-chip#10509
woody-apple pushed a commit that referenced this issue Oct 21, 2021
@bzbarsky-apple
Fix some places where we use OCTET_STRING when we should use CHAR_STR…
b7f98f7 
…ING (#10745)

* Fix various OCTET_STRING bits that should be CHAR_STRING.

Fixes #5542
Fixes #6112
Fixes #7112
Fixes #7322
Fixes #7654
Fixes #7655
Fixes #8704
Fixes #8705
Fixes #8706
Fixes #8707
Fixes #9797
Fixes #9798
Fixes #10508
Fixes #10509

* Regenerate generated files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shana-apple shana-apple

Labels
todo
Projects
None yet
Milestone
No milestone
1 participant
@shana-apple