Skip to content

Commit

Permalink
Make "reportable" setting consistent in zap file to avoid zap instabi…
Browse files Browse the repository at this point in the history
…lity. (#13632)

* Make tv casting labelList and clusterRevision consistently non-reportable (difference between client and server configs)

* More changes regarding reportable consistency on all clusters app.zap

* Two more stability updates for reportability

* After update, feature map is NOT reportable (which seems correct: it should not change at runtime)
  • Loading branch information
andy31415 authored and pull[bot] committed Jul 8, 2023
1 parent 793568b commit 1066730
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1808,7 +1808,7 @@ server cluster NetworkCommissioning = 49 {
attribute(readonly) NetworkCommissioningStatus lastNetworkingStatus = 5;
attribute(readonly) octet_string lastNetworkID = 6;
attribute(readonly) int32u lastConnectErrorValue = 7;
attribute(readonly, reportable) bitmap32 featureMap = 65532;
attribute(readonly) bitmap32 featureMap = 65532;
attribute(readonly, reportable) int16u clusterRevision = 65533;

request struct AddOrUpdateThreadNetworkRequest {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1973,7 +1973,7 @@
"singleton": 0,
"bounded": 0,
"defaultValue": "0x0001",
"reportable": 1,
"reportable": 0,
"minInterval": 0,
"maxInterval": 65344,
"reportableChange": 0
Expand Down Expand Up @@ -2159,7 +2159,7 @@
"singleton": 0,
"bounded": 0,
"defaultValue": "1",
"reportable": 1,
"reportable": 0,
"minInterval": 0,
"maxInterval": 65344,
"reportableChange": 0
Expand Down Expand Up @@ -9948,7 +9948,7 @@
"singleton": 0,
"bounded": 0,
"defaultValue": "0x0001",
"reportable": 1,
"reportable": 0,
"minInterval": 0,
"maxInterval": 65344,
"reportableChange": 0
Expand All @@ -9974,7 +9974,7 @@
"singleton": 0,
"bounded": 0,
"defaultValue": "",
"reportable": 1,
"reportable": 0,
"minInterval": 0,
"maxInterval": 65344,
"reportableChange": 0
Expand All @@ -9989,7 +9989,7 @@
"singleton": 0,
"bounded": 0,
"defaultValue": "0x0001",
"reportable": 1,
"reportable": 0,
"minInterval": 0,
"maxInterval": 65344,
"reportableChange": 0
Expand Down Expand Up @@ -13654,7 +13654,7 @@
"singleton": 0,
"bounded": 0,
"defaultValue": "0x0001",
"reportable": 1,
"reportable": 0,
"minInterval": 0,
"maxInterval": 65344,
"reportableChange": 0
Expand Down Expand Up @@ -20139,4 +20139,4 @@
"deviceIdentifier": 22
}
]
}
}
6 changes: 3 additions & 3 deletions examples/tv-casting-app/tv-casting-common/tv-casting-app.zap
Original file line number Diff line number Diff line change
Expand Up @@ -3448,7 +3448,7 @@
"singleton": 0,
"bounded": 0,
"defaultValue": "0x0001",
"reportable": 1,
"reportable": 0,
"minInterval": 0,
"maxInterval": 65344,
"reportableChange": 0
Expand Down Expand Up @@ -8886,7 +8886,7 @@
"singleton": 0,
"bounded": 0,
"defaultValue": "0x0001",
"reportable": 1,
"reportable": 0,
"minInterval": 0,
"maxInterval": 65344,
"reportableChange": 0
Expand All @@ -8912,7 +8912,7 @@
"singleton": 0,
"bounded": 0,
"defaultValue": "",
"reportable": 1,
"reportable": 0,
"minInterval": 0,
"maxInterval": 65344,
"reportableChange": 0
Expand Down

0 comments on commit 1066730

Please sign in to comment.