Skip to content

Translation-fix-AutocompleteHinter #2690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 15, 2023
Merged

Translation-fix-AutocompleteHinter #2690

merged 2 commits into from
Dec 15, 2023

Conversation

umangutkarsh
Copy link
Contributor

@umangutkarsh umangutkarsh commented Dec 5, 2023 •
edited
Loading

Fixes #2681
Addresses #2609 :

  • Preferences.AutocompleteHinter,
  • Preferences.AutocompleteHinterOnARIA,
  • Preferences.AutocompleteHinterOffARIA

Changes: 'AutocompleteHinter' translation error fix.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123
p5

@umangutkarsh
Copy link
Contributor Author

Linting and Testing done by running npm run lint and npm run test

@raclim raclim added this to the MINOR Release for 2.11.0 milestone Dec 5, 2023
@lindapaiste lindapaiste added Type:Task Tasks tied specifically to developer operations and maintenance Area: Translation For localization of the p5.js editor or contributor documentation labels Dec 5, 2023
@lindapaiste lindapaiste mentioned this pull request Dec 5, 2023
Merged
12 tasks
raclim
raclim approved these changes Dec 15, 2023
View reviewed changes
Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since @Swarnendu0123 vouched for this translation, I'm going to merge this in! Thanks so much for your work on this!

@raclim raclim merged commit d2267f4 into processing:develop Dec 15, 2023
@umangutkarsh
Copy link
Contributor Author

Since @Swarnendu0123 vouched for this translation, I'm going to merge this in! Thanks so much for your work on this!

Thank you for merging this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raclim raclim raclim approved these changes

Assignees
No one assigned
Labels
Area: Translation For localization of the p5.js editor or contributor documentation Type:Task Tasks tied specifically to developer operations and maintenance
Projects
None yet
Milestone
PATCH Release for 2.10.1
Development

Successfully merging this pull request may close these issues.

In the Hindi version of the p5.js web editor, there is an English text present.
3 participants
@umangutkarsh @raclim @lindapaiste