This repository was archived by the owner on Sep 6, 2019. It is now read-only.
Merged
Conversation
hiimbex
approved these changes
Oct 25, 2018
Contributor
hiimbex
left a comment
There was a problem hiding this comment.
Thanks for the PR @TimonVS! I'm gonna go ahead and merge, but as an FYI, there is work being done in probot/create-probot-app#36 + probot/probot#674 to re-work how create-probot-app works which will make this repo obsolete.
It will post this template into tempaltes/basic-ts, so feel free to PR that branch if there's anything the test I wrote in there doesn't reflect which this one does! :)
Contributor
Author
|
@hiimbex Thanks, good to know that it's being reworked! I'll check it out :) |
Contributor
|
The test in particular is here: https://github.com/probot/create-probot-app/pull/36/files#diff-5e27b297aa22294ff0126763d5fbce56! I used nock instead, but I think it gets at the same point!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copied over the example code from the JavaScript template and slightly modified it to be compatible with TypeScript.
The tests run successfully, but Standard fails with the following error:
This is just a heads up, I might solve this in a seperate PR :)
Fixes: #3