Conversation
hiimbex
changed the title
add deployments example
TimonVS
reviewed
Oct 25, 2018
Contributor
TimonVS
left a comment
TimonVS
left a comment
There was a problem hiding this comment.
Great stuff! I really like that the checks and Git data examples :).
Did a quick review and found some small spelling mistakes.
Co-Authored-By: hiimbex <bexmwarner@gmail.com>
Co-Authored-By: hiimbex <bexmwarner@gmail.com>
Co-Authored-By: hiimbex <bexmwarner@gmail.com>
Co-Authored-By: hiimbex <bexmwarner@gmail.com>
Co-Authored-By: hiimbex <bexmwarner@gmail.com>
Co-Authored-By: hiimbex <bexmwarner@gmail.com>
Co-Authored-By: hiimbex <bexmwarner@gmail.com>
Co-Authored-By: hiimbex <bexmwarner@gmail.com>
Co-Authored-By: hiimbex <bexmwarner@gmail.com>
Contributor
Author
|
Thanks @TimonVS!! Spelling is not my strong suit 😅 |
bkeepers
approved these changes
Oct 25, 2018
README.md
Outdated
| In particular, this command line interface allows you to select from our pre-defined blue prints to choose a basic working example to start from. | ||
|
|
||
| If you're using npm < 6: | ||
| ## Getting started with Blue Prints 🛠 |
Contributor
There was a problem hiding this comment.
I feel like these examples all make the README harder to grok. I would stick with just the single command, and let the prompts explain the blueprints.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In support of probot/probot#674, this PR aims to accomplish the goals of how the create-probot-app script will access the use case templates. It does so by referencing them locally, and will include them in the npm module.
Right now this PR also includes the code beginnings for several of the use case templates. I'll follow up with separate PRs to update those and add tests for all of them.