Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Docker builds and few improvements #1276

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

cberkhoff
Copy link
Collaborator

Right now, if you try to run a Docker image you will get this error:

/bin/ipa-helper: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by /bin/ipa-helper)
/bin/ipa-helper: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /bin/ipa-helper)
/bin/ipa-helper: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by /bin/ipa-helper)

We used to have one version to build and a different one to run which led to the aforementioned error.
Before this change we had 2 Docker files, which was very confusing. Now we only have one.

With this change I'm updating the Rust images to use a newer Debian as well as newer Docker Github actions.

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.52%. Comparing base (22a0a8b) to head (182e8e4).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1276      +/-   ##
==========================================
+ Coverage   92.49%   93.52%   +1.02%     
==========================================
  Files         201      202       +1     
  Lines       31995    32692     +697     
==========================================
+ Hits        29595    30574     +979     
+ Misses       2400     2118     -282     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@eriktaubeneck eriktaubeneck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for cleaning this up. makes sense to move from bullseye to bookworm, since bullseye is now in LTS.

@cberkhoff cberkhoff merged commit 2e0b697 into private-attribution:main Sep 13, 2024
12 checks passed
@akoshelev
Copy link
Collaborator

what's the size of the image after this change? Just want to make sure rust repo does not pull anything extra that leads to increase

@cberkhoff
Copy link
Collaborator Author

It's 43.5MB. I think it was 48 so it came down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants