Skip to content

Commit

Permalink
Merge pull request #1276 from cberkhoff/main-upgrade
Browse files Browse the repository at this point in the history
Fixing Docker builds and few improvements
  • Loading branch information
cberkhoff authored Sep 13, 2024
2 parents 4e68d46 + 182e8e4 commit 2e0b697
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 18 deletions.
8 changes: 5 additions & 3 deletions .github/workflows/docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@ jobs:
type=sha
- name: "Setup Docker Buildx"
uses: docker/setup-buildx-action@v2
uses: docker/setup-buildx-action@v3
with:
platforms: linux/amd64

- name: "Login to GitHub Container Registry"
uses: docker/login-action@v2
Expand All @@ -44,10 +46,10 @@ jobs:
password: ${{ secrets.GITHUB_TOKEN }}

- name: "Build and Publish Helper Image"
uses: docker/build-push-action@v4
uses: docker/build-push-action@v6
with:
context: .
file: ./docker/ci/helper.Dockerfile
file: ./docker/helper.Dockerfile
push: true
tags: ${{ steps.meta.outputs.tags }}
labels: ${{ steps.meta.outputs.labels }}
Expand Down
13 changes: 0 additions & 13 deletions docker/ci/helper.Dockerfile

This file was deleted.

4 changes: 2 additions & 2 deletions docker/helper.Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# syntax=docker/dockerfile:1
ARG SOURCES_DIR=/usr/src/ipa
FROM rust:bullseye AS builder
FROM rust:bookworm AS builder
ARG SOURCES_DIR

# Prepare helper binaries
Expand All @@ -10,7 +10,7 @@ RUN set -eux; \
cargo build --bin helper --release --no-default-features --features "web-app real-world-infra compact-gate"

# Copy them to the final image
FROM debian:bullseye-slim
FROM rust:slim-bookworm
ENV HELPER_BIN_PATH=/usr/local/bin/ipa-helper
ENV CONF_DIR=/etc/ipa
ARG SOURCES_DIR
Expand Down

0 comments on commit 2e0b697

Please sign in to comment.