Fixed #571 - show message that model arg is ignored in case of using Azure OpenAI #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ase of using AzureOpenAI
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #592 +/- ##
==========================================
+ Coverage 76.25% 76.29% +0.04%
==========================================
Files 21 21
Lines 3318 3320 +2
==========================================
+ Hits 2530 2533 +3
+ Misses 788 787 -1 ☔ View full report in Codecov by Sentry. |
klieret
approved these changes
Jun 19, 2024
|
Just for the record. I created the original diff for this fix using SWE-Agent. |
|
Cool! Thank you so much! |
sankalp1999
pushed a commit
to sankalp1999/SWE-agent
that referenced
this pull request
Nov 5, 2024
…ase of using Azure OpenAI (princeton-nlp#592) * Fixed princeton-nlp#571 - show message that model arg is ignored in case of using AzureOpenAI * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…AzureOpenAI
Reference Issues/PRs
Fixes #571
What does this implement/fix? Explain your changes.
Log warning message that model command line arg is ignored in case of using AzureOpenAI.