Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When using the azure GPT endpoint, the --model CLI arg is ignored #571

Open
ofirpress opened this issue Jun 12, 2024 · 1 comment · Fixed by #592
Open

When using the azure GPT endpoint, the --model CLI arg is ignored #571

ofirpress opened this issue Jun 12, 2024 · 1 comment · Fixed by #592
Labels
🐛 bug Something isn't working

Comments

@ofirpress
Copy link
Member

hi!
When using the azure GPT endpoint, the --model CLI arg is ignored

So we should give a warning (or an error?) if the user tries using it.

(we instead get the model from: OPENAI_API_VERSION: '...')
see https://github.com/princeton-nlp/SWE-agent/blob/main/sweagent/agent/models.py#L247
@ofirpress ofirpress added the 🐛 bug Something isn't working label Jun 12, 2024
jank added a commit to jank/SWE-agent that referenced this issue Jun 19, 2024
@jank
Fixed princeton-nlp#571 - show message that model arg is ignored in c…
90b3103 
…ase of using AzureOpenAI
@jank jank mentioned this issue Jun 19, 2024
Merged
@klieret klieret reopened this Jun 19, 2024
@klieret
Copy link
Member

klieret commented Jun 19, 2024

(small correction: we get the model from AZURE_OPENAI_DEPLOYMENT)

Yup, this is not ideal. I remember this came up during the review of the PR. Let me revisit if we can't do better at some point (so leaving this open for now)

sankalp1999 pushed a commit to sankalp1999/SWE-agent that referenced this issue Nov 5, 2024
@jank @pre-commit-ci
Fixed princeton-nlp#571 - show message that model arg is ignored in c…
7c21842 
…ase of using Azure OpenAI (princeton-nlp#592)

* Fixed princeton-nlp#571 - show message that model arg is ignored in case of using AzureOpenAI

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed #571 - show message that model arg is ignored in case of using Azure OpenAI jank/SWE-agent
2 participants
@klieret @ofirpress