Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Primer::Alpha::ImageCrop #3158

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Delete Primer::Alpha::ImageCrop #3158

merged 2 commits into from
Oct 18, 2024

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Oct 18, 2024

What are you trying to accomplish?

This deletes the Primer::Alpha::ImageCrop component. There are no uses of this component in the codebase, and it is not needed. We want to delete it so we don't have to send it through a11y remediation.

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@jonrohan jonrohan requested a review from a team as a code owner October 18, 2024 20:48
Copy link

changeset-bot bot commented Oct 18, 2024

🦋 Changeset detected

Latest commit: 066d00a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pour one out for 'ol ImageCrop 🫗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants