Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add rails version to Stack component, remove ImageCrop docs #870

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

francinelucca
Copy link
Contributor

@francinelucca francinelucca commented Oct 4, 2024

Stack component has been introduced to Primer view components, adding it so it here so it can be reflected in our docs.

Also deletes the ImageCrop component docs and nav item since this component was removed in primer/view_components#3158

@francinelucca francinelucca self-assigned this Oct 4, 2024
Copy link
Contributor

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@francinelucca
Copy link
Contributor Author

Will merge when primer/view_components#3085 releases

@francinelucca francinelucca marked this pull request as ready for review November 5, 2024 22:03
@francinelucca francinelucca requested a review from a team as a code owner November 5, 2024 22:03
@francinelucca francinelucca changed the title docs: add rails version to Stack component docs: add rails version to Stack component, remove ImageCrop docs Nov 5, 2024
@francinelucca francinelucca merged commit 439b608 into main Nov 5, 2024
6 checks passed
@francinelucca francinelucca deleted the francinelucca/docs/add-rails-stack-component branch November 5, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants