Allow form buttons to be disabled on click via data-disable-with #2164
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
I was recently reading a discussion on Slack and realized the Primer forms framework does not support Rails'
data-disable-with
functionality. In fact, the framework explicitly disallows it by deleting thedata-disable-with
attribute if it is applied to a button. My intent here was to disallow thedisabled
attribute, since form buttons should never be disabled according to our guidelines. Thedata-disable-with
attribute is nice to have because it prevents forms from being submitted multiple times. This PR restoresdata-disable-with
and removesdisabled
attributes instead.Integration
No changes required in production.
Risk Assessment
Accessibility
Merge checklist