Allow form buttons to be disabled on click via data-disable-with (#2164)

.changeset/curly-waves-travel.md

@@ -0,0 +1,7 @@
+---
+'@primer/view-components': patch
+---
+
+Allow form buttons to be disabled on click with data-disable-with
+
+<!-- Changed components: Primer::Alpha::FormButton -->

app/forms/submit_button_form.rb

@@ -14,7 +14,7 @@ class SubmitButtonForm < ApplicationForm
     )
 
     my_form.group(layout: :horizontal) do |button_group|
-      button_group.submit(name: :submit, label: "Submit", scheme: :primary, mb: 3) do |component|
+      button_group.submit(name: :submit, label: "Submit", scheme: :primary, mb: 3, disabled: true) do |component|
         component.with_leading_visual_icon(icon: :"check-circle")
       end
 

lib/primer/forms/button.rb

@@ -40,10 +40,9 @@ def initialize(input:, type: :button)
         # rails uses a string for this, but PVC wants a symbol
         @input.merge_input_arguments!(type: type.to_sym)
 
-        # Never disable buttons. This overrides the global
-        # ActionView::Base.automatically_disable_submit_tag setting.
-        # Disabling buttons is not accessible.
-        @input.remove_input_data(:disable_with)
+        # Never allow buttons to be disabled. Disabling buttons is not accessible.
+        # See: https://primer.style/design/ui-patterns/saving#state
+        @input.input_arguments.delete(:disabled)
       end
 
       def input_arguments

lib/primer/forms/dsl/input.rb

@@ -147,9 +147,11 @@ def add_input_data(key, value)
           input_data[key] = value
         end
 
+        # :nocov:
         def remove_input_data(key)
           input_data.delete(key)
         end
+        # :nocov:
 
         def merge_input_arguments!(arguments)
           arguments.each do |k, v|

test/lib/primer/forms_test.rb

@@ -132,11 +132,11 @@ def test_renders_buttons_with_slots
     end
   end
 
-  def test_renders_a_submit_button_without_data_disable_with
+  def test_disallows_disabled_buttons
     render_preview :submit_button_form
 
     button = page.find_all("button[type=submit]").first
-    assert_nil button["data-disable-with"]
+    assert_nil button["disabled"]
   end
 
   def test_renders_buttons_with_primer_utility_margins