Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run all e2e/component vrt & aat tests a second time with all css module flags on #5070

Merged
merged 21 commits into from
Oct 7, 2024

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Oct 4, 2024

This PR enhances the CI workflow by adding a new job to run visual regression tests (VRT) and accessibility tests (AAT) with all CSS module flags enabled. This helps us find issues in Components that are using components that have been converted to CSS modules. We also will no longer need to run inline feature flag tests, as this new job will cover those scenarios.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Oct 4, 2024

⚠️ No Changeset found

Latest commit: a740fbb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Oct 4, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5070 October 4, 2024 20:21 Inactive
Copy link
Contributor

github-actions bot commented Oct 4, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96.7 KB (0%)
packages/react/dist/browser.umd.js 97.02 KB (0%)

@jonrohan jonrohan changed the title Run vrt tests with all flags on Run all e2e/component vrt & aat tests a second time with all css module flags on Oct 4, 2024
@jonrohan jonrohan added the skip changeset This change does not need a changelog label Oct 4, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5070 October 4, 2024 20:37 Inactive
@jonrohan jonrohan marked this pull request as ready for review October 7, 2024 21:49
@jonrohan jonrohan requested a review from a team as a code owner October 7, 2024 21:49
@jonrohan jonrohan added this pull request to the merge queue Oct 7, 2024
@jonrohan jonrohan removed this pull request from the merge queue due to a manual request Oct 7, 2024
@jonrohan jonrohan added this pull request to the merge queue Oct 7, 2024
Merged via the queue into main with commit b91a5e5 Oct 7, 2024
42 checks passed
@jonrohan jonrohan deleted the run_vrt_aat_with_all_flags_on branch October 7, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants