-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug Fix for Text component and styled system arguments #5079
Conversation
🦋 Changeset detectedLatest commit: e247b44 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment for the helper function, was curious what you would say 🤔 Wasn't sure if this was in a fast path or not / if this component can be used a lot on a page.
Co-authored-by: Josh Black <joshblack@github.com>
This was discovered in #5070. The
Text
component wasn't doing anything with styled system typography or common props. This PR adds logic to ensure that these props are correctly passed to theBox
component when theText
component is used with the CSS modules feature flag enabled.You can observe the bug by visiting the SegmentedControl storybook example with flag off vs flag on.
Changelog
Changed
Correctly pass styled system typography and common props to the
Box
component in theText
component when the CSS modules feature flag is enabled.Rollout strategy
Testing & Reviewing
Merge checklist