Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix for Text component and styled system arguments #5079

Merged
merged 5 commits into from
Oct 7, 2024
Merged

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Oct 7, 2024

This was discovered in #5070. The Text component wasn't doing anything with styled system typography or common props. This PR adds logic to ensure that these props are correctly passed to the Box component when the Text component is used with the CSS modules feature flag enabled.

You can observe the bug by visiting the SegmentedControl storybook example with flag off vs flag on.

Changelog

Changed

Correctly pass styled system typography and common props to the Box component in the Text component when the CSS modules feature flag is enabled.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@jonrohan jonrohan requested a review from a team as a code owner October 7, 2024 17:47
Copy link

changeset-bot bot commented Oct 7, 2024

🦋 Changeset detected

Latest commit: e247b44

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Oct 7, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5079 October 7, 2024 17:50 Inactive
Copy link
Contributor

github-actions bot commented Oct 7, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96.92 KB (-0.02% 🔽)
packages/react/dist/browser.umd.js 97.16 KB (+0.05% 🔺)

Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment for the helper function, was curious what you would say 🤔 Wasn't sure if this was in a fast path or not / if this component can be used a lot on a page.

packages/react/src/Text/Text.tsx Outdated Show resolved Hide resolved
Co-authored-by: Josh Black <joshblack@github.com>
@jonrohan jonrohan added this pull request to the merge queue Oct 7, 2024
Merged via the queue into main with commit a2e5671 Oct 7, 2024
33 checks passed
@jonrohan jonrohan deleted the bug_fix_text branch October 7, 2024 19:27
@primer primer bot mentioned this pull request Oct 7, 2024
@primer primer bot mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants