Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix data table pagination #5059

Merged
merged 11 commits into from
Oct 4, 2024
Merged

Fix data table pagination #5059

merged 11 commits into from
Oct 4, 2024

Commits on Oct 3, 2024

  1. Data table pagination add re-render tests highlighting issues with co… 

    …mponent state for total pages and current page
    @gwwar
    gwwar committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    c4d814c View commit details
    Browse the repository at this point in the history

  2. add use effect to update component state if we see that initial state… 

    … has changed
    @gwwar
    gwwar committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    d7f8fd4 View commit details
    Browse the repository at this point in the history

  3. do not use use effect

    @gwwar
    gwwar committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    c54c9e7 View commit details
    Browse the repository at this point in the history

  4. only change when defaults change

    @gwwar
    gwwar committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    440dd73 View commit details
    Browse the repository at this point in the history

  5. add more test cases

    @gwwar
    gwwar committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    f50ba8c View commit details
    Browse the repository at this point in the history

  6. also change table content

    @gwwar
    gwwar committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    4973d27 View commit details
    Browse the repository at this point in the history

  7. add test coverage for onchange

    @gwwar
    gwwar committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    a292661 View commit details
    Browse the repository at this point in the history

  8. provide default page size

    @gwwar
    gwwar committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    cde0485 View commit details
    Browse the repository at this point in the history

  9. appease types

    @gwwar
    gwwar committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    b5e9179 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. fix corner case

    @gwwar
    gwwar committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    7bf3b6d View commit details
    Browse the repository at this point in the history

  2. Add changeset

    @gwwar
    gwwar committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    480dfe0 View commit details
    Browse the repository at this point in the history