-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix data table pagination #5059
Conversation
…mponent state for total pages and current page
🦋 Changeset detectedLatest commit: 480dfe0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, thank you! 🎉 Could you add a changeset? Run npx changeset
and follow the prompts 😄
If we render a component, then rerender it with different defaultPageIndex and pageCount, we can see values like
Page -2
,Page -1
,Page 0
. The defaultPageIndex is also not respected when this value is updated.Changes here:
defaultIndex
Feel free to suggest alternatives, if folks can think of anything cleaner.
before.mp4
playground.mp4
While testing I found an odd corner case for truncation. This is also present in main. I fixed this by doing a bounds check when setting offset.
Closes https://github.com/github/meao/issues/2720
Changelog
New
Changed
Removed
Rollout strategy
Testing & Reviewing
Merge checklist