chore: remove TabPanels component #4804
Conversation
🦋 Changeset detectedLatest commit: 0d87c46 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
|
bump @broccolinisoup @mperrotti ! |
| '@primer/react': minor | ||
| --- | ||
|
|
||
| Remove experimental TabPanels component in preference of UnderlinePanels |
There was a problem hiding this comment.
As far as I understand, we don't have an internal usage for this component but I am wondering in case for open source usages should we release this as "potentially major"?
There was a problem hiding this comment.
Good point, I'm honestly not sure 🤷 It'd be great if we wouldn't even need to do a semver bump for this since it's under experimental/drafts but it's clearly nice to know if one of these things get removed. I think because of that I'm torn since we definitely don't want these to be considered under semver but it's also nice to communicate this stuff 😕
This is where the minor bump came from just to say that things are changing but happy to say major to make this simpler 👍
There was a problem hiding this comment.
Oh this is draft!! Sorry I missed that. Yeah no worries. minor sounds good then.
|
bump @mperrotti when you have a sec! |
Closes https://github.com/github/primer/issues/3692
Changelog
New
Changed
Removed
Rollout strategy
Marking this as minor since this is an experimental component
Testing & Reviewing