-
Notifications
You must be signed in to change notification settings - Fork 614
chore: remove TabPanels component #4804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
6511fb8
chore: remove TabPanels component
joshblack 20f4b90
test(e2e): remove e2e tests for Tabpanels
joshblack 0ea4c00
docs: remove TabPanels docs
joshblack 02661e5
chore: add changeset
joshblack 0d87c46
Merge branch 'main' into 3692-remove-tabpanels-component
joshblack File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@primer/react': minor | ||
| --- | ||
|
|
||
| Remove experimental TabPanels component in preference of UnderlinePanels | ||
Binary file removed
BIN
-8.35 KB
...ponents/TabPanels.test.ts-snapshots/TabPanels-Default-dark-colorblind-linux.png
Binary file not shown.
Binary file removed
BIN
-8.29 KB
.../components/TabPanels.test.ts-snapshots/TabPanels-Default-dark-dimmed-linux.png
Binary file not shown.
Binary file removed
BIN
-8.31 KB
...ents/TabPanels.test.ts-snapshots/TabPanels-Default-dark-high-contrast-linux.png
Binary file not shown.
Binary file removed
BIN
-8.33 KB
...apshots/components/TabPanels.test.ts-snapshots/TabPanels-Default-dark-linux.png
Binary file not shown.
Binary file removed
BIN
-8.35 KB
...ponents/TabPanels.test.ts-snapshots/TabPanels-Default-dark-tritanopia-linux.png
Binary file not shown.
Binary file removed
BIN
-8.35 KB
...onents/TabPanels.test.ts-snapshots/TabPanels-Default-light-colorblind-linux.png
Binary file not shown.
Binary file removed
BIN
-8.33 KB
...nts/TabPanels.test.ts-snapshots/TabPanels-Default-light-high-contrast-linux.png
Binary file not shown.
Binary file removed
BIN
-8.36 KB
...pshots/components/TabPanels.test.ts-snapshots/TabPanels-Default-light-linux.png
Binary file not shown.
Binary file removed
BIN
-8.35 KB
...onents/TabPanels.test.ts-snapshots/TabPanels-Default-light-tritanopia-linux.png
Binary file not shown.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
98 changes: 0 additions & 98 deletions
98
packages/react/src/drafts/TabPanels/TabPanels.features.stories.tsx
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I understand, we don't have an internal usage for this component but I am wondering in case for open source usages should we release this as "potentially major"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I'm honestly not sure 🤷 It'd be great if we wouldn't even need to do a semver bump for this since it's under experimental/drafts but it's clearly nice to know if one of these things get removed. I think because of that I'm torn since we definitely don't want these to be considered under semver but it's also nice to communicate this stuff 😕
This is where the
minorbump came from just to say that things are changing but happy to saymajorto make this simpler 👍There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh this is draft!! Sorry I missed that. Yeah no worries. minor sounds good then.