Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint: Really enable primer-react/no-system-props #4366

Closed
wants to merge 10 commits into from

Conversation

siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Mar 7, 2024

primer-react/no-system-props was not checking stories because it did not consider the import to be from @primer/react

some of them will be fixed by

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Internal only.

Merge checklist

  • NA Added/updated tests
  • NA Added/updated documentation
  • NA Added/updated previews (Storybook)
  • NA Changes are SSR compatible
  • NA Tested in Chrome
  • NA Tested in Firefox
  • NA Tested in Safari
  • NA Tested in Edge
  • NA (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

@siddharthkp siddharthkp added the skip changeset This change does not need a changelog label Mar 7, 2024
@siddharthkp siddharthkp self-assigned this Mar 7, 2024
Copy link

changeset-bot bot commented Mar 7, 2024

⚠️ No Changeset found

Latest commit: 7b705c1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 7, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 113.71 KB (0%)
packages/react/dist/browser.umd.js 114.38 KB (0%)

Copy link
Contributor

github-actions bot commented May 7, 2024

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

@github-actions github-actions bot added the Stale label May 7, 2024
@github-actions github-actions bot closed this May 14, 2024
@github-actions github-actions bot deleted the eslint/enable-system-props-check branch May 14, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant