Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-system-props: Add option to ignore specific component names #152

Merged
merged 4 commits into from
Mar 8, 2024

Conversation

siddharthkp
Copy link
Member

Useful for linting primer/react internally.

An example from the docs:

<Hidden when={['narrow', 'wide']}>
  <Placeholder height="80px" label="This is not visible in narrow and wide viewport" />
</Hidden>

Placeholder is not an exported component and we'd not want to add an eslint-ignore inside the docs.

@siddharthkp siddharthkp requested a review from a team as a code owner March 8, 2024 15:41
Copy link

changeset-bot bot commented Mar 8, 2024

🦋 Changeset detected

Latest commit: cab3e4b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-primer-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@siddharthkp siddharthkp changed the title no-system-props: Add ability to ignore specific component names no-system-props: Add option to ignore specific component names Mar 8, 2024
@siddharthkp siddharthkp merged commit 7baeb96 into main Mar 8, 2024
5 checks passed
@siddharthkp siddharthkp deleted the no-system-props/ignore-specific-components branch March 8, 2024 15:58
@primer-css primer-css mentioned this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants