Button: Make the usage of the dialog more clear

[maximedegreve]

Changelog

• Marked the old component as (deprecated) in Storybook to clarify that it's outdated and should no longer be used.
• Updated the close button in the new Dialog to ensure it has the proper border radius.
• Fix the buttons by removing the deprecated buttons
• Changed the subtitle to a regular weight

New

Nothing

Changed

• Use IconButton for the close button.
• Use new Button instead of the deprecated ones to ensure the styling is correctly
• Use a subtitle with a regular weight to match the expected design
• Add a deprecated label to the old Dialog component in Storybook

Removed

Nothing

Rollout strategy

• Patch release
• Minor release
• Major release; if selected, include a written rollout or migration plan

Testing & Reviewing

Merge checklist

• Added/updated tests
• Added/updated documentation
• Added/updated previews (Storybook)
• Changes are SSR compatible
• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge
• Integration tests pass at github/github (Learn more about how to run integration tests)

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

[changeset-bot]

🦋 Changeset detected

Latest commit: e907c15

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

size-limit report 📦

Path	Size
dist/browser.esm.js	103.52 KB (-0.79% 🔽)
dist/browser.umd.js	104.02 KB (-0.82% 🔽)

[pksjce]

Some context I found on this particular fix.

We have an accessibility bug as well as a react bug which was fixed here (has similar changes) and reverted here

I think this is a good change but I wonder if the problem faced by the previous revert is fixed here.

[pksjce]

Do you think it'd be better to move this to the deprecated folder?

[maximedegreve]

Good idea that's even more clear!

[pksjce]

There was also another effort that was reverted with similar intentions

[mperrotti]

It looks like we were able to get the correct buttons used in this PR: #4049

[github-actions]

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.