Skip to content

Revert "[Dialog] Replace deprecated Button for current one" #3527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Jul 17, 2023

Sorry @ItzaMi, @broccolinisoup, had to revert this PR because it failed the integration tests in github/github

Issues found:

  1. (link is github staff only) ui/packages/memex/src/client/pages/insights/components/insights-upsell-dialog.tsx:66 uses Button as="a", the types for which are not supported

    Reported in https://github.com/github/github/actions/runs/5573804589/jobs/10181608881:

    ui/packages/memex/src/client/pages/insights/components/insights-upsell-dialog.tsx(66,11): 
    error TS2322: Type '{ as: string; buttonType: "primary"; content: JSX.Element; href: string; sx: { ml: number; }; target: string; rel: string; onClick: () => void; }' is not assignable to type 'DialogButtonProps'.
    
  2. Checking the storybook for the pull request, it looks like the focus bug was not fixed

@siddharthkp siddharthkp requested review from a team and mperrotti July 17, 2023 10:19
@changeset-bot
Copy link

changeset-bot bot commented Jul 17, 2023

⚠️ No Changeset found

Latest commit: 1c26a20

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@siddharthkp siddharthkp requested review from broccolinisoup and removed request for mperrotti July 17, 2023 10:20
@siddharthkp siddharthkp self-assigned this Jul 17, 2023
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
dist/browser.esm.js 102.64 KB (+0.49% 🔺)
dist/browser.umd.js 103.2 KB (+0.5% 🔺)

Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah such a bummer 😭 But thanks for catching the breaking issue! We will look at it to re-introducing it again.

@siddharthkp siddharthkp added this pull request to the merge queue Jul 17, 2023
@siddharthkp siddharthkp removed the request for review from joshblack July 17, 2023 10:42
Merged via the queue into main with commit 68fef3d Jul 17, 2023
@siddharthkp siddharthkp deleted the revert-3084-itzami-dialog-focus-not-appearing-non-standard-button branch July 17, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants