Skip to content

[WIP] Fix misc issues with Dialog v2 #3443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

mperrotti
Copy link
Contributor

@mperrotti mperrotti commented Jun 22, 2023

Closes # https://github.com/github/primer/issues/2372

Screenshots

Please provide before/after screenshots for any visual changes

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Changes are SSR compatible
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

joshblack and others added 3 commits June 21, 2023 17:36
* fix: add experimental folder to npm files

* chore: add changeset

---------

Co-authored-by: Josh Black <joshblack@users.noreply.github.com>
@changeset-bot
Copy link

changeset-bot bot commented Jun 22, 2023

🦋 Changeset detected

Latest commit: e802b24

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mperrotti mperrotti changed the title Fix misc issues with Dialog v2 [WIP] Fix misc issues with Dialog v2 Jun 22, 2023
@github-actions github-actions bot temporarily deployed to storybook-preview-3443 June 22, 2023 16:51 Inactive
@mperrotti mperrotti temporarily deployed to github-pages June 22, 2023 16:52 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3443 June 22, 2023 16:52 Inactive
@mperrotti mperrotti changed the base branch from main to next-major June 22, 2023 18:24
@mperrotti
Copy link
Contributor Author

Closing this and re-opening as a branch off of next-major

@mperrotti
Copy link
Contributor Author

New issue here: #3444

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants