Skip to content

Update ActionMenu.mdx to havea11yReviewed as false to fix the mistake happened while resolving merge conflicts on #3408 #3434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

broccolinisoup
Copy link
Member

While we were reverting PRs on #3408, we must have mistaken on resolving the merge conflicts so apparently we ended up reverting the a11yReviewed status of ActionMenu to true. This PR fixes that.

Screenshots

Please provide before/after screenshots for any visual changes

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Changes are SSR compatible
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@broccolinisoup broccolinisoup added the skip changeset This change does not need a changelog label Jun 21, 2023
@broccolinisoup broccolinisoup requested review from a team and mperrotti June 21, 2023 00:52
@changeset-bot
Copy link

changeset-bot bot commented Jun 21, 2023

⚠️ No Changeset found

Latest commit: e6c373c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
dist/browser.esm.js 101.01 KB (0%)
dist/browser.umd.js 101.57 KB (0%)

@broccolinisoup broccolinisoup added this pull request to the merge queue Jun 21, 2023
Merged via the queue into main with commit 44ccc90 Jun 21, 2023
@broccolinisoup broccolinisoup deleted the bs/merge-conflicts-fix branch June 21, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants