Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): v36.0.0 #3384

Merged
merged 90 commits into from
Oct 30, 2023
Merged
Show file tree
Hide file tree
Changes from 72 commits
Commits
Show all changes
90 commits
Select commit Hold shift + click to select a range
d848aa5
Update `next-major` with changes from `main` (#3354)
joshblack Jun 5, 2023
5d31e62
Remove support for for Breadcrumb, SubNav, TabNav, UnderlineNav (#3319)
broccolinisoup Jun 5, 2023
77d4042
Remove extralarge from Tokens (#3313)
broccolinisoup Jun 6, 2023
3d25ccc
Merge branch 'main' of github.com:primer/react into next-major
joshblack Jun 8, 2023
266d40c
chore: include reverted changes
joshblack Jun 8, 2023
fb62eb5
chore: include reverted changes
joshblack Jun 8, 2023
5d7d55b
Update minimum version of react and react-dom to v18 (#3240)
joshblack Jun 8, 2023
98ea43f
Button API alignment (#2893)
langermank Jun 9, 2023
318f9d6
Deprecate old filter components (#3396)
mperrotti Jun 19, 2023
eab4d15
Remove 'warning' status from form validation (#3414)
mperrotti Jun 20, 2023
7821267
Remove PageLayout.Pane position prop. (#3386)
radglob Jun 20, 2023
9ecfbb8
Merge branch 'main' of github.com:primer/react into next-major
joshblack Jun 21, 2023
6df7ae2
Fix type errors in next-major (#3456)
mperrotti Jun 30, 2023
3a70136
Use createRoot instead of ReactDOM.render for React 18 compatibility.…
radglob Jul 5, 2023
a8dbf4a
Refactor Autocomplete to use the newest ActionList (#3387)
mperrotti Jul 7, 2023
d5f394e
Make styled-components types an optional peer peer dependency (#3399)
mperrotti Jul 13, 2023
10a1b0d
Merge branch 'main' of github.com:primer/react into next-major
joshblack Jul 13, 2023
ff6265b
test(e2e): update snapshots
joshblack Jul 13, 2023
8f7186a
Remove deprecated components that have no usage across (#3542)
broccolinisoup Jul 19, 2023
134f265
Remove `DropdownButton` and `DropdownMenu` from deprecated and update…
broccolinisoup Jul 20, 2023
3ad237f
Remove deprecated ActionList from SelectPanel and FilteredActionList.…
radglob Jul 21, 2023
b0fc071
Use IconButton instead of ButtonClose in v1 Dialog. (#3557)
radglob Jul 24, 2023
66c6d58
Merge branch 'main' of github.com:primer/react into next-major
joshblack Jul 27, 2023
5405f3a
chore: address eslint violations
joshblack Jul 27, 2023
830ac6a
chore: update snapshots
joshblack Jul 27, 2023
52c8d22
Remove components from draft and move UnderlineNav2 to main bundle (#…
broccolinisoup Jul 28, 2023
d3146ce
Fix misc issues with Dialog v2 (#3444)
mperrotti Aug 2, 2023
ce628a9
ActionList item should have `border-radius` on hover with `full` vari…
langermank Aug 3, 2023
ec0c920
Merge branch 'main' of github.com:primer/react into next-major
joshblack Aug 10, 2023
22434e2
chore(deps): update styled-components and related dependencies to v5 …
joshblack Aug 15, 2023
e217cd5
Merge branch 'main' of github.com:primer/react into next-major
joshblack Aug 15, 2023
f61c2e5
test(e2e): update snapshots
joshblack Aug 15, 2023
5bee21d
chore: address typescript errors
joshblack Aug 15, 2023
39aa66b
chore: update lockfile
joshblack Aug 16, 2023
5993b78
test: update snapshots
joshblack Aug 16, 2023
60dff7e
Merge branch 'main' of github.com:primer/react into next-major
joshblack Aug 16, 2023
09fd16c
Merge branch 'main' of github.com:primer/react into next-major
joshblack Aug 16, 2023
e441725
fix: re-add useConfirm in public entrypoint
joshblack Aug 16, 2023
b935de9
test: update snapshots
joshblack Aug 16, 2023
f3b274d
Revert "test: update snapshots"
joshblack Aug 16, 2023
44688c6
Revert "fix: re-add useConfirm in public entrypoint"
joshblack Aug 16, 2023
7d2172f
Revert "Fix misc issues with Dialog v2 (#3444)"
joshblack Aug 16, 2023
6f0c43b
Merge branch 'main' of github.com:primer/react into next-major
joshblack Aug 21, 2023
501f448
Merge branch 'main' of github.com:primer/react into next-major
joshblack Aug 21, 2023
f035712
chore: update lockfiles
joshblack Aug 21, 2023
68806fa
Merge branch 'main' of github.com:primer/react into next-major
joshblack Aug 25, 2023
97f5ccb
chore(examples): update package-lock.json
joshblack Aug 25, 2023
57d83c8
Revert "Remove deprecated ActionList from SelectPanel and FilteredAct…
joshblack Aug 25, 2023
d37ef8a
Merge branch 'main' of github.com:primer/react into next-major
joshblack Aug 25, 2023
68037c4
Merge branch 'main' of github.com:primer/react into next-major
joshblack Aug 28, 2023
5fb6cb4
Merge branch 'main' of github.com:primer/react into next-major
joshblack Aug 28, 2023
2a520cc
Merge branch 'main' of github.com:primer/react into next-major
joshblack Aug 30, 2023
273438e
Remove StyledOcticon
jonrohan Sep 11, 2023
26e41bd
Revert "Remove StyledOcticon"
jonrohan Sep 11, 2023
dc95ed0
Merge branch 'main' of github.com:primer/react into next-major
joshblack Sep 12, 2023
bc7605d
test(vrt): add vrt snapshots
joshblack Sep 12, 2023
d4f1703
chore: update lockfile
joshblack Sep 12, 2023
bf962fc
Merge branch 'main' of github.com:primer/react into next-major
joshblack Sep 12, 2023
b38dfec
Merge branch 'main' of github.com:primer/react into next-major
joshblack Sep 20, 2023
5676ffc
Remove StyledOcticon component (#3735)
jonrohan Sep 20, 2023
7eaa51d
test(vrt): add Octicon snapshots
joshblack Sep 20, 2023
3b8646a
Merge branch 'main' of github.com:primer/react into next-major
joshblack Sep 28, 2023
a7ea623
Merge branch 'main' of github.com:primer/react into next-major
joshblack Sep 29, 2023
eecf6d1
Merge branch 'main' of github.com:primer/react into next-major
joshblack Oct 2, 2023
c2d2f68
Merge branch 'main' of github.com:primer/react into next-major
joshblack Oct 5, 2023
2759b30
Merge branch 'main' of github.com:primer/react into next-major
joshblack Oct 9, 2023
6078177
chore: address typescript violations
joshblack Oct 9, 2023
da2a642
Merge branch 'main' of github.com:primer/react into next-major
joshblack Oct 9, 2023
8052e09
Merge branch 'main' of github.com:primer/react into next-major
joshblack Oct 10, 2023
2e29dba
Merge branch 'main' of github.com:primer/react into next-major
joshblack Oct 11, 2023
a4776f0
Merge branch 'main' of github.com:primer/react into next-major
joshblack Oct 16, 2023
fcd16a1
Merge branch 'main' of github.com:primer/react into next-major
joshblack Oct 16, 2023
b0471f4
Merge branch 'main' of github.com:primer/react into next-major
joshblack Oct 17, 2023
ad02f1d
docs(PageHeader): update leadingIcon, trailingIcon to visual
joshblack Oct 17, 2023
da0ef5f
chore: update lockfile
joshblack Oct 17, 2023
6efc497
fix(Autocomplete): use children over text if it exists for output
joshblack Oct 19, 2023
5924361
Merge branch 'main' of github.com:primer/react into next-major
joshblack Oct 19, 2023
e6fdda8
Merge branch 'main' of github.com:primer/react into next-major
joshblack Oct 23, 2023
74b2d21
Merge branch 'main' of github.com:primer/react into next-major
joshblack Oct 24, 2023
4fffd72
next-major: Update docs and changeset for #3386 and #3367 (#3858)
siddharthkp Oct 25, 2023
eea2f26
Merge branch 'main' of github.com:primer/react into next-major
joshblack Oct 25, 2023
c90746b
revert: restore original PageLayout behavior (#3865)
joshblack Oct 26, 2023
c2adc8c
Merge branch 'main' of github.com:primer/react into next-major
joshblack Oct 26, 2023
950836b
Merge branch 'next-major' of github.com:primer/react into next-major
joshblack Oct 26, 2023
259803a
Merge branch 'main' of github.com:primer/react into next-major
joshblack Oct 30, 2023
220a23a
docs: update stories with new type changes
joshblack Oct 30, 2023
363e353
chore(deps): update to canary doctocat release
joshblack Oct 30, 2023
607c1c7
chore: update pacakge-lock.json
joshblack Oct 30, 2023
0c3b711
chore(examples): update package-lock.json
joshblack Oct 30, 2023
b6246ac
test: update snapshots
joshblack Oct 30, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
7 changes: 7 additions & 0 deletions .changeset/blue-gorillas-lie.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'@primer/react': major
---

Update styled-components and related dependencies to v5.x

<!-- Changed components: _none_ -->
8 changes: 8 additions & 0 deletions .changeset/clever-wolves-move.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
'@primer/react': major
---

Remove components from deprecated
- `BorderBox`, `ChoiceFieldset`, `Flex`, `Grid`, `Position`, `Dropdown`, `FormGroup`, `SelectMenu`, `InputField`, `Label`

<!-- Changed components: _none_ -->
43 changes: 43 additions & 0 deletions .changeset/early-timers-speak.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
---
'@primer/react': major
---

Remove components from draft bundle

* Move UnderlineNav2 (draft) to the main bundle

```diff
- import {UnderlineNav} from '@primer/react/drafts'
+ import {UnderlineNav} from '@primer/react'
```

....
* Remove TreeView from drafts

```diff
- import {TreeView} from '@primer/react/drafts'
+ import {TreeView} from '@primer/react'
```

* Remove SegmentedControl from drafts

```diff
- import {SegmentedControl} from '@primer/react/drafts'
+ import {SegmentedControl} from '@primer/react'
```

* Remove NavList from drafts

```diff
- import {NavList} from '@primer/react/drafts'
+ import {NavList} from '@primer/react'
```

* Remove SplitPageLayout from drafts

```diff
- import {SplitPageLayout} from '@primer/react/drafts'
+ import {SplitPageLayout} from '@primer/react'
```

<!-- Changed components: UnderlineNav, TreeView, SegmentedControl, NavList, SplitPageLayout -->
5 changes: 5 additions & 0 deletions .changeset/few-rocks-run.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': patch
---

Fixes type errors that appeared during v36 development. Likely caused by Button updates
7 changes: 7 additions & 0 deletions .changeset/flat-onions-sort.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@primer/react": major
---

- Changes `leadingIcon` and `trailingIcon` to `leadingVisual` and `trailingVisual`
- Removes `Button.Counter` as a child component, replacing it with a `count` prop. This change allows us to use the `trailingVisual` slot for counters.
- Removes the `outline` button variant as we wish to only support `invisible` buttons.
5 changes: 5 additions & 0 deletions .changeset/great-spies-deliver.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': major
---

Remove deprecated `extralarge` variant from `Token` and `TextInputWithToken` component
7 changes: 7 additions & 0 deletions .changeset/kind-readers-grab.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@primer/react": major
---

Remove StyledOcticon component. The component was renamed to `Octicon`. Update your imports by swapping `StyledOcticon` with `Octicon`

<!-- Changed components: Octicon -->
5 changes: 5 additions & 0 deletions .changeset/lemon-dancers-marry.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': major
---

Deprecates FilterList and FilteredSearch components
5 changes: 5 additions & 0 deletions .changeset/lovely-windows-juggle.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': major
---

Makes @types/styled-components an optional peer dependency, not a dependency
5 changes: 5 additions & 0 deletions .changeset/lucky-coins-guess.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Use createRoot instead of ReactDOM.render for React 18 compatibility.
5 changes: 5 additions & 0 deletions .changeset/nasty-bottles-draw.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': major
---

Update minimum version for react and react-dom to v18
7 changes: 7 additions & 0 deletions .changeset/nine-news-walk.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'@primer/react': major
---

Remove `DropdownButton` and `DropdownMenu` from deprecated and update the usages across

<!-- Changed components: SelectPanel, ActionList -->
5 changes: 5 additions & 0 deletions .changeset/odd-socks-hunt.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': major
---

The Autocomplete component no longer uses the deprecated ActionList component. There have been minor API updates, but it's largely the same.
5 changes: 5 additions & 0 deletions .changeset/old-coats-sniff.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': major
---

Removes 'warning' option from form components' `validationStatus` props
7 changes: 7 additions & 0 deletions .changeset/poor-wasps-stare.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@primer/react": patch
---

Use IconButton instead of ButtonClose in v1 Dialog.

<!-- Changed components: Dialog -->
5 changes: 5 additions & 0 deletions .changeset/popular-rivers-warn.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': major
---

Remove support for `activeClassName` for Breadcrumb, SubNav, TabNav, UnderlineNav
5 changes: 5 additions & 0 deletions .changeset/shaggy-insects-march.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": major
---

Ensure ActionList item has `border-radius` on hover with `full` variant
5 changes: 5 additions & 0 deletions .changeset/weak-jokes-chew.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

FilteredActionList now uses new ActionList as a base, and SelectPanel reflects those changes.
5 changes: 5 additions & 0 deletions .changeset/yellow-windows-accept.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": major
---

Removes PageLayout.Pane position prop.
36 changes: 14 additions & 22 deletions .github/workflows/consumer_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,41 +11,33 @@ jobs:
steps:
- name: Checkout repository
uses: actions/checkout@v4

- name: Set up Node.js
uses: actions/setup-node@v3
with:
node-version: 18
cache: npm

# `prepare` is a special case in `npm` and likes to run all the time, even
# with `--ignore-scripts` and even when using `npm link @primer/react
# --ignore-scripts`. This just removes it entirely for the duration of
# this workflow.
- name: Remove "prepare" script
run: npm pkg delete scripts.prepare

- name: Install dependencies
run: npm ci

- name: Build
run: npm run build

- name: Install only production dependencies
run: npm ci --production

- name: Link
run: npm link

- name: Link and test
id: link-and-test
# Output the artifact as a tarball in `consumer-test`. Write the
# information for this package in `consumer-test/pack.json` so we can read
# from it later to install the package
- name: Create a tarball for the package
run: npm pack --pack-destination consumer-test --json > consumer-test/pack.json
- name: Clean package directory
run: |
npm run clean
rm -rf node_modules
- name: Test
id: test
working-directory: consumer-test
run: |
# Read the filename for the tarball from `pack.json`
npm install $(jq -r '.[0].filename' pack.json)
npm install
npm link @primer/react
npm run check

- name: Add annotation
if: failure() && steps.link-and-test.conclusion == 'failure'
if: failure() && steps.test.conclusion == 'failure'
run: |
echo "::error file=tsconfig.build.json::Test package could not build. See https://github.com/primer/react/blob/main/consumer-test"
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
1 change: 1 addition & 0 deletions consumer-test/App.tsx
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import React from 'react'
import {Box} from '@primer/react'

export default function App() {
Expand Down
6 changes: 6 additions & 0 deletions consumer-test/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,13 @@
"check": "tsc --noEmit"
},
"dependencies": {
"@types/react": "^18.2.14",
"@types/react-dom": "^18.2.6",
"@types/styled-components": "^5.1.11",
"@primer/react": "*",
"react": "^18.0.0",
"react-dom": "^18.0.0",
"styled-components": "^5.3.11",
"typescript": "~4.7.2"
}
}
3 changes: 1 addition & 2 deletions docs/components/ThemeReferenceTree.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import React, {useState} from 'react'
import {Box, Text} from '@primer/react'
import {TreeView} from '@primer/react/drafts'
import {Box, Text, TreeView} from '@primer/react'

export default function ThemeReferenceTree({themeData}) {
return (
Expand Down
Loading
Loading