Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): v36.0.0 #3384

Merged
merged 90 commits into from
Oct 30, 2023
Merged

chore(release): v36.0.0 #3384

merged 90 commits into from
Oct 30, 2023

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented Jun 6, 2023

Closes #3384

Review Checklist

PR Description Reviewer Reviewed
#3569 Update styled-components and related dependencies to v5.x @joshblack
#3542 Remove components from deprecated @broccolinisoup
#2893 Button API Changes @langermank
#3313 Remove deprecated extralarge variant @broccolinisoup
#3735 Remove StyledOcticon component @joshblack
#3396 Deprecates FilterList and FilteredSearch components @joshblack
#3399 Makes @types/styled-components an optional peer dependency @joshblack
#3240 Update minimum version for react and react-dom to v18 @joshblack
#3544 Remove DropdownButton and DropdownMenu from deprecated @broccolinisoup
#3387 Remove deprecated ActionList component @broccolinisoup
#3414 Removes 'warning' option @broccolinisoup
#3319 Remove support for activeClassName @broccolinisoup
#3556 Ensure ActionList item has border-radius on hover with full variant @langermank
#3367 Use createRoot instead of ReactDOM.render for React 18 compatibility @siddharthkp
#3557 Use IconButton instead of ButtonClose in v1 Dialog @siddharthkp
#3538 FilteredActionList now uses new ActionList as a base @siddharthkp

joshblack and others added 3 commits June 5, 2023 07:47
* ci(release-schedule): update format for previous issue id

* ci(release-schedule): use tagged template literals for assignees row

* docs: update to storybook v7 (#3298)

* docs: update to storybook v7

* ci: update storybook build command

* docs: fix typescript errors in stories

* chore: update build-storybook custom script

* test(e2e): update root selector for e2e tests

* chore: add storybook/csf dependency

* test: update lockfile test

---------

Co-authored-by: Josh Black <joshblack@users.noreply.github.com>

* Jdrush89/tree focus bug (#3300)

* Adding example of focus bug

* Not using focusInStrategy when clicking

* Clearing mousedown state correctly

* Adding changeset

* Removing unused import

* Moving mouseup handler

* feat(npm): add experimental entrypoint (#3295)

* feat(npm): add experimental entrypoint

* chore: add changeset

---------

Co-authored-by: Josh Black <joshblack@users.noreply.github.com>

* ci: release notification (#3318)

Co-authored-by: Josh Black <joshblack@github.com>

* SelectPanel: Add filter input label and description (#3312)

* Make placeholderText prop optional

* Add `inputLabel` prop

* Add filter input description

* Create early-beds-whisper.md

* Document inputLabel prop

* Update src/SelectPanel/SelectPanel.docs.json

* Update generated/components.json

---------

Co-authored-by: colebemis <colebemis@users.noreply.github.com>

* SelectPanel: Add `title` prop (#3311)

* Add a title prop to SelectPanel

* Update generated/components.json

* Create small-queens-vanish.md

* Allow title to be ReactElement

* Update SelectPanel stories

* Update generated/components.json

* Update snapshots

---------

Co-authored-by: colebemis <colebemis@users.noreply.github.com>

* SelectPanel: Announce changes to screen readers (#3316)

* SelectPanel: Announce filter changes to screenreaders

* Create rare-humans-watch.md

* Update formatting

* chore(dependencies): update @typescript-eslint/* (#3307)

Co-authored-by: Josh Black <joshblack@users.noreply.github.com>

* Remove chroma-js dependency (#3325)

* remove chroma.valid to drop chroma-js dependency

* Create rotten-dogs-hang.md

* Update accessibility-alt-text-bot.yml (#3326)

* Update accessibility-alt-text-bot.yml

### What

The accessibility-alt-text-bot workflow does not have permissions to write a comment on an issue. This is likely due to how permissions are setup in this repo. In order to keep permissions, at the repo level, unchanged, we need to add permission directly to the workflow. 

I also took this as an opportunity to bump the alt-text-bot version and give you access to reminders in discussions

* format

* add  contents

* add  contents

* Remove aria-hidden=true from spans with required asterisk (#3320)

* Remove aria-hidden=true from spans with required asterisk

* Create pink-beds-fetch.md

---------

Co-authored-by: Cole Bemis <colebemis@github.com>

* Update `PageLayout` docs around `<main>` usage (#3323)

* Update `PageLayout` docs around `<main>` usage

* Update generated/components.json

* Fix links

---------

Co-authored-by: TylerJDev <TylerJDev@users.noreply.github.com>

* ci:  update ci workflow to run against next-major branch (#3329)

* NavList: Fix group dividers (#3328)

* Fix NavLIst.Group dividers

* Use first-of-type instead of first-child

* Update snapshots and stories

* Refactor FilteredActionList to address a11y violations and use new ActionList. (#3247)

* Update FilteredActionList to use non-deprecated ActionList.

* Use non-deprecated ActionList in FilteredActionList.

* Fix a11y issues in FilteredActionList story.

* Add prop to hide selection component if needed.

* Remove unused hook import.

* Get SavedReplies to look as it did with deprecated ActionList.

* Fix failing test.

* Create weak-jokes-chew.md

* Update generated/components.json

* Fix themePreval snapshot.

* Linting fixes.

* Fix type-check errors.

* Update themePreval snapshot again.

* Fix themePreval snapshot to match origin. Unsure why it's not generating the same way.

* Hide selections in MarkdownEditor saved replies.

* Remove hideSelection prop and add defaultRenderFn to FilteredActionList so these don't have to be defined manually everywhere.

* Fix selection rendering (needed explicit selected boolean) and fix SelectPanel docs.

* Pass selectionVariant illegally to SelectPanel in src/MarkdownEditor/_SavedReplies.tsx so Selection components don't render.

* Remove remaining references of hideSelection prop.

* Update changeset to reflect that changes impact SelectPanel.

* Remove renderFn prop from SelectPanel and use default for FilteredActionList, which seems to cover most cases.

* Fix truncation in SavedReplies descriptions.

* Update generated/components.json

* Fix linting error.

* Don't make renderFn a prop (if we need to make this configurable, we can expose it later. Use maxWidth 100% for SavedReplies truncation.

* Use showDividers prop in SelectPanel story.

* Formatting.

* Add temporary support for showItemDividers prop to SelectPanel to keep backwards compatibility.

* Support passing deprecated showItemDividers prop in ActionList.

---------

Co-authored-by: radglob <radglob@users.noreply.github.com>

* Add PostCSS color var fallback for upcoming CSS work (#3278)

* add fallback plugin

* Update rollup.config.js

Co-authored-by: Josh Black <joshblack@github.com>

* remove fallbacks from source

* add back conflict free package-lock

* use lockfileVersion 3

---------

Co-authored-by: Josh Black <joshblack@github.com>
Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com>

* Move theme dependencies on lodash from devDependencies to dependencies (#3332)

* move theme deps from devDependencies

* Create eleven-sloths-laugh.md

* chore(deps-dev): bump terser from 5.16.1 to 5.17.6 (#3336)

Bumps [terser](https://github.com/terser/terser) from 5.16.1 to 5.17.6.
- [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md)
- [Commits](terser/terser@v5.16.1...v5.17.6)

---
updated-dependencies:
- dependency-name: terser
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps-dev): bump micromark-extension-mdxjs from 1.0.0 to 1.0.1 (#3337)

Bumps [micromark-extension-mdxjs](https://github.com/micromark/micromark-extension-mdxjs) from 1.0.0 to 1.0.1.
- [Release notes](https://github.com/micromark/micromark-extension-mdxjs/releases)
- [Commits](micromark/micromark-extension-mdxjs@1.0.0...1.0.1)

---
updated-dependencies:
- dependency-name: micromark-extension-mdxjs
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps-dev): bump @storybook/addon-essentials from 7.0.12 to 7.0.18 (#3338)

Bumps [@storybook/addon-essentials](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/essentials) from 7.0.12 to 7.0.18.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/v7.0.18/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v7.0.18/code/addons/essentials)

---
updated-dependencies:
- dependency-name: "@storybook/addon-essentials"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* ci(vrt): update build storybook step (#3333)

* chore(deps-dev): bump prettier from 2.8.1 to 2.8.8 (#3335)

* chore(deps-dev): bump prettier from 2.8.1 to 2.8.8

Bumps [prettier](https://github.com/prettier/prettier) from 2.8.1 to 2.8.8.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/prettier@2.8.1...2.8.8)

---
updated-dependencies:
- dependency-name: prettier
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore: run prettier

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Josh Black <joshblack@users.noreply.github.com>
Co-authored-by: Josh Black <joshblack@github.com>

* fix: prevent closing menu when `event.preventDefault()` is called on `ActionList.Item`'s `onSelect` handler by @gr2m (#3346)

* fix: prevent closing menu when `event.preventDefault()` is called on `ActionList.Item`'s `onSelect` handler (#3163)

* test: prevent closing menu when `event.preventDefault()` is called on `ActionList.Item`'s `onSelect` handler

Failing test for #3162

* fix: prevent closing menu when `event.preventDefault()` is called on `ActionList.Item`ߴs `onSelect` handler

* add storybook example: Delayed Menu Close

* update docs

* docs: changeset

* Update changelog

---------

Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com>

* Update generated/components.json

---------

Co-authored-by: Gregor Martynus <39992+gr2m@users.noreply.github.com>
Co-authored-by: siddharthkp <siddharthkp@users.noreply.github.com>

* Loosen `@primitives` dependency (#3350)

* add caret

* Create fluffy-pants-play.md

* Bump alt-text-bot: get alt text reminders on discussion comments (#3351)

* Changes alignment of form control validation message icon (#3121)

* changes alignment of validation message icon

* Create .changeset/big-days-obey.md

* updates snapshots

* updates snapshots again

* refactors layout styles

* test(vrt): update snapshots

---------

Co-authored-by: joshblack <joshblack@users.noreply.github.com>

* Update release-schedule.yml (#3342)

* Update release-schedule.yml (#3345)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Josh Black <joshblack@users.noreply.github.com>
Co-authored-by: Joshua Rush <jdrush89@gmail.com>
Co-authored-by: Gregor Martynus <39992+gr2m@users.noreply.github.com>
Co-authored-by: Cole Bemis <colebemis@github.com>
Co-authored-by: colebemis <colebemis@users.noreply.github.com>
Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com>
Co-authored-by: Kendall Gassner <kendallgassner@github.com>
Co-authored-by: Adriana Babakanian <adrianababakanian@github.com>
Co-authored-by: Tyler Jones <tylerjdev@github.com>
Co-authored-by: TylerJDev <TylerJDev@users.noreply.github.com>
Co-authored-by: Jeremy Neal <radglob@github.com>
Co-authored-by: radglob <radglob@users.noreply.github.com>
Co-authored-by: Katie Langerman <18661030+langermank@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: siddharthkp <siddharthkp@users.noreply.github.com>
Co-authored-by: Mike Perrotti <mperrotti@github.com>
* Remove support for for Breadcrumb, SubNav, TabNav, UnderlineNav

* update snapshots after removing activeClassName test

* update docs to remove activeClassName instructions
* Remove extralarge from Tokens

* add changeset
@changeset-bot
Copy link

changeset-bot bot commented Jun 6, 2023

🦋 Changeset detected

Latest commit: b6246ac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to storybook-preview-3384 June 8, 2023 15:14 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 103.55 KB (-1.09% 🔽)
dist/browser.umd.js 104.13 KB (-1.08% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-3384 June 8, 2023 15:19 Inactive
@joshblack joshblack temporarily deployed to github-pages June 8, 2023 15:24 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3384 June 8, 2023 15:24 Inactive
* feat(project): update React minimum version to 18

* chore: add changeset

* ci: remove type-check (17) option

* test: remove console.error spy

---------

Co-authored-by: Josh Black <joshblack@users.noreply.github.com>
@joshblack joshblack temporarily deployed to github-pages June 8, 2023 15:53 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3384 June 8, 2023 15:53 Inactive
* copy from other pr

* snippy snaps

* Create .changeset/flat-onions-sort.md

* color swaps

* snappy snips

* add missing type

* use the correct prop for ActionMenu.Button

* type fixes

* fix docs

* snaps

* Update flat-onions-sort.md

* fix merge conflict?

* change to count prop

* remove Button.Counter in favor of count prop

* Hoping to revert some unnecessary snaps diff

* update Button.Counter to use count prop

* update changeset and remove outine button examples from the story

* Update generated/components.json

* test: remove outline tests

* test(e2e): remove outline tests

* test(e2e): remove outdated snapshots

* test(vrt): update snapshots

* fix stories, fix count and trailing vis conflict

* test(vrt): update snapshots

---------

Co-authored-by: Armağan <broccolinisoup@github.com>
Co-authored-by: broccolinisoup <broccolinisoup@users.noreply.github.com>
Co-authored-by: Josh Black <joshblack@users.noreply.github.com>
Co-authored-by: Josh Black <joshblack@github.com>
Co-authored-by: langermank <langermank@users.noreply.github.com>
@langermank langermank temporarily deployed to github-pages June 9, 2023 20:13 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3384 June 9, 2023 20:21 Inactive
mperrotti and others added 4 commits June 19, 2023 15:14
* deprecates FilterList and FilteredSearch components

* 3230 Refactor internal components - TextInputInnerVisualSlot (#3373)

* refactor(TextInputInnerVisualSlot): moved to internal

* fix import

* deprecates FilterList and FilteredSearch

* Update generated/components.json

* fixes broken import

* fixes type errors

* fixes FilteredSearch docs data import path

---------

Co-authored-by: Amanda Brown <amanda.brown@testdouble.com>
Co-authored-by: mperrotti <mperrotti@users.noreply.github.com>
* 3230 Refactor internal components - TextInputInnerVisualSlot (#3373)

* refactor(TextInputInnerVisualSlot): moved to internal

* fix import

* removes 'warning' status from form validation

* Update generated/components.json

* adds changeset

* Update old-coats-sniff.md

---------

Co-authored-by: Amanda Brown <amanda.brown@testdouble.com>
Co-authored-by: mperrotti <mperrotti@users.noreply.github.com>
* Remove position prop and reorganize PageLayout stories to match previous layout.

* Create yellow-windows-accept.md

* Remove position references to fix type checks.

* Update generated/components.json

* Linting fixes.

* Fix stories by moving panes around.

* Remove position prop in NavList story.

---------

Co-authored-by: radglob <radglob@users.noreply.github.com>
@joshblack joshblack temporarily deployed to github-pages June 21, 2023 16:40 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3384 June 21, 2023 16:40 Inactive
mperrotti and others added 3 commits June 30, 2023 13:56
* fixes type errors that appeared during v36 updates

* adds changeset

* re-add ts-expect-error to CounterLabel ref

* fixes circular depency in CheckboxOrRadioGroup (I think)

* testing a fix for CI type errors

* testing ANOTHER fix for CI type errors

* testing ONE MORE fix for CI type erros on the 'size' check

* removes janky attempt at fixing CI 'size' check's type error

* replace Button2 with Button

* Button major changes leadingIcon-> leadingVisual updates on Markdown comp

* update props on the story

* try not exporting Button2

* try exporting Button2 as Button2

---------

Co-authored-by: Armagan Ersoz <broccolinisoup@github.com>
…#3367)

* Use createRoot instead of ReactDOM.render for React 18 compatibility.

* Create lucky-coins-guess.md

* Updated snapshots.
* started refactoring the Autocomplete component to use the new ActionList

* Gets Autocomplete working with latest ActionList

Co-authored-by: Josh Black <joshblack@users.noreply.github.com>

* updates snapshots

* code improvements

* adds changeset

* fixes docs typo, updates snapshots

* fixes bug in useFocusZone, updates snapshots

* updates snapshots

---------

Co-authored-by: Josh Black <joshblack@users.noreply.github.com>
@broccolinisoup
Copy link
Member

@joshblack The only change I couldn't confirm was the generated/component.json from #3414 since we don't include it anymore in the source due to the deploy job didn't run.

@siddharthkp
Copy link
Member

siddharthkp commented Oct 24, 2023

@siddharthkp
Copy link
Member

siddharthkp commented Oct 24, 2023

@joshblack
Copy link
Member Author

Thanks @siddharthkp! Opened up: #3859 for the second issue and will try to tackle it today 👍

joshblack and others added 7 commits October 24, 2023 11:55
* Update pagelayout pane changeset

* Update docs for PageLayout.Pane

* Update SplitPageLayout.Pane docs

* Update yellow-windows-accept.md

* positionWhenNarrow is never actually used

* delete deprecated prop from test

* add components changed to changeset

* Update changeset for ConfirmationDialog
* revert: restore original PageLayout behavior

* test(e2e): update snapshots

* test(e2e): update snapshots

* chore: remove changeset

---------

Co-authored-by: Josh Black <joshblack@users.noreply.github.com>
@github-actions github-actions bot temporarily deployed to storybook-preview-3384 October 30, 2023 16:16 Inactive
@joshblack joshblack temporarily deployed to github-pages October 30, 2023 16:18 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3384 October 30, 2023 16:19 Inactive
@joshblack joshblack added this pull request to the merge queue Oct 30, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 30, 2023
@joshblack joshblack added this pull request to the merge queue Oct 30, 2023
Merged via the queue into main with commit 3633535 Oct 30, 2023
44 checks passed
@primer primer bot mentioned this pull request Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants