Skip to content

Octicon → StyledOcticon, export, tests #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 24, 2018
Merged

Conversation

shawnbot
Copy link
Contributor

@shawnbot shawnbot commented Oct 24, 2018

Fixes #223 based on @broccolini's suggestion to call it StyledOcticon. Here's how you use it:

import {StyledOcticon} from '@primer/components'
import {X} from '@githubprimer/octicons-react'

export default () => <StyledOcticon mx={2} icon={X} />

👀 See the docs in action

@vercel
Copy link

vercel bot commented Oct 24, 2018

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Copy link

@emplums emplums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 Beat me to it! Looks good!

@shawnbot shawnbot changed the base branch from master to q4-haunted-kittens October 24, 2018 19:38
@shawnbot shawnbot merged commit 9a92011 into q4-haunted-kittens Oct 24, 2018
@shawnbot shawnbot deleted the styled-octicon branch October 24, 2018 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants