Skip to content

Decide: should we export our styled Octicon component? #223

Closed
@shawnbot

Description

@shawnbot

We have an internal version of the Octicon component from the octicons-react package with system props. I think it makes sense to export for public consumption, but we have a couple of options for doing so:

  1. Just export Octicon from primer-react as-is;
  2. Call it something more explicit, like PrimerOcticon (which seems redundant to me);
  3. Nix our styled component and update our examples to wrap it in <Text> or <Box> to apply margins, etc.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions