Skip to content

Remove --primer prefix from CSS var #3209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 21, 2023
Merged

Remove --primer prefix from CSS var #3209

merged 4 commits into from
Apr 21, 2023

Conversation

langermank
Copy link
Contributor

Preparing for Primitives v8. This will be bumped in dotcom soon, and since it has a fallback there should be no issues renaming it right now.

If there are more CSS vars being used that I couldn't find, let me know!

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

@langermank langermank requested review from a team and colebemis April 21, 2023 18:35
@changeset-bot
Copy link

changeset-bot bot commented Apr 21, 2023

🦋 Changeset detected

Latest commit: c145ae0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@langermank langermank requested a review from mperrotti April 21, 2023 18:36
@github-actions
Copy link
Contributor

github-actions bot commented Apr 21, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 95.37 KB (-0.01% 🔽)
dist/browser.umd.js 95.91 KB (-0.01% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-3209 April 21, 2023 18:41 Inactive
@langermank langermank temporarily deployed to github-pages April 21, 2023 18:43 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3209 April 21, 2023 18:43 Inactive
@langermank langermank added this pull request to the merge queue Apr 21, 2023
Merged via the queue into main with commit a627953 Apr 21, 2023
@langermank langermank deleted the css-var-update branch April 21, 2023 19:20
@primer-css primer-css mentioned this pull request Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants