Skip to content

Release tracking #3202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Release tracking #3202

merged 1 commit into from
Apr 24, 2023

Conversation

primer-css
Copy link
Contributor

@primer-css primer-css commented Apr 20, 2023

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@primer/react@35.25.1

Patch Changes

  • #3174 d4c6ae5b Thanks @colebemis! - MarkdownEditor is now SSR-compatible.

    Warning: In this new implementation, MarkdownEditor.Toolbar, MarkdownEditor.Actions, and MarkdownEditor.Label must be direct children of MarkdownEditor.

  • #3209 a6279536 Thanks @langermank! - Remove --primer prefix from CSS var

  • #3173 6b900e90 Thanks @colebemis! - ActionList and NavList are now SSR-compatible.

    Warning: In this new implementation, ActionList.LeadingVisual, ActionList.TrailingVisual, and ActionList.Description must be direct children of ActionList. The same applies to NavList.

  • #3198 a273748b Thanks @langermank! - Bug fix: ButtonGroup borders show incorrectly on hover

@primer-css primer-css requested review from a team and langermank April 20, 2023 13:55
@github-actions
Copy link
Contributor

github-actions bot commented Apr 20, 2023

❗ Pre-merge checklist

Please ensure these items are checked before merging.

🔎 Smoke test

  • All CI checks pass
  • Docs and Storybook open in a browser
  • Successful integration test with github/github as a primary consumer of Primer React: https://github.com/github/github/pull/270644
    • Install the Release Candidate
    • Verify no new build errors appear
    • Verify no new linting errors appear
    • Verify no new browser console errors appear
    • Verify unit tests and E2E tests pass
    • Manually test critical paths (Tip: Use the provided tests project boards)
    • Manually test release-specific bugfixes and/or features work as described
  • Works in CodeSandbox or StackBlitz
    • New components render successfully
    • (optional) Tested in both SPA and SSR apps if release contains build changes

🤔 Sanity test

  • All bugfixes in this release have resolved their corrosponding issues
  • All new features in this release have been tested and verified as compatible with GitHub Projects
  • No noticeable regressions have not been introduced as a result of changes in this release
  • Release notes accurately describe the changes made

🚢 After merge

  • Add the preview deployment's link to releases as a way of permalinking to old version's docs. Example

Please also leave any testing notes as a comment on this pull request. In particular, describing any issues encountered during your testing. This is helpful in providing historical context to maintainers.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 20, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 95.37 KB (0%)
dist/browser.umd.js 95.91 KB (0%)

@primer-css primer-css temporarily deployed to github-pages April 20, 2023 14:03 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3202 April 20, 2023 14:03 Inactive
@primer-css primer-css force-pushed the changeset-release/main branch from 8dbbaea to 83ea738 Compare April 20, 2023 15:27
@primer-css primer-css temporarily deployed to github-pages April 20, 2023 15:34 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3202 April 20, 2023 15:34 Inactive
@primer-css primer-css force-pushed the changeset-release/main branch from 83ea738 to 6c3eda9 Compare April 20, 2023 20:11
@primer-css primer-css temporarily deployed to github-pages April 20, 2023 20:18 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3202 April 20, 2023 20:18 Inactive
@primer-css primer-css force-pushed the changeset-release/main branch from 6c3eda9 to dc76a97 Compare April 20, 2023 22:57
@primer-css primer-css temporarily deployed to github-pages April 20, 2023 23:06 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3202 April 20, 2023 23:06 Inactive
@primer-css primer-css force-pushed the changeset-release/main branch from dc76a97 to 14aef53 Compare April 21, 2023 14:02
@primer-css primer-css temporarily deployed to github-pages April 21, 2023 14:07 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3202 April 21, 2023 14:08 Inactive
@primer-css primer-css force-pushed the changeset-release/main branch 2 times, most recently from 9e74285 to ab1749e Compare April 21, 2023 17:49
@primer-css primer-css temporarily deployed to github-pages April 21, 2023 17:57 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3202 April 21, 2023 17:57 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3202 April 21, 2023 17:58 Inactive
@primer-css primer-css force-pushed the changeset-release/main branch from ab1749e to a8f2ed6 Compare April 21, 2023 19:21
@primer-css primer-css temporarily deployed to github-pages April 21, 2023 19:28 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3202 April 21, 2023 19:28 Inactive
@primer-css primer-css force-pushed the changeset-release/main branch from a8f2ed6 to dd269fd Compare April 21, 2023 20:25
Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tests passing in gh/gh

@siddharthkp siddharthkp added this pull request to the merge queue Apr 24, 2023
Merged via the queue into main with commit 0039d7b Apr 24, 2023
@siddharthkp siddharthkp deleted the changeset-release/main branch April 24, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants